Source: apport
Version: 2.15.1-1
Severity: serious
Tags: patch
Justification: fails to build from source
Control: found -1 apport/2.14.2-2

Hi,

apport fails to build in arch-only builds (debian/rules build-arch),
as done e.g. on buildds [1].

This happens because python(3)-distutils and python(3)-apt seem to be
mandatory when building, and they are pulled as Build-Depends-Indep,
so not when doing arch-only builds.
Furthermore, the dh_install override edits files of arch:all binaries,
which are not available in arch-only builds.

The attached patch fixes these issues:
- python-distutils-extra, python-apt, python3-distutils-extra, and
  python3-apt are now Build-Depends
- apport-retrace and apport-kde are edited only when building their
  binaries

[1] https://buildd.debian.org/status/logs.php?pkg=apport&ver=2.15.1-1

Thanks,
-- 
Pino
--- a/debian/control
+++ b/debian/control
@@ -9,11 +9,12 @@ Build-Depends: debhelper (>= 7.0.50~),
  net-tools,
  xauth,
  python-all,
- python3-all
-Build-Depends-Indep: python-distutils-extra (>= 2.24~),
- python3-distutils-extra (>= 2.24~),
+ python3-all,
+ python-distutils-extra (>= 2.24~),
  python-apt (>= 0.7.9),
+ python3-distutils-extra (>= 2.24~),
  python3-apt (>= 0.7.9),
+Build-Depends-Indep:
  intltool,
  xvfb,
  python-mock,
--- a/debian/rules
+++ b/debian/rules
@@ -34,12 +34,16 @@ override_dh_install:
 	dh_install -X.pyc -X.egg-info --list-missing
 	pod2man -c Debhelper -r "$(DEB_VERSION)" debian/debhelper/dh_apport debian/debhelper/dh_apport.1
 
+ifneq (, $(filter apport-retrace, $(shell dh_listpackages)))
         # apport-retrace needs python-launchpadlib, which is not yet available
         #         # for Python 3; so switch back to Python 2
 	sed -i '1 s/python3.*$$/python/' debian/apport-retrace/usr/bin/apport-retrace
+endif
 
+ifneq (, $(filter apport-kde, $(shell dh_listpackages)))
 	# Same applies for KDE4...
 	sed -i '1 s/python3.*$$/python/' debian/apport-kde/usr/share/apport/apport-kde
+endif
 
 override_dh_python3:
 	dh_python3 --skip-private

Reply via email to