Your message dated Sat, 06 Feb 2016 16:19:02 +0000
with message-id <e1as5ze-00028m...@franck.debian.org>
and subject line Bug#809505: fixed in bluez-tools 0.2.0~20140808-5
has caused the Debian Bug report #809505,
regarding bt-obex: crash with "Segmentation Fault" when trying to send a file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
809505: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809505
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: bluez-tools
Version: 0.2.0~20140808-4
Severity: grave
Tags: patch upstream
Justification: renders package unusable

Dear Maintainer,

While trying to use bt-obex command to exchange file with a mobile phone device,
I have faced a number of unexpected Segmentation Faults.

I took time to investigate and found the problem in the source, so I have 
prepared
a patch that I have sent to Alexander Orlenko which seems to be the author of 
the
tools, in hope to have it integrated upstream.

I have attached the patch of interrest (5th of 5 patches), but be warned that I
have made it against Git's latest state, so I am not sure it would apply to the
current debian source state.

I am adding Sam Morris in copy because he has reported 2 bugs which may be 
linked
to similar issue, so if he has the possibility to test it would be interresting
to know if it improves his cases.

Regards,
Christophe.


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
>From 5046c746adbaba3137723a5be38e705f5d29e606 Mon Sep 17 00:00:00 2001
From: Christophe CURIS <christophe.cu...@free.fr>
Date: Thu, 31 Dec 2015 12:03:16 +0100
Subject: [PATCH 5/5] Fix incorrect return value compare

In the function obex_client_create_session, when the call to the dbus
function would return a NULL pointer then the program would terminate with
a "Segmentation Fault" message without further explanation, and it is not
sure that in other cases it did behave as expected.

Now the bt-obex command properly display the error message when dbus gives
one and works in the other case.

Signed-off-by: Christophe CURIS <christophe.cu...@free.fr>
---
 src/lib/bluez/obex/obex_client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/bluez/obex/obex_client.c b/src/lib/bluez/obex/obex_client.c
index 02b65bb..2a4f20a 100644
--- a/src/lib/bluez/obex/obex_client.c
+++ b/src/lib/bluez/obex/obex_client.c
@@ -144,7 +144,7 @@ const gchar *obex_client_create_session(ObexClient *self, const gchar *destinati
 	g_assert(OBEX_CLIENT_IS(self));
 	const gchar *ret = NULL;
 	GVariant *proxy_ret = g_dbus_proxy_call_sync(self->priv->proxy, "CreateSession", g_variant_new ("(s@a{sv})", destination, args), G_DBUS_CALL_FLAGS_NONE, -1, NULL, error);
-	if (proxy_ret != NULL)
+	if (proxy_ret == NULL)
 		return NULL;
 	proxy_ret = g_variant_get_child_value(proxy_ret, 0);
 	ret = g_variant_get_string(proxy_ret, NULL);
-- 
2.6.4


--- End Message ---
--- Begin Message ---
Source: bluez-tools
Source-Version: 0.2.0~20140808-5

We believe that the bug you reported is fixed in the latest version of
bluez-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 809...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwama...@debian.org> (supplier of updated bluez-tools 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 04 Jan 2016 04:55:49 +0900
Source: bluez-tools
Binary: bluez-tools
Architecture: source amd64
Version: 0.2.0~20140808-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Bluetooth Maintainers 
<pkg-bluetooth-maintain...@lists.alioth.debian.org>
Changed-By: Nobuhiro Iwamatsu <iwama...@debian.org>
Description:
 bluez-tools - Set of tools to manage Bluetooth devices for linux
Closes: 785603 809505
Changes:
 bluez-tools (0.2.0~20140808-5) unstable; urgency=medium
 .
   * Fix crash with "Segmentation Fault" when trying to send a file on bt-obex.
     Add patches/Fix-incorrect-return-value-compare.patch. (Closes: #809505)
     Thanks to Christophe <christophe.cu...@free.fr>.
   * Fix segmentation fault in bt-agent when attempting to use PIN code.
     Add patches/agent-helper.c.patch. (Closes: #785603)
     Thanks to Bob Frazier <b...@mrp3.com>.
   * Update tag of Homepage to https://github.com/khvzak/bluez-tools.
Checksums-Sha1:
 c233073c9ee1836565ff26862a469524c49e86e4 2156 bluez-tools_0.2.0~20140808-5.dsc
 0a7a0f6ea483b721f8701fba993c4a8cda20b8ae 4900 
bluez-tools_0.2.0~20140808-5.debian.tar.xz
 53a8e85c1e14e0261afcd218ef7c9576b20b7025 760664 
bluez-tools-dbgsym_0.2.0~20140808-5_amd64.deb
 88ab24952fbaa5024f04aabce08831cebab3ea21 138702 
bluez-tools_0.2.0~20140808-5_amd64.deb
Checksums-Sha256:
 3e3774bd6f3e4d9bdd99840174aa5f255cb725685fcba7f972c69ab02a818cb3 2156 
bluez-tools_0.2.0~20140808-5.dsc
 a7c3d9ea1b4cf21a8bcebbeedcc9e401ea31c7df53b289560078f49d25806fb2 4900 
bluez-tools_0.2.0~20140808-5.debian.tar.xz
 1ee9ee70d82262656b20dba8b5123835d7bbcc9139f124eebbce55d5772bf843 760664 
bluez-tools-dbgsym_0.2.0~20140808-5_amd64.deb
 9fba513e64db94b4045bacb548093a8a83dd0646c7611c5907b29d9efdec31de 138702 
bluez-tools_0.2.0~20140808-5_amd64.deb
Files:
 e7a37788aebfb90858ee72baec068f28 2156 utils optional 
bluez-tools_0.2.0~20140808-5.dsc
 1843917ca0fa4b81ed900a7eacf552dd 4900 utils optional 
bluez-tools_0.2.0~20140808-5.debian.tar.xz
 c359396a6899661fad594cbe0c08b68b 760664 debug extra 
bluez-tools-dbgsym_0.2.0~20140808-5_amd64.deb
 42ca94d833c8bb3dc19deb175f88c1fd 138702 utils optional 
bluez-tools_0.2.0~20140808-5_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWthYBAAoJEDIkf7tArR+mrA4P/2fAAFqK7VLEYQCoKt9XHCWE
oE5MEr2IWWCfsN+xBsuDLkdKIyHBZWUssIfgyk/9PM6FzihvJCZR/9/Vcd9K1Nc6
+BDNNo/upnvXJnTmJbbGU4ZN7xK3rL0C2tVhlq2fNceNbI1vB61QkuOIJqo779m3
2JbI9Y7zhAjxFPLhINcDUTmTW+BEQ6Q8hSlrrBCe8uq6C2E0WSSeNod0aa8/+xzN
BOzlNn8M06BskclPm7e1VvAda+RMdUfoKcX1CFhWZbdth0cJ6jG/xqGZ8d+Y7XRz
TTXDQIhrB0mrlt2i4U4Fo3lRH82nanMB827CzdLmuOrh6fPSDZgP9ZjPsZloNXGi
xnwfvMmFY5TP9l5lEIjAgCvUYvXN3ZOgwzgK9MS2apVBd+2wvV9qZQSmxXSTJHWZ
hyZZDCY14EYxVPN9pTXoj1s4hhnTr9y4CRVSZNWXXzi9Y8kqjpjwYg2TUk8f74XX
m3sufwfmix/4jY1yYz2ozpNNwYun7NMH+udNWDGBk3zqX0VqNs9yELFcbqR3FySo
0UY74pqlgmewiH2S+9X/Ndn+Th3gYoj4hD5WN9y83rvlwAK3Sm04PJn/fUlLEjcY
WXKZOCgs+GYB32B3OYO7O4Woc5EQe8tY8QpAIU4sCbnRM63tkppqYPY9YTs1vbZN
5RVavhbeMOklzSHSAGAB
=TMve
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to