Bug#839048: js24 crashes on ARM64

2016-12-12 Thread Zheng Xu
On 12 December 2016 at 13:59, Ben Hutchings wrote: > On Mon, 2016-12-12 at 13:51 +0800, Zheng Xu wrote: > > mozjs24 -- The patch is the back port version of the upstream one. It > > doesn't change the ABI. > > Unfortunately, the patch that was applied does change the ABI. >

Bug#839048: js24 crashes on ARM64

2016-12-11 Thread Ben Hutchings
On Mon, 2016-12-12 at 05:59 +, Ben Hutchings wrote: > On Mon, 2016-12-12 at 13:51 +0800, Zheng Xu wrote: [...] > > mozjs1.8.5 -- The patch is different with the upstream one. Because in the > > old js, there might be objects pass from C allocation, only modify the heap > > doesn't work. The

Bug#839048: js24 crashes on ARM64

2016-12-11 Thread Ben Hutchings
On Mon, 2016-12-12 at 13:51 +0800, Zheng Xu wrote: > Sorry for making people confused. The patch I uploaded for mozj24 and > mozjs1.8.5 are different. > mozjs24 -- The patch is the back port version of the upstream one. It > doesn't change the ABI. Unfortunately, the patch that was applied does

Bug#839048: js24 crashes on ARM64

2016-12-11 Thread Zheng Xu
Sorry for making people confused. The patch I uploaded for mozj24 and mozjs1.8.5 are different. mozjs24 -- The patch is the back port version of the upstream one. It doesn't change the ABI. mozjs1.8.5 -- The patch is different with the upstream one. Because in the old js, there might be objects

Bug#839048: js24 crashes on ARM64

2016-12-10 Thread Ben Hutchings
On Sun, 2016-12-11 at 03:24 +0100, John Paul Adrian Glaubitz wrote: > On 12/11/2016 03:13 AM, Ben Hutchings wrote: > > Looking at the patch that was added in -4: WTF?  It changes the library > > ABI, but you didn't bump the soname.  Of course that breaks clients! > > That's odd. Why does it break

Bug#839048: js24 crashes on ARM64

2016-12-10 Thread John Paul Adrian Glaubitz
On 12/11/2016 03:24 AM, John Paul Adrian Glaubitz wrote: >> libmozjs185 appears to have been broken in the same way. > > Is it? As far as I know, the patch was not merged to src:mozjs. To be more precise: I merged the patch that Zheng attached to the bug report which is different from the

Bug#839048: js24 crashes on ARM64

2016-12-10 Thread John Paul Adrian Glaubitz
On 12/11/2016 03:13 AM, Ben Hutchings wrote: > Looking at the patch that was added in -4: WTF? It changes the library > ABI, but you didn't bump the soname. Of course that breaks clients! That's odd. Why does it break the ABI though? From what I can see, the upstream change just forces the JS

Bug#839048: js24 crashes on ARM64

2016-12-10 Thread Ben Hutchings
On Sat, 10 Dec 2016 18:27:05 -0500 Jeremy Bicha wrote: > Control: reopen -1 >  > The fix for this broke gdm, gnome-shell, and cinnamon and had to be > reverted so I'm reopening this bug. >  > mozjs24 (24.2.0-5) unstable; urgency=low >  >   * Revert fix for ARM64 crashes, causes