Your message dated Thu, 16 Nov 2017 00:55:42 +0000
with message-id <e1ef8t0-0006y1...@fasolo.debian.org>
and subject line Bug#881627: fixed in ruby-http-parser.rb 0.6.0-4
has caused the Debian Bug report #881627,
regarding ruby-http-parser.rb: FTBFS with newer http-parser version
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
881627: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881627
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: ruby-http-parser.rb
Version: 0.6.0-3+b3
Severity: serious
Tags: upstream
Dear Maintainer,
your package build-depends on http-parser, and a new version of that
one has been around for a while. Even before eventually uploading last
night I already saw a problem in the test suite of your package.
However, due to a fault on my side, the new http-parser went to
unstable instead of experimental. So this increases the pressure for
your package, sorry about that.
With http-parser 2.7.1, one test fails:
1) HTTP::Parser should parse request: line folding in header value
Failure/Error: expect(@headers).to eq(test['headers'])
expected: {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"}
got: {"Line1"=>"abc\tdef ghi\t\tjkl mno \t \tqrs",
"Line2"=>"line2\t"}
(compared using ==)
Diff:
@@ -1,3 +1,3 @@
-"Line1" => "abcdefghijklmno qrs",
+"Line1" => "abc\tdef ghi\t\tjkl mno \t \tqrs",
"Line2" => "line2\t",
# ./spec/parser_spec.rb:347:in `block (4 levels) in <top (required)>'
If I understand correctly, this is taken from spec/support/requests.json
line 445 and 457f.
While doubtlessly http-parser changed the behaviour, I'm not sure yet
whether this wasn't rather about fixing bugs - bugs the test in
ruby-http-parser.rb relied upon.
However, HTTP header line folding is complicated and actually also
deprecated in RFC 7230. Reading that one and also the older description
in RFC 2616 I guess there a too many freedoms to expect a certain
result. Also it seems http-parser 2.7.1 does unfolding in a ...
surprising manner.
Now, quite frankly, my main interest is a sound solution. Otherwise,
I'm not keen on legal discussions, especially when it's about a
deprecated feature like this one. It's my job to sort these things out
with http-parser upstream but since I'm not sure how long this will
take: Would you mind disabling or relaxing the test on your side for
the time being? You might as well upgrade the test to the one in
http-parser/test.c¹ which is where obviously it was taken from in the
first place - but I'd expect this to change again soon.
Sorry for the mess, and kind regards,
Christoph
¹ https://github.com/nodejs/http-parser/blob/master/test.c (line 614)
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: ruby-http-parser.rb
Source-Version: 0.6.0-4
We believe that the bug you reported is fixed in the latest version of
ruby-http-parser.rb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 881...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Cédric Boutillier <bou...@debian.org> (supplier of updated ruby-http-parser.rb
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 15 Nov 2017 23:15:54 +0100
Source: ruby-http-parser.rb
Binary: ruby-http-parser.rb ruby-http-parser.rb-doc
Architecture: source
Version: 0.6.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers
<pkg-ruby-extras-maintain...@lists.alioth.debian.org>
Changed-By: Cédric Boutillier <bou...@debian.org>
Description:
ruby-http-parser.rb - Simple callback-based HTTP request/response parser
ruby-http-parser.rb-doc - Simple callback-based HTTP request/response parser
(documentation
Closes: 881627
Changes:
ruby-http-parser.rb (0.6.0-4) unstable; urgency=medium
.
* Team upload
* Remove version in the gem2deb build-dependency
* Use https:// in Vcs-* fields
* Run wrap-and-sort on packaging files
* Bump Standards-Version to 4.1.1 (no changes needed)
* Bump debhelper compatibility level to 10
* Add Testsuite field for autopkgtest
* Add 0006-disable-folding-header-test.patch to support newer http-parser
(Closes: #881627). Thanks Christoph Biedl for the patch!
Checksums-Sha1:
56958edb0a313101feb149baad6b217032936011 1969 ruby-http-parser.rb_0.6.0-4.dsc
73af345a0e4b977eaf78509d11a5672c01c16af2 7888
ruby-http-parser.rb_0.6.0-4.debian.tar.xz
253e028fdd4a8ae796c072ec8a96f7db9aedb0f2 6535
ruby-http-parser.rb_0.6.0-4_source.buildinfo
Checksums-Sha256:
ca4d6fb73e43afb5c5c2c70a5bdf7e431e906fbea24284a86bf58629977f9762 1969
ruby-http-parser.rb_0.6.0-4.dsc
fb07837143977108e1c8fecac2fd036ff31f1cd462c73da3033513f1d6ec4a62 7888
ruby-http-parser.rb_0.6.0-4.debian.tar.xz
0a5828b880e15dc2927333d9b1cb7d0c9d8078f120aa933a12a985833cb10f16 6535
ruby-http-parser.rb_0.6.0-4_source.buildinfo
Files:
0e46a5ca2c06493d09415ec0ee97afcc 1969 ruby optional
ruby-http-parser.rb_0.6.0-4.dsc
72c0e05d20e0d8bbd1506af8ffd90284 7888 ruby optional
ruby-http-parser.rb_0.6.0-4.debian.tar.xz
53a1c6f189881c9e85eac66cbd90899d 6535 ruby optional
ruby-http-parser.rb_0.6.0-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEnM1rMZ2/jkCrGr0aia+CtznNIXoFAloM0sIACgkQia+CtznN
IXpV5Af+Nmm3nl6JS/ZjCdIEzxEB1Z6ftH4m3qr/jqSg6YXdrOY8qmUyWhzybMWw
xmR3hPcV6k2XL9INh0STn58UtMJyrSwjTXbu2jmN5d2LmoEuYRLwBBBi8E3ySTHp
mdJsuzPByrK6Z1yKApGKB8uina0CN36AXYo4rvcHWB1DPeo2MPYDt1BFPHf3C2NI
v3X+lkQ/Ef71HIJ6HZcnUUjB20kyf7BCh7BUnC6ccFQxImbqiWZf7QyOY2/3l6p1
LoiJCTG+Zv/aJ3956VRsA11teWo+boGfB8Ts8VeZ/ZVj1m88jk7EMwHSZb6bdNu9
FJ8FShR7xdlwKcjjefeOhj63I8NByQ==
=gNMT
-----END PGP SIGNATURE-----
--- End Message ---
