Your message dated Thu, 15 Feb 2018 21:04:59 +0000 with message-id <e1emqib-000ev7...@fasolo.debian.org> and subject line Bug#888578: fixed in debian-handbook 8.20180215 has caused the Debian Bug report #888578, regarding debian-handbook: FTBFS with debhelper/11.1 due to empty build target to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 888578: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888578 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: debian-handbook Version: 8.20170323 Severity: serious Tags: patch Hi, The debian-handbook package FTBFS with debhelper/11.1 as it has an empty build target. This is caused by debhelper had a bug in its handling of "explicitly defined rules targets" that has now been fixed. Previously, this happened to work because dpkg-buildpackage would invoke "debian/rules build" (which would be a no-op) followed by "fakeroot debian/rules binary". During the binary target, dh's suboptimal handling would run the build commands. The solution is trivial but less pretty; explicitly define "build" with the same content as the "%:" target (or rename the "build" folder and drop the ".PHONY" target). I have attached a patch for this. (There is also a bonus patch for a missing "set -e") More details can be found in: * #886901 comment #35 * #887688 comment #37 * #880840 Apologies for the inconvenience. Thanks, ~Niels>From 0b89dcf55f2b0233e7a42359aa4d67a3ad8994f3 Mon Sep 17 00:00:00 2001 From: Niels Thykier <ni...@thykier.net> Date: Sat, 27 Jan 2018 11:12:17 +0000 Subject: [PATCH 1/2] Avoid empty build target The dh sequencer as of debhelper/11.1 is stricter with this in other to solve #880840 (where debhelper would fail to handle such targets correctly). Signed-off-by: Niels Thykier <ni...@thykier.net> --- debian/rules | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index cafab34..83adbd9 100755 --- a/debian/rules +++ b/debian/rules @@ -5,7 +5,12 @@ VERSION=$(shell sed -n -e 's|.*<productnumber>\(.*\)</productnumber>.*|\1|p' en- LANGS=$(shell echo [a-z][a-z]-[A-Z][A-Z]) %: - dh $@ + dh $@ + +# The build target must not be empty. Sadly because of how make +# works, we have do duplicate the target in this case. +build: + dh $@ override_dh_auto_build: set -e; for lang in $(LANGS); do \ -- 2.15.1>From be43e989f5d2e20555b4bbbc96e4ba9c6e220d63 Mon Sep 17 00:00:00 2001 From: Niels Thykier <ni...@thykier.net> Date: Sat, 27 Jan 2018 11:18:20 +0000 Subject: [PATCH 2/2] d/rules: Add missing "set -e" in a for-loop Signed-off-by: Niels Thykier <ni...@thykier.net> --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 83adbd9..37ee082 100755 --- a/debian/rules +++ b/debian/rules @@ -19,7 +19,7 @@ override_dh_auto_build: override_dh_auto_install: mkdir -p $(DOCDIR) - for lang in $(LANGS); do \ + set -e; for lang in $(LANGS); do \ mv publish/$$lang/Debian/$(VERSION)/html/debian-handbook $(DOCDIR)/$$lang; \ done # Drop some useless files -- 2.15.1
--- End Message ---
--- Begin Message ---Source: debian-handbook Source-Version: 8.20180215 We believe that the bug you reported is fixed in the latest version of debian-handbook, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 888...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Raphaël Hertzog <hert...@debian.org> (supplier of updated debian-handbook package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 15 Feb 2018 20:56:52 +0100 Source: debian-handbook Binary: debian-handbook Architecture: source Version: 8.20180215 Distribution: unstable Urgency: medium Maintainer: Raphaël Hertzog <hert...@debian.org> Changed-By: Raphaël Hertzog <hert...@debian.org> Description: debian-handbook - reference book for Debian users and system administrators Closes: 888575 888578 Changes: debian-handbook (8.20180215) unstable; urgency=medium . * Update translations. * Move git repository to salsa.debian.org and update Vcs-* fields. * Rename the "build" directory into "bin". Closes: #888578 * Build different languages in parallel to optimize build time. Closes: #888575 * Switch to debhelper compat level 11 (thus enabling parallel build by default). * Bump Standards-Version to 4.1.3. * Mark the package as "Multi-Arch: foreign" to please the multiarch hinter even though it's unlikely this package will be in any dependency. Checksums-Sha1: 03f6a1c7f359e6c1e08db5d2782d566717f938d8 1625 debian-handbook_8.20180215.dsc 3bcffe57f37b44bbec8c2c57ad83bccfd7c81499 66700648 debian-handbook_8.20180215.tar.xz e5ceeaf41e98dbfd489faaac4149ef38fe945dba 18193 debian-handbook_8.20180215_source.buildinfo Checksums-Sha256: 976310fd96a130cd43c7e0b82537cf974e85e9475721f6f409896ec7b54302b7 1625 debian-handbook_8.20180215.dsc 605c6d4d31a7ab5d003aa1e56774903e90beee0f553fb363fa863b11da5f59b8 66700648 debian-handbook_8.20180215.tar.xz 6c7bbc8c8b654d432e1e881ee70ceea55b31fb9ccf9ec89cf41b292b1ac88c80 18193 debian-handbook_8.20180215_source.buildinfo Files: af4554fa3dd2dd840fa6a36756f88a06 1625 doc optional debian-handbook_8.20180215.dsc d75f3eae86bf40a3e3133d87a3e61702 66700648 doc optional debian-handbook_8.20180215.tar.xz bd113a30d721bef2d4e365c834591bae 18193 doc optional debian-handbook_8.20180215_source.buildinfo -----BEGIN PGP SIGNATURE----- Comment: Signed by Raphael Hertzog iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAlqF5mUACgkQA4gdq+vC mrnujAf8CyQL1v2Pp4rm60NgIV6y1iIV4Bk+1aoMV5LpsrCKxN36WTLOzzWDK637 li2m9q318G4wG2E0DEm1vfmdX+pdauCSoNpKpkcNoi2hfdeo5ikSn0P+oWINqKXv 3kAki4Gu2GBJQDJPyv+3W0SQXnreBM1HBz96awnlYbwIBRN+h4wuriRJXHjgZTj0 +uL3f1tSSDTczMK4zX05Lugc709+nWpVKMoW+o3v1Ri8vm2R5l6BXxItLs6qEVjE gYLEofSpS6nQlJfBRqMGmMgUGAFkO3BhL4+nVLneI2L+DPwtvmxtqc6H4ZsRoQMJ zBKxB69CFfiC4q3I0Bwt2jXEZXu3oA== =SlKp -----END PGP SIGNATURE-----
--- End Message ---
