Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-21 Thread Guilhem Moulin
On Sun, 21 Jul 2019 at 22:40:38 +0200, Michael Biebl wrote: > I already uploaded 2.20-7+deb10u1 with this changelog, so it's not > really possible anymore to undo this other then making a 2.20-7+deb10u2 > upload, which seems like overkill to me. > I don't think the changelog is that misleading

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-21 Thread Michael Biebl
Hi Am 21.07.19 um 21:58 schrieb Guilhem Moulin: > Now that libblockdev uses crypt_keyslot_change_by_passphrase() there is > AFAICT nothing more to be done on the libblockdev or udisks2 side with > respect to that bug. But maybe the Changelog entry for libblockdev > 2.20-7+deb10u1 should be

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-21 Thread Guilhem Moulin
Hi, On Sun, 21 Jul 2019 at 13:36:06 +0200, Michael Biebl wrote: > Agreed. I've just uploaded a libblockdev with that cherry-pick to buster > and this change was acked by the SRMs, so should be in 10.1. Awesome! :-) > Regarding the LUKS2/udisks2/LimitMEMLOCK issue, would you prefer to > track

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-21 Thread Michael Biebl
Hi Guilhem, hi intrigeri, first of all, thanks for debugging this issue and this excellent bug report! On Sat, 20 Jul 2019 17:24:21 -0300 Guilhem Moulin wrote: > However as far as libblockdev is concerned, FWIW I fully support > intrigeri's cherry-pick of upstream's 34ed7be. Adding a key slot

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-20 Thread Guilhem Moulin
On Sat, 20 Jul 2019 at 06:01:35 -0300, Guilhem Moulin wrote: > LUKS2_get_volume_key_size() fails because the key size is specified in > the ‘keyslots’ object of LUKSv2's JSON header [0], and that object is > the empty array at that point. Forgot to add another data point which supports my claim:

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-20 Thread Guilhem Moulin
Hi there, On Fri, 19 Jul 2019 at 22:14:49 -0300, intrigeri wrote: > it turns out this is caused by a bug in libblockdev, which is fixed in > sid already (although it seems like upstream applied the fix for > unrelated reasons and it's not clear whether they realized this bug > was a possibility).

Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-19 Thread intrigeri
Control: reassign -1 libblockdev-crypto2 Control: found -1 2.20-7 Control: fixed -1 2.22-1 Control: affects -1 gnome-disk-utility Control: affects -1 udisks2 Control: tag -1 + patch Hi, it turns out this is caused by a bug in libblockdev, which is fixed in sid already (although it seems like

Processed: Re: Bug#928893: gnome-disk-utility: disk content permamently lost when changing LUKS password

2019-07-19 Thread Debian Bug Tracking System
Processing control commands: > reassign -1 libblockdev-crypto2 Bug #928893 [gnome-disk-utility] gnome-disk-utility: disk content permanently lost when changing LUKS password Bug reassigned from package 'gnome-disk-utility' to 'libblockdev-crypto2'. No longer marked as found in versions