Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-10 Thread Reinhard Tartler
Control: tag -1 patch On Wed, Nov 10, 2021 at 7:55 AM Shengjing Zhu wrote: > > > > Cloud you backport following commit? > > > > > > > https://github.com/containers/libocispec/commit/8489d9b60105e487564c9966b5748e2a6ea2855b > > > > > This patch updates libocispec/Makefile.am, which is needed to

Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-10 Thread Shengjing Zhu
On Wed, Nov 10, 2021 at 07:27:58AM -0500, Reinhard Tartler wrote: > That's not sufficient. > > the commit you point out does two things: > > - update the submodules for 'image-spec' and 'runtime-spec' (which the > Debian package currently overrides with the distro-provided copies) > -

Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-10 Thread Reinhard Tartler
Looking more into it, here are more observations: - crun upstream has a git submodule on 'libocispec' (the repo you asked me to backport). The release tarballs contain a copy of the submodule contents at the time of the release - the 'libocispec' submodule contains two additional submodules

Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-10 Thread Reinhard Tartler
That's not sufficient. the commit you point out does two things: - update the submodules for 'image-spec' and 'runtime-spec' (which the Debian package currently overrides with the distro-provided copies) - zos-related changes to the rust bindings (which the Debian package doesn't have at all

Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-09 Thread Shengjing Zhu
Cloud you backport following commit? https://github.com/containers/libocispec/commit/8489d9b60105e487564c9966b5748e2a6ea2855b (Sent on my mobile phone) Reinhard Tartler 于 2021年11月10日周三 07:05写道: > I took a look at the issue and here are my thoughts: > > - the build error is a failure to link

Bug#997225: Vendoring image-spec and runtime-spec seem to be the issue

2021-11-09 Thread Reinhard Tartler
I took a look at the issue and here are my thoughts: - the build error is a failure to link some test binaries. excluding them from the build might be possible with some patching. - I've upgraded the package to the latest upstream 1.3, and was seeing exactly the same build failure - the build