Bug#637209: sks install is broken in 2 ways
tags 637209 +moreinfo thanks On Tue, Aug 09, 2011 at 02:26:10PM +0100, sentimental.br...@gmail.com wrote: Flaws with installation: Incorrect ownership of /var/log/sks/db.log Please always state precisely what is wrong. Otherwise a maintainer can only guess what might be wrong. (See below for my guess.) sks executable located in /usr/sbin/sks So where is the flaw with putting a daemon in /usr/sbin? I would call that complying with FHS. Solutions: Correct permissions: chown -r debian-sks:root /var/log/sks/* According to postinst the original permission for /var/log/sks should be debian-sks:adm 2750. Does this represent the state of your system? Since sks is started as debian-sks the owner for new files inside that directory should be debian-sks. Also since the directory is setgid adm, the group of contained files should be adm as well. Has this been the case prior to invoking your solution? If yes, why do you believe that the group should be root instead of adm? Add correct path for debial-sks account: cat END /etc/profile.d/sks if [ `id -un` == debian-sks ]; then PATH=/usr/sbin:$PATH fi export PATH END From your solution I can guess that the some script tries to invoke sks as user debian-sks without specifying its full path. However I was unable to find a matching invocation. For instance build_sks.sh is patched to use absolute paths. Helmut -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#637209: sks install is broken in 2 ways
On Mon, 12 Dec 2011 11:51:36 +0100, Helmut Grohne hel...@subdivi.de wrote: Incorrect ownership of /var/log/sks/db.log Please always state precisely what is wrong. Otherwise a maintainer can only guess what might be wrong. (See below for my guess.) Freshly installed system, no log output generated, or server fails to start. sks executable located in /usr/sbin/sks So where is the flaw with putting a daemon in /usr/sbin? I would call that complying with FHS. Not on the path, the init script fails. Silently. Nothing starts up. My understanding is that /usr/sbin is only added to root's path. Regular, non-root programs will not have it added to their path. Solutions: Correct permissions: chown -r debian-sks:root /var/log/sks/* ls -la /var/log/sks/db.log -rw--- 1 debian-sks root 516 Dec 12 12:05 /var/log/sks/db.log From your solution I can guess that the some script tries to invoke sks as user debian-sks without specifying its full path. However I was unable to find a matching invocation. For instance build_sks.sh is patched to use absolute paths. This bug was submitted several months ago. I lost a bunch of docs, about a month later. All I now know - is that sks or one of it's helpers (on a fresh install) fails without that path, that the failure was silent, and that it took me 2 days to figure out the problem, which was why I submitted (my naive) fixes. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#637209: sks install is broken in 2 ways
clone 637209 -1 retitle -1 /etc/init.d/sks redirects error messages from sks to /dev/null severity -1 wishlist submitter -1 ! tags -1 - moreinfo summary -1 0 thanks Thanks for your quick reply. On Mon, Dec 12, 2011 at 12:47:12PM +, Bryan Hunt wrote: On Mon, 12 Dec 2011 11:51:36 +0100, Helmut Grohne hel...@subdivi.de wrote: Incorrect ownership of /var/log/sks/db.log Please always state precisely what is wrong. Otherwise a maintainer can only guess what might be wrong. (See below for my guess.) Freshly installed system, no log output generated, or server fails to start. The daemon does not start by default: | Starting sks daemons: Not starting sks (as configured in /etc/default/sks) However if you enable it in /etc/default/sks and have it badly configured, it will write its error messages to /dev/null. This is because it is started using start-stop-daemon --background. Not on the path, the init script fails. Silently. Nothing starts up. My understanding is that /usr/sbin is only added to root's path. Regular, non-root programs will not have it added to their path. The init script starts $DAEMON which is an absolute path. So $PATH is not even used here. Solutions: Correct permissions: chown -r debian-sks:root /var/log/sks/* ls -la /var/log/sks/db.log -rw--- 1 debian-sks root 516 Dec 12 12:05 /var/log/sks/db.log This likely is due to your chown command. The original permission on a freshly installed sks are 600 debian-sks adm. This bug was submitted several months ago. I lost a bunch of docs, about a month later. All I now know - is that sks or one of it's helpers (on a fresh install) fails without that path, that the failure was silent, and that it took me 2 days to figure out the problem, which was why I submitted (my naive) fixes. Unfortunately you have only presented workarounds for yet unknown problems so far. The only real problem I could discover from your mails is that the init script hides the error messages and exit code returned from sks. I have cloned this issued (see above). Maybe you can try to reproduce the issues you ran into and document all the steps? Otherwise I see little value in adding your solutions to the package. To me the chown seems just wrong and I fail to see which aspect th $PATH change improves. Helmut -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#637209: sks install is broken in 2 ways
Processing commands for cont...@bugs.debian.org: clone 637209 -1 Bug#637209: sks install is broken in 2 ways Bug 637209 cloned as bug 651843. retitle -1 /etc/init.d/sks redirects error messages from sks to /dev/null Bug #651843 [sks] sks install is broken in 2 ways Changed Bug title to '/etc/init.d/sks redirects error messages from sks to /dev/null' from 'sks install is broken in 2 ways' severity -1 wishlist Bug #651843 [sks] /etc/init.d/sks redirects error messages from sks to /dev/null Severity set to 'wishlist' from 'grave' submitter -1 ! Bug #651843 [sks] /etc/init.d/sks redirects error messages from sks to /dev/null Changed Bug submitter to 'Helmut Grohne hel...@subdivi.de' from 'sentimental.br...@gmail.com' tags -1 - moreinfo Bug #651843 [sks] /etc/init.d/sks redirects error messages from sks to /dev/null Removed tag(s) moreinfo. summary -1 0 Bug #651843 [sks] /etc/init.d/sks redirects error messages from sks to /dev/null Summary recorded from message bug 651843 message 44 thanks Stopping processing here. Please contact me if you need assistance. -- 651843: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651843 637209: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=637209 -1: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=-1 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#637209: sks install is broken in 2 ways
Subject: sks install is broken in 2 ways Package: sks Version: 1.1.1+dpkgv3-6 Severity: grave -- System Information: Debian Release: 6.0.2 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages sks depends on: ii adduser 3.112+nmu2 add and remove users and groups ii db4.7-util 4.7.25-9 Berkeley v4.7 Database Utilities ii libc6 2.11.2-10Embedded GNU C Library: Shared lib ii libdb4.74.7.25-9 Berkeley v4.7 Database Libraries [ ii logrotate 3.7.8-6 Log rotation utility ii zlib1g 1:1.2.3.4.dfsg-3 compression library - runtime sks recommends no packages. Versions of packages sks suggests: ii postfix [mail-transport 2.7.1-1+squeeze1 High-performance mail transport ag ii procmail3.22-19 Versatile e-mail processor -- Configuration Files: /etc/default/sks changed [not included] /etc/sks/membership changed [not included] /etc/sks/sksconf changed [not included] -- no debconf information Flaws with installation: Incorrect ownership of /var/log/sks/db.log sks executable located in /usr/sbin/sks Solutions: Correct permissions: chown -r debian-sks:root /var/log/sks/* Add correct path for debial-sks account: cat END /etc/profile.d/sks if [ `id -un` == debian-sks ]; then PATH=/usr/sbin:$PATH fi export PATH END -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
