Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
OK. I went through all the patches, and pushed a tree to git. Nicholas: I took most of your stuff, except I don't want to rename the package again. I'll move the repo to the emacs team this week, and we can do an upload. Nicholas: do you want to be an Uploader? And are you an emacs team member? You can then get rights to write to the repo. And if you want to, you can prepare the final package that I'll then upload for you.
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Hi Dima, On Sat, Nov 23, 2019 at 02:08:30AM -0800, Dima Kogan wrote: > Nicholas D Steeves writes: > > > Is that an official NACK for Augustin's patch for the autoloads? I > > included it in the patch series I just sent... > > Hi. I tried out Augustin's update to the autoloads, and it works for me > (thanks, Augustin!) Nicholas: you wanted to review and to improve > things. Are your patches somewhere we can see them? I've confirmed this bug has my patch series (with Augustin's work integrated). Maybe those emails are in your spam folder? You should be able to use bts to grab the mbox for importation vs git am. Cheers, Nicholas signature.asc Description: PGP signature
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Nicholas D Steeves writes: > Is that an official NACK for Augustin's patch for the autoloads? I > included it in the patch series I just sent... Hi. I tried out Augustin's update to the autoloads, and it works for me (thanks, Augustin!) Nicholas: you wanted to review and to improve things. Are your patches somewhere we can see them?
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Hi David, David Bremner writes: > Agustin Martin writes: > >> >> I have been thinking about this and I see a problem with the elpa way of >> handling prefix auto-mode-alist associations. They go to a file that is not >> a conffile. So, if that kind of conflicts appear it is not as easy to >> handle as just editing one of the conffiles and commenting the undesired >> association. >> > > I guess it should still be possible to override these settings, > definitely for an individual user, or probably also system-wide. But > Debian should really not ship packages with conflicts, whatever > mechanism of setting variables is used. > Is that an official NACK for Augustin's patch for the autoloads? I included it in the patch series I just sent... Cheers, Nicholas signature.asc Description: PGP signature
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Agustin Martin writes: > > I have been thinking about this and I see a problem with the elpa way of > handling prefix auto-mode-alist associations. They go to a file that is not > a conffile. So, if that kind of conflicts appear it is not as easy to > handle as just editing one of the conffiles and commenting the undesired > association. > I guess it should still be possible to override these settings, definitely for an individual user, or probably also system-wide. But Debian should really not ship packages with conflicts, whatever mechanism of setting variables is used. d
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
On Mon, Nov 18, 2019 at 07:28:45AM -0400, David Bremner wrote: > Dima Kogan writes: > > > Thanks for the patches, Agustin. I just tried it out. Works for the most > > part. One thing that doesn't work for me is (gnuplot-mode) being > > executed when opening a .gp file. You added this to the package, and the > > dh-elpa machinery is creating the appropriate file: > > > > /etc/emacs/site-start.d/50elpa-gnuplot-mode.el > > > > I don't think this is being evaluated, however. Is it working for you? > > That's not loaded by elpa packages. > > The general approach is to add an autoload cookie to set > auto-mode-alist. See "HINTS" in dh_elpa(1). Of course the usual cautions > about auto-mode-alist apply, in particular there's no nice way to resolve > conflicts with other packages (e.g. pari-gp) that might want to use the > same suffix. Hi, I have been thinking about this and I see a problem with the elpa way of handling prefix auto-mode-alist associations. They go to a file that is not a conffile. So, if that kind of conflicts appear it is not as easy to handle as just editing one of the conffiles and commenting the undesired association. Regards, -- Agustin
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
On Mon, Nov 18, 2019 at 08:30:46AM -0400, David Bremner wrote:
> Agustin Martin writes:
>
> > Hi, David,
> >
> >> That's not loaded by elpa packages.
> >
> > But AFAIK it should be loaded by Emacs,
>
> Perhaps. Team packages don't use these startup files anymore. Most of
> the content (updating load paths in particular) is handled more reliably
> by package.el generated autoload files.
>
> >> The general approach is to add an autoload cookie to set
> >> auto-mode-alist. See "HINTS" in dh_elpa(1).
> >
> > I was looking at it and noticed the autoloads part, but nothing about
> > `auto-mode-alist'. Where is it?
> >
>
> See "Other customizations"
Thanks for insisting, it was not clear to me after a quick read.
I am attaching a patch to replace
[0003-elpa-gnuplot-mode.emacsen-startup-Add-auto-mode-alis.patch]
doing things the elpa way.
--
Agustin
>From 74c09c964923c9119546aba0cd59cd56b40acb76 Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo
Date: Mon, 18 Nov 2019 16:07:16 +0100
Subject: [PATCH] debian/debian-autoloads.el: Handle auto-mode-alist stuff the
elpa way.
---
debian/debian-autoloads.el| 2 ++
debian/elpa-gnuplot-mode.elpa | 1 +
2 files changed, 3 insertions(+)
create mode 100644 debian/debian-autoloads.el
diff --git a/debian/debian-autoloads.el b/debian/debian-autoloads.el
new file mode 100644
index 000..e2c1d6d
--- /dev/null
+++ b/debian/debian-autoloads.el
@@ -0,0 +1,2 @@
+;;;###autoload
+(setq auto-mode-alist (append '(("\\.gp\\'" . gnuplot-mode)) auto-mode-alist))
diff --git a/debian/elpa-gnuplot-mode.elpa b/debian/elpa-gnuplot-mode.elpa
index cd726c7..3e61da9 100644
--- a/debian/elpa-gnuplot-mode.elpa
+++ b/debian/elpa-gnuplot-mode.elpa
@@ -2,3 +2,4 @@ gnuplot.el
gnuplot-gui.el
gnuplot-context.el
debian/gnuplot-mode-pkg.el
+debian/debian-autoloads.el
--
2.24.0
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Agustin Martin writes: > > Hi, David, > >> That's not loaded by elpa packages. > > But AFAIK it should be loaded by Emacs, Perhaps. Team packages don't use these startup files anymore. Most of the content (updating load paths in particular) is handled more reliably by package.el generated autoload files. > >> The general approach is to add an autoload cookie to set >> auto-mode-alist. See "HINTS" in dh_elpa(1). > > I was looking at it and noticed the autoloads part, but nothing about > `auto-mode-alist'. Where is it? > See "Other customizations"
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
On Mon, Nov 18, 2019 at 07:28:45AM -0400, David Bremner wrote: > Dima Kogan writes: > > > Thanks for the patches, Agustin. I just tried it out. Works for the most > > part. One thing that doesn't work for me is (gnuplot-mode) being > > executed when opening a .gp file. You added this to the package, and the > > dh-elpa machinery is creating the appropriate file: > > > > /etc/emacs/site-start.d/50elpa-gnuplot-mode.el > > > > I don't think this is being evaluated, however. Is it working for you? > Hi, David, > That's not loaded by elpa packages. But AFAIK it should be loaded by Emacs, > The general approach is to add an autoload cookie to set > auto-mode-alist. See "HINTS" in dh_elpa(1). I was looking at it and noticed the autoloads part, but nothing about `auto-mode-alist'. Where is it? > Of course the usual cautions > about auto-mode-alist apply, in particular there's no nice way to resolve > conflicts with other packages (e.g. pari-gp) that might want to use the > same suffix. By the way, previous emacsen-startup file also used the .gnuplot extension. Regards, -- Agustin
Bug#944249: gnuplot-mode does not work with emacs26
On Sun, Nov 17, 2019 at 10:52:47PM -0800, Dima Kogan wrote: > Thanks for the patches, Agustin. I just tried it out. Works for the most > part. One thing that doesn't work for me is (gnuplot-mode) being > executed when opening a .gp file. You added this to the package, and the > dh-elpa machinery is creating the appropriate file: > > /etc/emacs/site-start.d/50elpa-gnuplot-mode.el > > I don't think this is being evaluated, however. Is it working for you? Hello, thanks for looking at this. It is working for me. I reviewed again my ~/.emacs file and did not see anything active that may mess up with this. > Do you know at which point in the emacs startup sequence this is > sourced? In my box, Emacs messages buffer shows ... Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done Loading /etc/emacs/site-start.d/50elpa-gnuplot-mode.el (source)...done Loading /etc/emacs/site-start.d/50flim.el (source)...done ... > Is it always supposed to be sourced? What about 'emacs -q'? Or > 'emacs -Q'? That snippet will not always be sourced, It will not be sourced with "emacs -Q" or "emacs --no-site-file" It will be sourced with "emacs --q", but I get an error here ... Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done Loading /etc/emacs/site-start.d/50elpa-gnuplot-mode.el (source)...done Loading /etc/emacs/site-start.d/50flim.el (source)...done ... File mode specification error: (void-function gnuplot-mode) ... Another thing. It is probably too late for this, but I tried gnuplot-mode for XEmacs (unsupported by elpa). Just needed to add a couple of lines with a compatibility function (eval-and-compile ;; Protect against declare-function undefined in XEmacs (unless (fboundp 'declare-function) (defmacro declare-function ( r and load .el files manually to have it working. No apparent problems in my quick test (plotting sin(x)). I wonder if gnuplot-mode should have preserved XEmacs compatibility and thus not migrate to elpa. Anyhow, seems that nobody complained and even I had to install XEmacs just for this check, so this seems no longer an issue. Regards, -- Agustin
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Dima Kogan writes: > Thanks for the patches, Agustin. I just tried it out. Works for the most > part. One thing that doesn't work for me is (gnuplot-mode) being > executed when opening a .gp file. You added this to the package, and the > dh-elpa machinery is creating the appropriate file: > > /etc/emacs/site-start.d/50elpa-gnuplot-mode.el > > I don't think this is being evaluated, however. Is it working for you? That's not loaded by elpa packages. The general approach is to add an autoload cookie to set auto-mode-alist. See "HINTS" in dh_elpa(1). Of course the usual cautions about auto-mode-alist apply, in particular there's no nice way to resolve conflicts with other packages (e.g. pari-gp) that might want to use the same suffix.
Bug#944249: gnuplot-mode does not work with emacs26
Thanks for the patches, Agustin. I just tried it out. Works for the most part. One thing that doesn't work for me is (gnuplot-mode) being executed when opening a .gp file. You added this to the package, and the dh-elpa machinery is creating the appropriate file: /etc/emacs/site-start.d/50elpa-gnuplot-mode.el I don't think this is being evaluated, however. Is it working for you? Do you know at which point in the emacs startup sequence this is sourced? Is it always supposed to be sourced? What about 'emacs -q'? Or 'emacs -Q'? Thanks
Bug#944249: gnuplot-mode does not work with emacs26
El jue., 7 nov. 2019 a las 2:57, Nicholas D Steeves () escribió: > > Hi Olaf and Dima, > > Dima, if it's alright with you can I please take care of this bug? > I've head I need an RC Bug NMU process for the "demonstrates skills > and knowledge of process" section of my eventual DD application. Sorry, I missed above part of your mesage. Just read the part below > If Dima give the go-ahead I'll investigate if this would be approved > for a stable update. It seems like it would be, because RC bugs like > this aren't supposed to be solved using backports. and thought you were someone helping the ftpmaster team and knowing about their procedures. Since I already sent some patches, they can be a starting point for your work. Feel free to modify them at your convenience. Regards, -- Agustin
Bug#944249: gnuplot-mode does not work with emacs26
On Wed, Nov 06, 2019 at 09:44:59PM -0800, Dima Kogan wrote: > Hi. > > It looks like the elpa-gnuplot-mode package is missing some of the > debiany emacs machinery: the files in > > /usr/lib/emacsen-common/packages/... > > Somebody should look at the packaging, and figure out what we're missing > and add it. Likely it's just a line or two somewhere. Hi, Having played with gnuplot-mode before (but not with elpa) I have been digging into this problem, which is not Emacs26 related. Original problem seems to be a bogus hyphen in debian/rules that completely disables the elpa machinery, so problem went undetected. It really took me a while to spot this problem. I also added a debian/gnuplot-mode-pkg.el file and fine tuned elpa-gnuplot-mode.elpa to include it and be more selective regarding files to install. Once this is done I noticed that package did not pass the tests because gnuplot package was missing at that time, so I added it to Build-Deps. I finally added elpa-gnuplot-mode.emacsen-startup to keep the .gp -> gnuplot mode association in Emacs auto-mode-alist. I am attaching three git patches dealing with the above. Hope they help -- Agustin >From 1c6e992136fb5c33f28ee74e6992387a9bfa91d0 Mon Sep 17 00:00:00 2001 From: Agustin Martin Domingo Date: Fri, 8 Nov 2019 17:09:19 +0100 Subject: [PATCH 1/3] Modify to work better with elpa. * debian/rules: Remove bogus hyphen * debian/gnuplot-mode-pkg.el: Create * debian/elpa-gnuplot-mode.elpa: Rename from gnuplot-mode.elpa and modify to include install contents and gnuplot-mode-pkg.el. * debian/install: Remove. No longer needed. --- debian/elpa-gnuplot-mode.elpa | 4 debian/gnuplot-mode-pkg.el| 5 + debian/gnuplot-mode.elpa | 1 - debian/install| 3 --- debian/rules | 2 +- 5 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 debian/elpa-gnuplot-mode.elpa create mode 100644 debian/gnuplot-mode-pkg.el delete mode 100644 debian/gnuplot-mode.elpa delete mode 100644 debian/install diff --git a/debian/elpa-gnuplot-mode.elpa b/debian/elpa-gnuplot-mode.elpa new file mode 100644 index 000..cd726c7 --- /dev/null +++ b/debian/elpa-gnuplot-mode.elpa @@ -0,0 +1,4 @@ +gnuplot.el +gnuplot-gui.el +gnuplot-context.el +debian/gnuplot-mode-pkg.el diff --git a/debian/gnuplot-mode-pkg.el b/debian/gnuplot-mode-pkg.el new file mode 100644 index 000..8b98b6e --- /dev/null +++ b/debian/gnuplot-mode-pkg.el @@ -0,0 +1,5 @@ +(define-package + "gnuplot-mode" + "50" + "Emacs gnuplot mode" + nil) diff --git a/debian/gnuplot-mode.elpa b/debian/gnuplot-mode.elpa deleted file mode 100644 index abf136d..000 --- a/debian/gnuplot-mode.elpa +++ /dev/null @@ -1 +0,0 @@ -*.el diff --git a/debian/install b/debian/install deleted file mode 100644 index 4463e0a..000 --- a/debian/install +++ /dev/null @@ -1,3 +0,0 @@ -gnuplot.el usr/share/emacs/site-lisp/gnuplot-mode -gnuplot-gui.el usr/share/emacs/site-lisp/gnuplot-mode -gnuplot-context.el usr/share/emacs/site-lisp/gnuplot-mode diff --git a/debian/rules b/debian/rules index ffea5e3..bb43d84 100755 --- a/debian/rules +++ b/debian/rules @@ -1,6 +1,6 @@ #!/usr/bin/make -f %: - dh $@ --with-elpa + dh $@ --with elpa override_dh_auto_build: $(if $(filter nodoc,$(DEB_BUILD_OPTIONS)),true,make -f Makefile.dst gpelcard.pdf) -- 2.24.0.rc1 >From a019516e49055cc424a624bf076874e2e3ee9e48 Mon Sep 17 00:00:00 2001 From: Agustin Martin Domingo Date: Fri, 8 Nov 2019 17:26:14 +0100 Subject: [PATCH 2/3] debian/control: Build depend on gnuplot, to allow tests being actually passed. --- debian/control | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 8d96b1f..29411f8 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,11 @@ Section: lisp Priority: optional Maintainer: Debian Emacs addons team Uploaders: Dima Kogan -Build-Depends: debhelper (>= 10), dh-elpa (>= 0.0.17), texlive-latex-base, texlive-latex-recommended +Build-Depends: debhelper (>= 10), + dh-elpa (>= 0.0.17), + texlive-latex-base, + texlive-latex-recommended, + gnuplot Standards-Version: 4.3.0 Vcs-Git: https://salsa.debian.org/debian/gnuplot-mode.git Vcs-Browser: https://salsa.debian.org/debian/gnuplot-mode -- 2.24.0.rc1 >From 0b7604f0e336f69f9b9bcb08a2e66dbf408b5dc3 Mon Sep 17 00:00:00 2001 From: Agustin Martin Domingo Date: Fri, 8 Nov 2019 17:41:06 +0100 Subject: [PATCH 3/3] elpa-gnuplot-mode.emacsen-startup: Add auto-mode-alist entry for .gp->gnuplot-mode association. Based on old one, but with path and autoload handling removed. --- debian/elpa-gnuplot-mode.emacsen-startup | 12 1 file changed, 12 insertions(+) create mode 100644 debian/elpa-gnuplot-mode.emacsen-startup diff --git a/debian/elpa-gnuplot-mode.emacsen-startup b/debian/elpa-gnuplot-mode.emacsen-startup new file mode 100644 index 000..2b83d62 --- /dev/null +++
Bug#944249: [Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26
Hello, On Wed 06 Nov 2019 at 08:53PM -05, Nicholas D Steeves wrote: > Hi Olaf and Dima, > > Dima, if it's alright with you can I please take care of this bug? > I've head I need an RC Bug NMU process for the "demonstrates skills > and knowledge of process" section of my eventual DD application. > > I'm treating this as an NMU because while > https://salsa.debian.org/debian/gnuplot-mode/blob/master/debian/control#L4 > > states that this is a Team Emacsen package > https://salsa.debian.org/debian/gnuplot-mode/blob/master/debian/control#L8 > > it's in Debian/collab-maint and not Team Emacsen team namespace. This is a team upload, not an NMU, because the Maintainer field is set to the team. Where the repo is to be found in salsa is irrelevant to whether or not it's an NMU. -- Sean Whitton signature.asc Description: PGP signature
Bug#944249: gnuplot-mode does not work with emacs26
Hi. It looks like the elpa-gnuplot-mode package is missing some of the debiany emacs machinery: the files in /usr/lib/emacsen-common/packages/... Somebody should look at the packaging, and figure out what we're missing and add it. Likely it's just a line or two somewhere. Nicholas: I'd be delighted if you fix this. Thanks for stepping up! I don't think you need to do any NMUs to become a DD. Those happen when a package needs to be fixed, but its maintainer is not available for whatever reason (NMU = non-maintainer upload). And until you're a DD you can't upload anything yourself anyway. You should work on the issue, and when you're done, let me know. I'll take a look, and then I can do the upload for you. The location of this package is a historical artifact. It was originally team-maintained in collab-maint. Then when it was converted (as it turns out unsuccessfully) to a debian elpa-... package, it was moved to the emacs team (by changing the Maintainer field). But we didn't move the repo. I'd rather leave it where it is: there's little downside to leaving it, and if we do move it, there're a lot of little things that could be messed up, and then we'd have to fix them. It's not worth the effort, I think. Feel free to add yourself to the Uploaders, if you want to. dima
Bug#944249: gnuplot-mode does not work with emacs26
Hi Olaf and Dima, Dima, if it's alright with you can I please take care of this bug? I've head I need an RC Bug NMU process for the "demonstrates skills and knowledge of process" section of my eventual DD application. I'm treating this as an NMU because while https://salsa.debian.org/debian/gnuplot-mode/blob/master/debian/control#L4 states that this is a Team Emacsen package https://salsa.debian.org/debian/gnuplot-mode/blob/master/debian/control#L8 it's in Debian/collab-maint and not Team Emacsen team namespace. If you'd like I can move the repository to our namespace, but please let me know if this is the case! On Wed, Nov 06, 2019 at 05:45:58PM +0100, Olaf Skibbe wrote: > Package: gnuplot-mode > Version: 1:0.7.0-2014-12-31-1 > Severity: grave > Justification: renders package unusable > > Dear Maintainer, > > I hope that this is the right place for this report. > Yes :-) >* What exactly did you do (or not do) that was effective (or > ineffective)? > > Opening a gnuplot file in emacs. > >* What was the outcome of this action? > > No gnuplot-mode available. > >* What outcome did you expect instead? > > gnuplot-mode available in emacs. > > Details: > > On debian buster, one finds: > > Package: elpa-gnuplot-mode > Version: 1:0.7.0-2014-12-31-1 > [...] > Enhances: emacs, emacs24, emacs25 > > On the other hand: > > Package: emacs > Version: 1:26.1+1-3.2+deb10u1 > > Hence, gnuplot-mode is not available in emacs. > > I would appreciate gnuplot-mode available (backports would be fine). > If Dima give the go-ahead I'll investigate if this would be approved for a stable update. It seems like it would be, because RC bugs like this aren't supposed to be solved using backports. Regards, Nicholas signature.asc Description: PGP signature
Bug#944249: gnuplot-mode does not work with emacs26
Package: gnuplot-mode Version: 1:0.7.0-2014-12-31-1 Severity: grave Justification: renders package unusable Dear Maintainer, I hope that this is the right place for this report. * What led up to the situation? Installing Debian stable/buster. * What exactly did you do (or not do) that was effective (or ineffective)? Opening a gnuplot file in emacs. * What was the outcome of this action? No gnuplot-mode available. * What outcome did you expect instead? gnuplot-mode available in emacs. Details: On debian buster, one finds: Package: elpa-gnuplot-mode Version: 1:0.7.0-2014-12-31-1 [...] Enhances: emacs, emacs24, emacs25 On the other hand: Package: emacs Version: 1:26.1+1-3.2+deb10u1 Hence, gnuplot-mode is not available in emacs. I would appreciate gnuplot-mode available (backports would be fine). Kind regards, Olaf -- System Information: Debian Release: 10.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable'), (500, 'oldstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages gnuplot-mode depends on: ii elpa-gnuplot-mode 1:0.7.0-2014-12-31-1 gnuplot-mode recommends no packages. gnuplot-mode suggests no packages. -- no debconf information
