Your message dated Thu, 16 Nov 2023 11:49:18 +0000
with message-id <e1r3as2-007lm0...@fasolo.debian.org>
and subject line Bug#1054188: fixed in debci 3.8
has caused the Debian Bug report #1054188,
regarding debci: installs systemd unit twice once dh_installsystemd installs to 
/usr
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1054188: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054188
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: debci
Version: 3.6
Tags: patch
User: helm...@debian.org
Usertags: dep17m2

We want to change dh_installsystemd to install units to /usr to finalize
the /usr-merge transition via DEP17. When doing so, at least one unit is
installed to both /usr/lib/systemd/system (via dh_installsystemd) and
/lib/systemd/system (via dh_install). Doing so is a policy violation.
I'm attaching a patch for your convenience. Once I upload debhelper,
this bug will become release critical.

Helmut
diff -Nru debci-3.6/debian/changelog debci-3.6+nmu1/debian/changelog
--- debci-3.6/debian/changelog  2023-02-26 16:08:48.000000000 +0100
+++ debci-3.6+nmu1/debian/changelog     2023-10-18 14:23:50.000000000 +0200
@@ -1,3 +1,10 @@
+debci (3.6+nmu1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install units with dh_installsystemd only. (Closes: #-1)
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 18 Oct 2023 14:23:50 +0200
+
 debci (3.6) unstable; urgency=medium
 
   [ Louis-Philippe VĂ©ronneau ]
diff -Nru debci-3.6/debian/debci-collector.debci-update.service 
debci-3.6+nmu1/debian/debci-collector.debci-update.service
--- debci-3.6/debian/debci-collector.debci-update.service       1970-01-01 
01:00:00.000000000 +0100
+++ debci-3.6+nmu1/debian/debci-collector.debci-update.service  2023-02-26 
16:08:48.000000000 +0100
@@ -0,0 +1,10 @@
+[Unit]
+Description=debci index generator
+Documentation=https://ci.debian.net/doc/
+
+[Service]
+Type=oneshot
+User=debci
+Group=debci
+ExecStart=/bin/sleep 1s
+ExecStart=/usr/bin/debci update
diff -Nru debci-3.6/debian/debci-collector.debci-update.timer 
debci-3.6+nmu1/debian/debci-collector.debci-update.timer
--- debci-3.6/debian/debci-collector.debci-update.timer 1970-01-01 
01:00:00.000000000 +0100
+++ debci-3.6+nmu1/debian/debci-collector.debci-update.timer    2023-02-26 
16:08:48.000000000 +0100
@@ -0,0 +1,8 @@
+[Unit]
+Description=debci update timer
+
+[Timer]
+OnCalendar=*:0/5
+
+[Install]
+WantedBy=timers.target
diff -Nru debci-3.6/debian/debci-collector.install 
debci-3.6+nmu1/debian/debci-collector.install
--- debci-3.6/debian/debci-collector.install    2023-02-26 16:08:48.000000000 
+0100
+++ debci-3.6+nmu1/debian/debci-collector.install       2023-10-18 
14:22:54.000000000 +0200
@@ -1,6 +1,3 @@
-debian/debci-update.service  lib/systemd/system/
-debian/debci-update.timer    lib/systemd/system/
-
 bin/debci-expire                usr/share/debci/bin
 bin/debci-update                usr/share/debci/bin
 bin/debci-status                usr/share/debci/bin
diff -Nru debci-3.6/debian/debci-update.service 
debci-3.6+nmu1/debian/debci-update.service
--- debci-3.6/debian/debci-update.service       2023-02-26 16:08:48.000000000 
+0100
+++ debci-3.6+nmu1/debian/debci-update.service  1970-01-01 01:00:00.000000000 
+0100
@@ -1,10 +0,0 @@
-[Unit]
-Description=debci index generator
-Documentation=https://ci.debian.net/doc/
-
-[Service]
-Type=oneshot
-User=debci
-Group=debci
-ExecStart=/bin/sleep 1s
-ExecStart=/usr/bin/debci update
diff -Nru debci-3.6/debian/debci-update.timer 
debci-3.6+nmu1/debian/debci-update.timer
--- debci-3.6/debian/debci-update.timer 2023-02-26 16:08:48.000000000 +0100
+++ debci-3.6+nmu1/debian/debci-update.timer    1970-01-01 01:00:00.000000000 
+0100
@@ -1,8 +0,0 @@
-[Unit]
-Description=debci update timer
-
-[Timer]
-OnCalendar=*:0/5
-
-[Install]
-WantedBy=timers.target
diff -Nru debci-3.6/debian/debci-worker.install 
debci-3.6+nmu1/debian/debci-worker.install
--- debci-3.6/debian/debci-worker.install       2023-02-26 16:08:48.000000000 
+0100
+++ debci-3.6+nmu1/debian/debci-worker.install  1970-01-01 01:00:00.000000000 
+0100
@@ -1 +0,0 @@
-debian/debci-worker@.service lib/systemd/system/
diff -Nru debci-3.6/debian/rules debci-3.6+nmu1/debian/rules
--- debci-3.6/debian/rules      2023-02-26 16:08:48.000000000 +0100
+++ debci-3.6+nmu1/debian/rules 2023-10-18 14:23:24.000000000 +0200
@@ -19,6 +19,9 @@
 override_dh_installinit:
        @true
 
+execute_after_dh_installsystemd:
+       dh_installsystemd -pdebci-collector --name=debci-update
+
 override_dh_install:
        dh_install
        debian/sanity-check

--- End Message ---
--- Begin Message ---
Source: debci
Source-Version: 3.8
Done: Antonio Terceiro <terce...@debian.org>

We believe that the bug you reported is fixed in the latest version of
debci, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1054...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terce...@debian.org> (supplier of updated debci package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 16 Nov 2023 08:19:07 -0300
Source: debci
Architecture: source
Version: 3.8
Distribution: unstable
Urgency: medium
Maintainer: Debian CI team <team...@tracker.debian.org>
Changed-By: Antonio Terceiro <terce...@debian.org>
Closes: 1054188
Changes:
 debci (3.8) unstable; urgency=medium
 .
   [ Christian Kastner ]
   * debci-localtest can also take autopkgtest backends
   * Add debci_autopkgtest_args_<backend> to environment.sh
 .
   [ Antonio Terceiro ]
   * Debci::StorageLimit: only count non-deleted jobs
   * Debci::StorageLimit: traverse only non-deleted jobs
   * Debci::Job: ensure files_purged is false
   * debci-collector.postinst: drop support for upgrades from buster
   * spec: ensure a reasonable value for Debci.config.html_dir.
     This fixes running the Ruby test suite under autopkgtest using a
     different user than `debci`.
   * munin: debci_packages_processed: look into debci-publisher logs
   * web ui: add structured log viewer.
     An initial version in client side JavaScript was written by Stuart
     Prescott. It was then used as base for the the server side Ruby version
     by Antonio Terceiro. In special, all the regular expressions were copied
     as-is from Stuart's original code.
     If Javascript is enabled, then there is some extra functionality, like
     collapsing non-critical sessions and leaving only the actual test runs
     visible by default.
 .
   [ Helmut Grohne ]
   * Install units with dh_installsystemd only (Closes: #1054188)
Checksums-Sha1:
 20217a6f599bb90394742a0494aead34319bdf06 2901 debci_3.8.dsc
 2d9478f88e0375f33852f663216b28ae89d50a89 156272 debci_3.8.tar.xz
 44a32a963750b9eec846057809b4601a85d2a2fe 11905 debci_3.8_source.buildinfo
Checksums-Sha256:
 9369e3ebe912297f3e04bb98f916dbe1f332edd1bfc4c27e3f75fe61f9d60d9a 2901 
debci_3.8.dsc
 dafba395d84cc961fcd66daf9fed6b01380896b2253b07faa69fa3738c8c321b 156272 
debci_3.8.tar.xz
 792d46b914662cd568a6e3b3e36d5ca347c0177769e2ed769ffa5c0a175b00a0 11905 
debci_3.8_source.buildinfo
Files:
 3714254a1dd354a76be1994d865c40a0 2901 devel optional debci_3.8.dsc
 b0a28cd366930cdf64428e12adae6e35 156272 devel optional debci_3.8.tar.xz
 3190d8d995e27201663b74853e88d2ac 11905 devel optional 
debci_3.8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAmVV/rMACgkQ/A2xu81G
C95iXhAAmQdfkWdunpIF0nITt0WJw2xC9yP/DogF98sRfymcTJCmCiQ/zYKYEKDY
vEr5IOs4QearVRV0g8a/EzbBU9e7zIpmCYe4GEqCJT7Fg87Vx8u1GdEp37G4m8dC
e3XtPDD3oD9ub3TQO57Tb656wQmjUfe3mA9K9xCuTEeYnzjOPxNAwTlOGtCyV55r
sJ7IM+W/lac9vonIKBgR4CzK6D+AkL3AxmCjFrioWGCaawugUNV0rea1XXZ0qKAD
RHB9dzFOW8bHZ9GmnSVFsbd2VLvGwi/CGcQOq9oAsmuUw+W8Jmqqm3EdAVLqDUQW
XV3Hayk++c5iUbX/giULwqa4GfwDwkPnaOtZqbQneC5fEmNXZ57726oLc3LYx7+R
TzgoQKM4X7c2jMjCF3zGKzzDKELM9V2PK/HugHya5qM2TaKh3DnsfavAmXj4jyyJ
N8qasaVuowA7Pjj9SA0CrC0qkkJJ4rh7rWIFTW7SyINCu/Vt9T2ttQD6ytC/zm2u
/ysTqrxinn+JVreNgVgvr/lUZ6BJsqojz+Wi5zLDjIhBqK4IWKNXsCukH3quilK4
9cyhfp1SKiHSMnz5QqAoHq/V31Sdfs9tOZVySalBhAeTkj27TKn9SvIJBfbO1IdT
za5eQfFmLkF6wwQPjw09tzr49GMBzs96hkc3Xt7c6C1QJxdY8y4=
=xdiO
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to