Bug#1062194: guacamole-server: NMU diff for 64-bit time_t transition

2024-02-28 Thread Steve Langasek
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru guacamole-server-1.3.0/debian/changelog 
guacamole-server-1.3.0/debian/changelog
--- guacamole-server-1.3.0/debian/changelog 2022-02-07 18:02:10.0 
+
+++ guacamole-server-1.3.0/debian/changelog 2024-02-29 06:18:24.0 
+
@@ -1,3 +1,10 @@
+guacamole-server (1.3.0-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062194
+
+ -- Steve Langasek   Thu, 29 Feb 2024 06:18:24 +
+
 guacamole-server (1.3.0-1.1) unstable; urgency=medium
 
   * Non-maintainer upload
diff -Nru guacamole-server-1.3.0/debian/control 
guacamole-server-1.3.0/debian/control
--- guacamole-server-1.3.0/debian/control   2022-02-07 18:02:10.0 
+
+++ guacamole-server-1.3.0/debian/control   2024-02-29 06:18:23.0 
+
@@ -3,7 +3,7 @@
 Maintainer: Debian Remote Maintainers 
 Uploaders:
  Dominik George ,
-Build-Depends:
+Build-Depends: dpkg-dev (>= 1.22.5),
  debhelper (>= 11),
  freerdp2-dev,
  libcairo-dev,
@@ -30,7 +30,7 @@
 Architecture: any
 Multi-Arch: same
 Depends:
- libguac19 (= ${binary:Version}),
+ libguac19t64 (= ${binary:Version}),
  ${misc:Depends},
 Replaces:
  libguac1-dev,
@@ -50,11 +50,11 @@
  ${misc:Depends},
  ${shlibs:Depends},
 Recommends:
- libguac-client-rdp0,
- libguac-client-ssh0,
- libguac-client-vnc0,
+ libguac-client-rdp0t64,
+ libguac-client-ssh0t64,
+ libguac-client-vnc0t64,
 Suggests:
- libguac-client-telnet0,
+ libguac-client-telnet0t64,
 Description: HTML5 web application for accessing remote desktops (proxy daemon)
  Guacamole is an HTML5 web application that provides access to a desktop
  environment using remote desktop protocols. A centralized server acts as a
@@ -70,7 +70,10 @@
  .
  This package contains the daemon binary.
 
-Package: libguac-client-rdp0
+Package: libguac-client-rdp0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-rdp0
+Breaks: libguac-client-rdp0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -97,7 +100,10 @@
  .
  This package contains protocol support for RDP backends.
 
-Package: libguac-client-ssh0
+Package: libguac-client-ssh0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-ssh0
+Breaks: libguac-client-ssh0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -123,7 +129,10 @@
  .
  This package contains protocol support for SSH backends.
 
-Package: libguac-client-vnc0
+Package: libguac-client-vnc0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-vnc0
+Breaks: libguac-client-vnc0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -149,7 +158,10 @@
  .
  This package contains protocol support for VNC backends.
 
-Package: libguac-client-telnet0
+Package: libguac-client-telnet0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-telnet0
+Breaks: libguac-client-telnet0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -173,7 +185,10 @@
  .
  This package contains protocol support for Telnet backends.
 
-Package: libguac19
+Package: libguac19t64
+Provides: ${t64:Provides}
+Replaces: libguac19
+Breaks: libguac19 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
diff -Nru guacamole-server-1.3.0/debian/libguac-client-rdp0.install 
guacamole-server-1.3.0/debian/libguac-client-rdp0.install
--- guacamole-server-1.3.0/debian/libguac-client-rdp0.install   2022-02-07 
18:02:10.0 +
+++ guacamole-server-1.3.0/debian/libguac-client-rdp0.install   1970-01-01 
00:00:00.0 +
@@ -1,3 +0,0 @@
-usr/lib/*/freerdp*/*.so
-usr/lib/*/libguac-client-rdp.so
-usr/lib/*/libguac-client-rdp.so.*
diff -Nru guacamole-server-1.3.0/debian/libguac-client-rdp0.lintian-overrides 
guacamole-server-1.3.0/debian/libguac-client-rdp0.lintian-overrides
--- guacamole-server-1.3.0/debian/libguac-client-rdp0.lintian-overrides 
2022-02-07 18:02:10.0 +
+++ guacamole-server-1.3.0/debian/libguac-client-rdp0.lintian-overrides 
1970-01-01 00:00:00.0 +
@@ -1,2 +0,0 @@
-# loaded as plugin via dlopen()
-libguac-client-rdp0 binary: non-dev-pkg-with-shlib-symlink
diff -Nru guacamole-server-1.3.0/debian/libguac-client-rdp0.symbols 
guacamole-server-1.3.0/debian/libguac-client-rdp0.symbols
--- 

Bug#1062194: guacamole-server: NMU diff for 64-bit time_t transition

2024-01-31 Thread Graham Inggs
Source: guacamole-server
Version: 1.3.0-1.1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
guacamole-server as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for guacamole-server
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru guacamole-server-1.3.0/debian/changelog 
guacamole-server-1.3.0/debian/changelog
--- guacamole-server-1.3.0/debian/changelog 2022-02-07 18:02:10.0 
+
+++ guacamole-server-1.3.0/debian/changelog 2024-01-31 16:29:12.0 
+
@@ -1,3 +1,10 @@
+guacamole-server (1.3.0-1.2) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Graham Inggs   Wed, 31 Jan 2024 16:29:12 +
+
 guacamole-server (1.3.0-1.1) unstable; urgency=medium
 
   * Non-maintainer upload
diff -Nru guacamole-server-1.3.0/debian/control 
guacamole-server-1.3.0/debian/control
--- guacamole-server-1.3.0/debian/control   2022-02-07 18:02:10.0 
+
+++ guacamole-server-1.3.0/debian/control   2024-01-31 16:29:12.0 
+
@@ -30,7 +30,7 @@
 Architecture: any
 Multi-Arch: same
 Depends:
- libguac19 (= ${binary:Version}),
+ libguac19t64 (= ${binary:Version}),
  ${misc:Depends},
 Replaces:
  libguac1-dev,
@@ -50,11 +50,11 @@
  ${misc:Depends},
  ${shlibs:Depends},
 Recommends:
- libguac-client-rdp0,
- libguac-client-ssh0,
- libguac-client-vnc0,
+ libguac-client-rdp0t64,
+ libguac-client-ssh0t64,
+ libguac-client-vnc0t64,
 Suggests:
- libguac-client-telnet0,
+ libguac-client-telnet0t64,
 Description: HTML5 web application for accessing remote desktops (proxy daemon)
  Guacamole is an HTML5 web application that provides access to a desktop
  environment using remote desktop protocols. A centralized server acts as a
@@ -70,7 +70,10 @@
  .
  This package contains the daemon binary.
 
-Package: libguac-client-rdp0
+Package: libguac-client-rdp0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-rdp0
+Breaks: libguac-client-rdp0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -97,7 +100,10 @@
  .
  This package contains protocol support for RDP backends.
 
-Package: libguac-client-ssh0
+Package: libguac-client-ssh0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-ssh0
+Breaks: libguac-client-ssh0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -123,7 +129,10 @@
  .
  This package contains protocol support for SSH backends.
 
-Package: libguac-client-vnc0
+Package: libguac-client-vnc0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-vnc0
+Breaks: libguac-client-vnc0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -149,7 +158,10 @@
  .
  This package contains protocol support for VNC backends.
 
-Package: libguac-client-telnet0
+Package: libguac-client-telnet0t64
+Provides: ${t64:Provides}
+Replaces: libguac-client-telnet0
+Breaks: libguac-client-telnet0 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -173,7 +185,10 @@
  .
  This package contains protocol support for Telnet backends.
 
-Package: libguac19
+Package: libguac19t64
+Provides: ${t64:Provides}
+Replaces: libguac19
+Breaks: