Processed: Re: Bug#1065146: sysvinit-core: /usr/sbin/halt and others ineffectively diverted (DEP17)

2024-03-01 Thread Debian Bug Tracking System
Processing control commands:

> severity -1 important
Bug #1065146 [sysvinit-core] sysvinit-core: /usr/sbin/halt and others 
ineffectively diverted (DEP17)
Severity set to 'important' from 'serious'

-- 
1065146: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065146
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#1065146: sysvinit-core: /usr/sbin/halt and others ineffectively diverted (DEP17)

2024-03-01 Thread Helmut Grohne
Control: severity -1 important

Hi Lorenzo,

On Fri, Mar 01, 2024 at 01:18:38PM +0100, Lorenzo wrote:
> I'm missing something for sure here, but sysvinit-core has a conflict
> with systemd-sysv and both bfh-container and progress-linux-container
> depends on systemd-sysv so they already should not be installed at the
> same time in a system regardless of the versioned conflicts you are
> adding.. ?

Thank you for your attention to detail. Your analysis is mostly correct.
In particular, the declared dependencies on systemd-sysv make the
failure mode very unlikely - hence downgrading the bug.

Stil Depends does not impact the unpack phase. In principle, you may
have a system with bfh-container on bookworm (thus having systemd-sysv)
and then upgrade to trixie while at the same time converting to
sysvinit-core (unlikely). When doing that, bfh-container may get into a
deconfigured state, systemd-sysv can be removed and sysvinit-core may be
unpacked before bfh-container is actually removed. In this scenario,
bfh-container.postrm would cause /usr/sbin/halt to vanish. As such, I
think we should apply Conflicts here to avoid the underlying situation.

Helmut



Bug#1065146: sysvinit-core: /usr/sbin/halt and others ineffectively diverted (DEP17)

2024-03-01 Thread Lorenzo
On Fri, 1 Mar 2024 08:05:27 +0100
Helmut Grohne  wrote:

> Package: sysvinit-core
> Version: 3.08-7
> Severity: serious
> Tags: patch
> User: helm...@debian.org
> Usertags: dep17p3
> Control: affects -1 + bfh-container progress-linux-container
> 
> Hi,

Hi Helmut,
> 
> thanks for applying my earlier /usr-move patch #1060139. Since
> authoring it, the mitigations for ineffective diversions have been
> added to diverters, but one missing piece remains. We must not upgrade
> sysvinit-core before the diverters have duplicated their diversions or
> we may cause file loss.

I'm missing something for sure here, but sysvinit-core has a conflict
with systemd-sysv and both bfh-container and progress-linux-container
depends on systemd-sysv so they already should not be installed at the
same time in a system regardless of the versioned conflicts you are
adding.. ?

Regards,
Lorenzo

> To achieve this, sysvinit-core needs to gain
> two more versioned Conflicts beyond molly-guard to be found in the
> attached patch.
> 
> Helmut



Bug#1065146: sysvinit-core: /usr/sbin/halt and others ineffectively diverted (DEP17)

2024-02-29 Thread Helmut Grohne
Package: sysvinit-core
Version: 3.08-7
Severity: serious
Tags: patch
User: helm...@debian.org
Usertags: dep17p3
Control: affects -1 + bfh-container progress-linux-container

Hi,

thanks for applying my earlier /usr-move patch #1060139. Since authoring
it, the mitigations for ineffective diversions have been added to
diverters, but one missing piece remains. We must not upgrade
sysvinit-core before the diverters have duplicated their diversions or
we may cause file loss. To achieve this, sysvinit-core needs to gain two
more versioned Conflicts beyond molly-guard to be found in the attached
patch.

Helmut
diff --minimal -Nru sysvinit-3.08/debian/changelog 
sysvinit-3.08/debian/changelog
--- sysvinit-3.08/debian/changelog  2024-02-29 12:22:45.0 +0100
+++ sysvinit-3.08/debian/changelog  2024-03-01 07:53:14.0 +0100
@@ -1,3 +1,11 @@
+sysvinit (3.08-7.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Update versioned Conflicts to handle DEP17 ineffective diversions for more
+diverters. (Closes: #-1)
+
+ -- Helmut Grohne   Fri, 01 Mar 2024 07:53:14 +0100
+
 sysvinit (3.08-7) unstable; urgency=medium
 
   [ Johannes Schauer Marin Rodrigues ]
diff --minimal -Nru sysvinit-3.08/debian/control sysvinit-3.08/debian/control
--- sysvinit-3.08/debian/control2024-02-29 12:22:45.0 +0100
+++ sysvinit-3.08/debian/control2024-03-01 07:53:12.0 +0100
@@ -32,6 +32,8 @@
  systemd-sysv,
  runit-init,
  molly-guard (<< 0.8.3~),
+ bfh-container (<< 20211009-24~),
+ progress-linux-container (<< 20221002-12~),
 Breaks:
  manpages-es (<< 4.15.0-9~),
  manpages-fr (<< 4.15.0-9~),