Bug#1069368: Updating golang-github-golang-protobuf-1-5 to fix FTBFS

2024-04-21 Thread Anthony Fok
On Sun, Apr 21, 2024 at 10:03 AM Mathias Gibbens  wrote:
>
> On Sat, 2024-04-20 at 22:40 +0800, Shengjing Zhu wrote:
> > On Sat, Apr 20, 2024 at 10:28 PM Mathias Gibbens  wrote:
> > >
> > > Hi Anthony,
> > >
> > >   A few weeks ago you uploaded a new version of golang-google-protobuf
> > > to unstable which caused a FTBFS in golang-github-golang-protobuf-1-5
> > > v1.5.3 [1,2,3]. This has been blocking the transition of various golang
> > > packages from unstable to testing.
> > >
> > >   I've verified that v1.5.4 of golang-github-golang-protobuf-1-5 builds
> > > fine on my amd64 system. `build-rdeps golang-github-golang-protobuf-1-
> > > 5-dev` identifies 219 rdeps in main, so I haven't kicked off a `ratt`
> > > run testing for any build regressions with the newer version yet.
> > >
> >
> > This is a known regression in 1.5.3, see
> > https://github.com/golang/protobuf/issues/1596#issuecomment-1981208282
>
>   Since that appears to be the only change in v1.5.4, would there be
> any concerns with uploading that version to unstable? This breakage is
> starting to cause FTBFS bugs to be filed against affected packages,
> such as hugo (#1069371).
>
> Mathias

Hi Reinhard, Mathias and Shengjing,

Thank you for bringing this to my attention, and sorry for my late response!
Thank you also for your detailed investigation!  Very much appreciated!

I don't see any concern uploading v1.5.4 especially how it fixes the
regression and FTBFS
with v1.5.3, and I'll be uploading golang-github-golang-protobuf-1-5
1.5.4-1 very shortly.

Cheers,
Anthony



Bug#1069368: Updating golang-github-golang-protobuf-1-5 to fix FTBFS

2024-04-21 Thread Mathias Gibbens
On Sat, 2024-04-20 at 22:40 +0800, Shengjing Zhu wrote:
> On Sat, Apr 20, 2024 at 10:28 PM Mathias Gibbens  wrote:
> > 
> > Hi Anthony,
> > 
> >   A few weeks ago you uploaded a new version of golang-google-protobuf
> > to unstable which caused a FTBFS in golang-github-golang-protobuf-1-5
> > v1.5.3 [1,2,3]. This has been blocking the transition of various golang
> > packages from unstable to testing.
> > 
> >   I've verified that v1.5.4 of golang-github-golang-protobuf-1-5 builds
> > fine on my amd64 system. `build-rdeps golang-github-golang-protobuf-1-
> > 5-dev` identifies 219 rdeps in main, so I haven't kicked off a `ratt`
> > run testing for any build regressions with the newer version yet.
> > 
> 
> This is a known regression in 1.5.3, see
> https://github.com/golang/protobuf/issues/1596#issuecomment-1981208282

  Since that appears to be the only change in v1.5.4, would there be
any concerns with uploading that version to unstable? This breakage is
starting to cause FTBFS bugs to be filed against affected packages,
such as hugo (#1069371).

Mathias


signature.asc
Description: This is a digitally signed message part


Bug#1069368: Updating golang-github-golang-protobuf-1-5 to fix FTBFS

2024-04-20 Thread Shengjing Zhu
On Sat, Apr 20, 2024 at 10:28 PM Mathias Gibbens  wrote:
>
> Hi Anthony,
>
>   A few weeks ago you uploaded a new version of golang-google-protobuf
> to unstable which caused a FTBFS in golang-github-golang-protobuf-1-5
> v1.5.3 [1,2,3]. This has been blocking the transition of various golang
> packages from unstable to testing.
>
>   I've verified that v1.5.4 of golang-github-golang-protobuf-1-5 builds
> fine on my amd64 system. `build-rdeps golang-github-golang-protobuf-1-
> 5-dev` identifies 219 rdeps in main, so I haven't kicked off a `ratt`
> run testing for any build regressions with the newer version yet.
>

This is a known regression in 1.5.3, see
https://github.com/golang/protobuf/issues/1596#issuecomment-1981208282


-- 
Shengjing Zhu



Bug#1069368: Updating golang-github-golang-protobuf-1-5 to fix FTBFS

2024-04-20 Thread Mathias Gibbens
Hi Anthony,

  A few weeks ago you uploaded a new version of golang-google-protobuf
to unstable which caused a FTBFS in golang-github-golang-protobuf-1-5
v1.5.3 [1,2,3]. This has been blocking the transition of various golang
packages from unstable to testing.

  I've verified that v1.5.4 of golang-github-golang-protobuf-1-5 builds
fine on my amd64 system. `build-rdeps golang-github-golang-protobuf-1-
5-dev` identifies 219 rdeps in main, so I haven't kicked off a `ratt`
run testing for any build regressions with the newer version yet.

  Are you waiting on something specific before updating golang-github-
golang-protobuf-1-5?

Thanks,
Mathias

[1] -- https://qa.debian.org/excuses.php?package=golang-google-protobuf
[2] -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068136
[3] -- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069368


signature.asc
Description: This is a digitally signed message part