Processed: Re: Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-11-11 Thread Debian Bug Tracking System 
Processing control commands:

 clone -1 -2
Bug #759960 [src:libcatalyst-engine-psgi-perl] libcatalyst-engine-psgi-perl: 
FTBFS: dh_auto_test: make -j1 test returned exit code 2
Bug 759960 cloned as bug 769093
 reassign -2 libcatalyst-perl
Bug #769093 [src:libcatalyst-engine-psgi-perl] libcatalyst-engine-psgi-perl: 
FTBFS: dh_auto_test: make -j1 test returned exit code 2
Bug reassigned from package 'src:libcatalyst-engine-psgi-perl' to 
'libcatalyst-perl'.
No longer marked as found in versions libcatalyst-engine-psgi-perl/0.13+dfsg-2.
Ignoring request to alter fixed versions of bug #769093 to the same values 
previously set
 retitle -2 Please stop build-depending on libcatalyst-engine-psgi-perl which 
 will be removed
Bug #769093 [libcatalyst-perl] libcatalyst-engine-psgi-perl: FTBFS: 
dh_auto_test: make -j1 test returned exit code 2
Changed Bug title to 'Please stop build-depending on 
libcatalyst-engine-psgi-perl which will be removed' from 
'libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit 
code 2'

-- 
759960: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759960
769093: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769093
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-11-11 Thread Simon McVittie 
Control: clone -1 -2
Control: reassign -2 libcatalyst-perl
Control: retitle -2 Please stop build-depending on libcatalyst-engine-psgi-perl 
which will be removed

On Sat, 25 Oct 2014 at 20:04:19 +0200, gregor herrmann wrote:
 libmojomojo-perl uploaded with the patch and without the dependency
 on libcatalyst-engine-psgi-perl, so the latter can be removed from
 testing (and the archive).

Sorry, can't do that yet:

 smcv@coccia:~$ dak rm -R -n libcatalyst-engine-psgi-perl
 Will remove the following packages from unstable:
 
 libcatalyst-engine-psgi-perl | 0.13+dfsg-2 | source, all
 
 Maintainer: Debian Perl Group pkg-perl-maintain...@lists.alioth.debian.org
 
 --- Reason ---
 
 --
 
 Checking reverse dependencies...
 # Broken Build-Depends:
 libcatalyst-perl: libcatalyst-engine-psgi-perl
 
 Dependency problem found.

Given that Catalyst 5.90069_002's Changes entry says

  - Removed code related to supporting the long deprecated stand alone
PSGI Engine.

this build-dependency seems likely to be pointless.

The attached debdiff builds successfully, including build-time regression
tests. I have not tested it other than that.

Regards,
S
diffstat for libcatalyst-perl-5.90075 libcatalyst-perl-5.90075

 changelog |8 
 control   |3 +--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff -Nru libcatalyst-perl-5.90075/debian/changelog libcatalyst-perl-5.90075/debian/changelog
--- libcatalyst-perl-5.90075/debian/changelog	2014-10-08 20:10:54.0 +0100
+++ libcatalyst-perl-5.90075/debian/changelog	2014-11-11 09:57:24.0 +
@@ -1,3 +1,11 @@
+libcatalyst-perl (5.90075-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove obsolete libcatalyst-engine-psgi-perl build-dependency
+so that package can be removed from the archive (Closes: #xx)
+
+ -- Simon McVittie s...@debian.org  Tue, 11 Nov 2014 09:56:52 +
+
 libcatalyst-perl (5.90075-1) unstable; urgency=medium
 
   [ Salvatore Bonaccorso ]
diff -Nru libcatalyst-perl-5.90075/debian/control libcatalyst-perl-5.90075/debian/control
--- libcatalyst-perl-5.90075/debian/control	2014-10-08 20:10:54.0 +0100
+++ libcatalyst-perl-5.90075/debian/control	2014-11-11 09:56:47.0 +
@@ -2,8 +2,7 @@
 Section: perl
 Priority: optional
 Build-Depends: debhelper (= 8)
-Build-Depends-Indep: libcatalyst-engine-psgi-perl,
- libcatalystx-leakchecker-perl,
+Build-Depends-Indep: libcatalystx-leakchecker-perl,
  libcgi-simple-perl,
  libcgi-struct-xs-perl,
  libclass-accessor-perl,

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-11-10 Thread gregor herrmann 
On Sun, 09 Nov 2014 18:45:25 +, Simon McVittie wrote:

 On Sat, 25 Oct 2014 at 20:04:19 +0200, gregor herrmann wrote:
  libmojomojo-perl uploaded with the patch and without the dependency
  on libcatalyst-engine-psgi-perl, so the latter can be removed from
  testing (and the archive).
 Any objection to an RM:RoQA bug asking for libcatalyst-engine-psgi-perl
 to be removed from unstable?

Not at all, please feel free to go ahead, and thanks for your help.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-11-09 Thread Simon McVittie 
On Sat, 25 Oct 2014 at 20:04:19 +0200, gregor herrmann wrote:
 libmojomojo-perl uploaded with the patch and without the dependency
 on libcatalyst-engine-psgi-perl, so the latter can be removed from
 testing (and the archive).

Any objection to an RM:RoQA bug asking for libcatalyst-engine-psgi-perl
to be removed from unstable?

S


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-10-25 Thread gregor herrmann 
On Fri, 24 Oct 2014 16:26:01 +0200, gregor herrmann wrote:

 I now added a patch to use the Plack Engine instead of
 Catalyst::Engine::PSGI, as described in Catalyst::Upgrading.

libmojomojo-perl uploaded with the patch and without the dependency
on libcatalyst-engine-psgi-perl, so the latter can be removed from
testing (and the archive).
 

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Funny van Dannen: Korkenzieherlocken


signature.asc
Description: Digital Signature

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-10-24 Thread gregor herrmann 
On Sat, 04 Oct 2014 20:02:47 +0200, gregor herrmann wrote:

 OTOH, I'm not sure what this tells us:
 
 % grep -r PSGI *
 META.yml:  Catalyst::Engine::PSGI: 0
 Makefile.PL:'Catalyst::Engine::PSGI'   = '0',
 app.psgi:MojoMojo-setup_engine('PSGI');
 script/mojomojo.psgi:MojoMojo-setup_engine('PSGI');
 
 (the former gets installed, the latter doesn't).

I now added a patch to use the Plack Engine instead of
Catalyst::Engine::PSGI, as described in Catalyst::Upgrading.

The tests still pass but I feel a bit like poking around in the mist,
so this should get reviewed ...


Cheers,
gregor


-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bob Dylan: Make You Feel My Love


signature.asc
Description: Digital Signature

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-10-04 Thread Niko Tyni 
On Sat, Aug 30, 2014 at 02:40:55PM -0700, Lucas Nussbaum wrote:
 Source: libcatalyst-engine-psgi-perl
 Version: 0.13+dfsg-2
 Severity: serious
 Tags: jessie sid
 User: debian...@lists.debian.org
 Usertags: qa-ftbfs-20140830 qa-ftbfs
 Justification: FTBFS on amd64

  [error] Caught exception in engine Can't use an undefined value as a HASH 
  reference at 
  /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/blib/lib/Catalyst/Engine/PSGI.pm
   line 113.
  
  #   Failed test at 
  /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/inc/Test/More.pm line 
  420.
  #   'Bad request'
  # doesn't match '(?^:Welcome)'

As noted in the upstream bug, this is caused by the libcatalyst-perl upgrade
from 5.90065-1 to 5.90071-1. This upstream changelog entry seems relevant:

  - Removed code related to supporting the long deprecated stand alone
PSGI Engine.  If you are still using this you code is now broken.
Luckily you can just stop using it and likely everything will work
under the new PSGI support built into Catalyst for several years.

I assume that this 'stand alone PSGI Engine' is Catalyst-Engine-PSGI,
in which case it looks like removal is in order? 

I see libmojomojo-perl depends on it, not sure how hard that dependency is?
-- 
Niko Tyni   nt...@debian.org


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-10-04 Thread gregor herrmann 
On Sat, 04 Oct 2014 17:00:46 +0300, Niko Tyni wrote:

 As noted in the upstream bug, this is caused by the libcatalyst-perl upgrade
 from 5.90065-1 to 5.90071-1. This upstream changelog entry seems relevant:
 
   - Removed code related to supporting the long deprecated stand alone
 PSGI Engine.  If you are still using this you code is now broken.
 Luckily you can just stop using it and likely everything will work
 under the new PSGI support built into Catalyst for several years.
 
 I assume that this 'stand alone PSGI Engine' is Catalyst-Engine-PSGI,
 in which case it looks like removal is in order? 

Nice catch, thank you.
 
 I see libmojomojo-perl depends on it, not sure how hard that dependency is?


At first glance it doesn't look very hard:

% grep -r Catalyst::Engine::PSGI *
META.yml:  Catalyst::Engine::PSGI: 0
Makefile.PL:'Catalyst::Engine::PSGI'

i.e. it's only in the metadata but not use'd anywhere.

If I drop the buildtime and runtime dependency, (and wait for 354
packages being installed in my build chroot,) the test suite during
the build passes, and the autopkgtest failures at least don't talk
about Catalyst::Engine::PSGI.

OTOH, I'm not sure what this tells us:

% grep -r PSGI *
META.yml:  Catalyst::Engine::PSGI: 0
Makefile.PL:'Catalyst::Engine::PSGI'   = '0',
app.psgi:MojoMojo-setup_engine('PSGI');
script/mojomojo.psgi:MojoMojo-setup_engine('PSGI');

(the former gets installed, the latter doesn't).


Changes pushed; but I need to run now, and this might need a second
look anyway.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Joan Baez: Ghetto


signature.asc
Description: Digital Signature

Bug#759960: libcatalyst-engine-psgi-perl: FTBFS: dh_auto_test: make -j1 test returned exit code 2

2014-08-30 Thread Lucas Nussbaum 
Source: libcatalyst-engine-psgi-perl
Version: 0.13+dfsg-2
Severity: serious
Tags: jessie sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20140830 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
 make[1]: Entering directory 
 '/«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg'
 PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -MTest::Harness 
 -e undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 
 'blib/arch') t/*.t
 Possible precedence issue with control flow operator at 
 /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/inc/Test/Builder.pm line 
 917.
 t/00_compile.t ... ok
 Possible precedence issue with control flow operator at 
 /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/inc/Test/Builder.pm line 
 917.
 [debug] Debug messages enabled
 [debug] Statistics enabled
 Term::Size::Any is not installed, can't autodetect terminal column width
 Trouble trying to detect your terminal size, looking at $ENV{COLUMNS}
 Cannot determine desired terminal width, using default of 80 columns
 [debug] Loaded PSGI Middleware:
 ..
 | Catalyst::Middleware::Stash|
 | Plack::Middleware::HTTPExceptions  |
 | Plack::Middleware::RemoveRedundantBody  0.04   |
 | Plack::Middleware::FixMissingBodyInRedirect  0.10  |
 | Plack::Middleware::ContentLength   |
 | Plack::Middleware::MethodOverride  0.10|
 | Plack::Middleware::Head|
 ''
 
 [debug] Loaded Request Data Handlers:
 ..
 | application/x-www-form-urlencoded  |
 | application/json   |
 ''
 
 [debug] Loaded dispatcher Catalyst::Dispatcher
 [debug] Loaded engine Catalyst::Engine
 [debug] Found home 
 /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/t/Hello
 [debug] Loaded components:
 .-+--.
 | Class   | Type |
 +-+--+
 | Hello::Controller::Metalic  | instance |
 | Hello::Controller::Root | instance |
 '-+--'
 
 [debug] Loaded Private actions:
 .--+--+--.
 | Private  | Class| Method   |
 +--+--+--+
 | /welcome | Hello::Controller::Root  | welcome  |
 | /default | Hello::Controller::Root  | default  |
 | /headers | Hello::Controller::Root  | headers  |
 | /index   | Hello::Controller::Root  | index|
 | /end | Hello::Controller::Root  | end  |
 '--+--+--'
 
 [debug] Loaded Path actions:
 .-+--.
 | Path| Private  |
 +-+--+
 | /   | /index   |
 | /...| /default |
 | /headers/...| /headers |
 | /welcome/...| /welcome |
 '-+--'
 
 [info] Hello powered by Catalyst 5.90071
 You are running Catalyst::Engine::PSGI, which is considered a legacy engine 
 for
 this version of Catalyst.  We will continue running and use your existing psgi
 file, but it is recommended to perform the trivial upgrade process, which will
 leave you with less code and a forward path.
 
 Please review Catalyst::Upgrading
 Subroutine Catalyst::Request::env redefined at 
 /«BUILDDIR»/libcatalyst-engine-psgi-perl-0.13+dfsg/blib/lib/Catalyst/Engine/PSGI.pm
  line 13.
 env as a writer is deprecated, you probably need to upgrade 
 Catalyst::Engine::PSGI at /usr/share/perl5/Catalyst/Engine.pm