Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-07 Thread Andreas Henriksson
Hello Rich.

On Sun, Oct 05, 2014 at 01:59:46PM +0100, Richard W.M. Jones wrote:
 
  libaugeas0,
  libcap2,
  libhivex0,
  libpcre3,
  libxml2,
  libyajl2,
 
 Why are these wrong?  They all seem to be correct build deps to me.

A debian package normally build-depends on the development package
providing the development files (headers, pkg-config, (unversioned)
shared object file, etc.) rather then simply on a package with only
a particular versioned .so.X.

In other words, build-dependencies should normally end with -dev
(if it's a library and not a tool used during the build process).

The above list would be more correct as:
libaugeas-dev,
libcap-dev,
libhivex-dev,
libpcre3-dev,
libxml2-dev,
libyajl-dev,


All of these are probably pulled in indirectly via some other
build-dependency right now but should be explicitly specified if
they really are build-dependencies of libguestfs.
The above -dev packages also specifies a dependency on their
respective libfooX package as needed.

Doing this correctly is what makes it possible to do binNMUs
when there's a transition for a certain library (ie. it gets
a new so version). Doing this incorrectly makes that impossible.

Regards,
Andreas Henriksson


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-07 Thread Richard W.M. Jones
On Tue, Oct 07, 2014 at 11:44:00PM +0200, Andreas Henriksson wrote:
 Hello Rich.
 
 On Sun, Oct 05, 2014 at 01:59:46PM +0100, Richard W.M. Jones wrote:
  
   libaugeas0,
   libcap2,
   libhivex0,
   libpcre3,
   libxml2,
   libyajl2,
  
  Why are these wrong?  They all seem to be correct build deps to me.
 
 A debian package normally build-depends on the development package
 providing the development files (headers, pkg-config, (unversioned)
 shared object file, etc.) rather then simply on a package with only
 a particular versioned .so.X.
 
 In other words, build-dependencies should normally end with -dev
 (if it's a library and not a tool used during the build process).
 
 The above list would be more correct as:
 libaugeas-dev,
 libcap-dev,
 libhivex-dev,
 libpcre3-dev,
 libxml2-dev,
 libyajl-dev,
 
 
 All of these are probably pulled in indirectly via some other
 build-dependency right now but should be explicitly specified if
 they really are build-dependencies of libguestfs.
 The above -dev packages also specifies a dependency on their
 respective libfooX package as needed.
 
 Doing this correctly is what makes it possible to do binNMUs
 when there's a transition for a certain library (ie. it gets
 a new so version). Doing this incorrectly makes that impossible.

But in the case of libguestfs, on Debian we depend on specific SONAMEs
(not for any real reason, just because Debian's packaging system
forces us to do that).  So if an SONAME changes it requires an
upstream patch or a downstream patch that eventually has to go
upstream.  So I still think that Hilko's build dependencies are
correct.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-05 Thread Richard W.M. Jones

 libaugeas0,
 libcap2,
 libhivex0,
 libpcre3,
 libxml2,
 libyajl2,

Why are these wrong?  They all seem to be correct build deps to me.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-04 Thread Andreas Henriksson
Hello Hilko Bengen.

Thanks for fixing up the incorrect libsystemd build-dependencies
in libguestfs. Unfortunately there are many more that are also wrong.

Please fix up the rest as well. eg.
libaugeas0,
libcap2,
libhivex0,
libpcre3,
libxml2,
libyajl2,

There may be more... Please check.

Regards,
Andreas Henriksson


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-03 Thread Richard W.M. Jones
I'm not complete clear on what change is being made to Debian.
However from the build log, the problem is that 'libsystemd.so.0'
isn't making it into the appliance.

This seems to be because the following upstream commit shoud be
backported to the 1.26 branch (either in Debian or upstream):

  commit a36dde98899ea160a49c9af65a883383496cd331
  Author: Hilko Bengen ben...@hilluzination.de
  Date:   Fri Sep 19 18:55:50 2014 +0200

appliance: Add libsystemd0 (and systemd as an alternative for sysvinit) on 
Debian-based systems

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#763741: libguestfs: Incorrect build-dependencies (libsystemd-id128-0, libsystemd-journal0), fails binNMU

2014-10-02 Thread Andreas Henriksson
Source: libguestfs
Version: 1:1.26.9-1
Severity: serious
Justification: 7.7 Relationships between source and binary packages

Dear Maintainer,

During a round of binNMUs for the transition[1] to the unified libsystemd0
the binNMU fails to accomplish its goals for libguestfs.

Somehow the old libraries still get linked although the pkg-config flags
tells it to use libsystemd0.

I spotted these build-dependencies which in themselves are wrong:
libsystemd-id128-0, libsystemd-journal0

This might be the culprit for making the binNMU fail.


Regards,
Andreas Henriksson

[1]: https://release.debian.org/transitions/html/libsystemd0.html

-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org