Bug#797043: Bug#797079: wheezy-pu: package mozilla-noscript/2.6.8.19-1~deb7u2

[Kalle Olavi Niemitalo]

David Prévot  writes in Bug#797079:

> Uploaded (with the improved changelog and metadata suggested by Kalle),
> thanks.

I installed xul-ext-noscript 2.6.8.19-1~deb7u2 from
wheezy-proposed-updates, and it works OK.

However, I see the patch now has the following line:

Origin: backport, 
http://anonscm.debian.org/cgit/pkg-mozext/noscript.git/diff/components/noscriptService.js?h=upstream/2.6.8.42=upstream/2.6.8.42_rc1

That URL is a bit misleading because the diff is neither from
upstream/2.6.8.42 to upstream/2.6.8.42_rc1 nor vice versa;
it's instead from the parent commit (upstream/2.6.8.41) to
upstream/2.6.8.42_rc1.  When the query string of the URL contains
multiple "h" fields, cgit uses only the last one:

http://git.zx2c4.com/cgit/tree/cgit.c?h=v0.11.2#n300

A shorter URL would thus work just as well:

Origin: backport, 
http://anonscm.debian.org/cgit/pkg-mozext/noscript.git/diff/components/noscriptService.js?h=upstream/2.6.8.42_rc1

Or if you wanted to specify the older version explicitly,
you'd use "id2":

Origin: backport, 
http://anonscm.debian.org/cgit/pkg-mozext/noscript.git/diff/components/noscriptService.js?h=upstream/2.6.8.42_rc1=upstream/2.6.8.41

It's totally not worth making a new upload but I wanted to
mention it in case more backports are needed later.

Bug#797043: Bug#797079: wheezy-pu: package mozilla-noscript/2.6.8.19-1~deb7u2

[Kalle Olavi Niemitalo]

David Prévot taf...@debian.org writes:

 +  [ Kalle Olavi Niemitalo ]
 +  * Temporarily allow scripts with recent iceweasel
 +(Closes: #797043)

Those functions in noscriptService.js are used not only for
setting up the menu (from which the user could temporarily
whitelist sites), but also for deciding which tabs to reload
after the whitelist has been changed.  I would thus prefer
this kind of changelog entry:

  * Fix enumeration of scripts on iceweasel = 35.
Backported from upstream 2.6.8.42rc1.  (Closes: #797043)

I'm not sure how to format the backport in DEP-3 though, because
upstream doesn't seem to have a public version-control system.
Can it be done like this?

Origin: backport, 
http://anonscm.debian.org/cgit/pkg-mozext/noscript.git/diff/components/noscriptService.js?h=upstream/2.6.8.42id=2218a38a22e43834ce09c75fd5c3c5dc75bc7cf6

I searched the *.js files of xul-ext-noscript 2.6.8.19-1~deb7u1
with a regexp and didn't find any other places where a let
statement uses the variable being defined.  The regexp did not
cover statements that define multiple variables, though.