Package: sawfish-merlin-ugliness Version: 1.3.1-1 Severity: grave Tags: patch
Dear Maintainer, I recently upgraded from jessie to stretch. I found that nearly all customisations from sawfish-merlin-ugliness are missing from the configurator, and settings made before the upgrade have no effect. Customisations uglicon-ignore-hints and uglicon-search-filesystem are present in the configurator (Appearance->Window icons), but cannot be changed from their default values. The error log includes these errors: [2017-07-31 22:11:39] Unbound variable: expert [2017-07-31 22:11:39] Unbound variable: uglicon-reset [2017-07-31 22:11:39] Unbound variable: uglicon-reset [2017-07-31 22:11:39] Unbound variable: expert I think this is related to uglicon.jl's use of the defcustom :user-level key, which was already deprecated, and has been removed in the new version of sawfish. (I think that actually happened a long time ago upstream.) I assume this causes the loading of merlin.uglicon in ugliness.jl to fail, losing that file's functionality too. The attached patch seems to fix it. Tim Bagot -- System Information: Debian Release: 9.1 APT prefers stable APT policy: (500, 'stable'), (500, 'oldstable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages sawfish-merlin-ugliness depends on: ii sawfish 1:1.11.90-1+b1 sawfish-merlin-ugliness recommends no packages. sawfish-merlin-ugliness suggests no packages. -- no debconf information
--- uglicon.jl +++ uglicon.jl @@ -66,7 +66,6 @@ "Path to search for icons." :tooltip "Colon separated paths." :type string - :user-level expert :group (appearance uglicon) :depends uglicon-search-filesystem :after-set (lambda () (uglicon-reset))) @@ -75,7 +74,6 @@ "Icon prefixes to look for." :tooltip "Comma separated prefixes." :type string - :user-level expert :group (appearance uglicon) :depends uglicon-search-filesystem :after-set (lambda () (uglicon-reset))) @@ -84,7 +82,6 @@ "Icon suffixes to look for." :tooltip "Comma separated suffixes." :type string - :user-level expert :group (appearance uglicon) :depends uglicon-search-filesystem :after-set (lambda () (uglicon-reset))) @@ -93,14 +90,12 @@ "Maximum width of window icons." :type number :range (1 . 128) - :user-level expert :group (appearance uglicon)) (defcustom uglicon-height 48 "Maximum height of window icons." :type number :range (1 . 128) - :user-level expert :group (appearance uglicon)) (define-match-window-property 'window-icon 'appearance 'file)