Processed: Re: Bug#883706: dolphin4 is still linked with libplasma3

[Debian Bug Tracking System]

Processing control commands:

> severity -1 important
Bug #883706 [dolphin4] dolphin4 is still linked with libplasma3
Severity set to 'important' from 'serious'
> tag -1 - patch
Bug #883706 [dolphin4] dolphin4 is still linked with libplasma3
Removed tag(s) patch.

-- 
883706: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883706
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#883706: dolphin4 is still linked with libplasma3

[Pino Toscano]

Control: severity -1 important
Control: tag -1 - patch

In data mercoledì 6 dicembre 2017 19:33:10 CET, Adrian Bunk ha scritto:
> Package: dolphin4
> Version: 4:16.08.3-1
> Severity: serious
> Tags: patch buster sid
> 
> dolphin4 is still linked with libplasma3,
> which has to be removed for the qtwebkit removal.

NACK.

dolphin4 (which uses kdelibs4) is shipped only to provide file browsing
capabilities to konqueror (which uses kdelibs4).  In recent versions of
KDE Applications kde-baseapps does not exist anymore, replaced by split
tarballs (konqueror, kfind, keditbookmarks, kdialog).  Only konqueror
is available in experimental, the others are waiting in NEW.  Once all
are available, they will replace kde-baseapps in unstable (in a
coordinated upload with kde-l10n, since they ship translations), and
thus dolphin4 will be removed.

To be honest, it would be much easier if you could *wait* for the
completion of Applications 17.08 in unstable/testing, so there will be
few more kdelibs4-using sources either dropped (like dolphin4) or
ported to Frameworks.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.

Bug#883706: dolphin4 is still linked with libplasma3

[Adrian Bunk]

Package: dolphin4
Version: 4:16.08.3-1
Severity: serious
Tags: patch buster sid

dolphin4 is still linked with libplasma3,
which has to be removed for the qtwebkit removal.

Fix attached.
Description: Even with -DBUILD_plasma=false dolphin4 was still linked with 
libplasma
Author: Adrian Bunk 

--- kde-baseapps-16.08.3.orig/dolphin/src/CMakeLists.txt
+++ kde-baseapps-16.08.3/dolphin/src/CMakeLists.txt
@@ -135,7 +135,7 @@ if(X11_Xrender_FOUND)
 target_link_libraries(dolphinprivate4 ${X11_Xrender_LIB})
 endif(X11_Xrender_FOUND)
 
-target_link_libraries(dolphinprivate4 ${KDE4_PLASMA_LIBS})
+#target_link_libraries(dolphinprivate4 ${KDE4_PLASMA_LIBS})
 
 set_target_properties(dolphinprivate4 PROPERTIES VERSION 
${GENERIC_LIB_VERSION} SOVERSION ${GENERIC_LIB_SOVERSION} )
 install(TARGETS dolphinprivate4  ${INSTALL_TARGETS_DEFAULT_ARGS})
--- kde-baseapps-16.08.3.orig/dolphin/src/views/tooltips/filemetadatatooltip.cpp
+++ kde-baseapps-16.08.3/dolphin/src/views/tooltips/filemetadatatooltip.cpp
@@ -41,7 +41,7 @@
 #endif
 
 // For the blurred tooltip background
-#include 
+//#include 
 
 FileMetaDataToolTip::FileMetaDataToolTip(QWidget* parent) :
 QWidget(parent),
@@ -174,8 +174,8 @@ void FileMetaDataToolTip::paintEvent(QPa
 
 void FileMetaDataToolTip::showEvent(QShowEvent *)
 {
-Plasma::WindowEffects::overrideShadow(winId(), true);
-Plasma::WindowEffects::enableBlurBehind(winId(), true, mask());
+//Plasma::WindowEffects::overrideShadow(winId(), true);
+//Plasma::WindowEffects::enableBlurBehind(winId(), true, mask());
 }
 
 #include "filemetadatatooltip.moc"