Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
This issue is long closed. I will not comment on that last email. Dirk -- http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
Dear Dirk,
On Thu, Jun 07, 2018 at 09:53:25AM -0500, Dirk Eddelbuettel wrote:
> [ offense deleted ]
I've really thought about whether I should answer your mail at all. The
fact that I'm doing so is due my continuous respect of the work you did
for the R packaging.
The package you uploaded contains a manually edited list of dependencies
which is redundant when using ${R:Depends}. I'd recommend to drop this
manual list as I suggested in my autogenerated patch. BTW,
autogeneration: I explicitly gave a hint that the patch also contains
a fix for lintian
I: hmisc source: testsuite-autopkgtest-missing
which would prevent that this kind of bugs would be left un-noticed for
a long time. In addition it would help to speed up the testing
migration - IMHO some extra sugar for adding that single line.
I'd also consider
I: hmisc source: debian-watch-uses-insecure-uri
http://cran.r-project.org/src/contrib/Hmisc_([-\d\.]*)\.tar.gz
worth fixing (I assume you read the debian-r list where I have
advertised a tool which is doing this for you).
Finally I interpretet your last mail about specifying versioned
Build-Depends on r-base-dev[1] somehow in a sense that you would not
continue with this habit (also suggested by my patch). Either
I misinterpreted your mail or this was an oversight of yours. It
would clearly help if you would not hide your technical statements
into personal attacks.
Thanks for considering
Andreas.
[1] https://lists.debian.org/debian-r/2018/05/msg00030.html
--
http://fam-tille.de
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
On 7 June 2018 at 16:39, Andreas Tille wrote: | out speculations about common sense. Please be so kind and upload a | fixed package instead of defending your inappropriate decrease of the | bug severity. You are a few units of time measurement behind the chain of events as the updated package is already in unstable. But keep arguing, and chasing mindmills. Dirk -- http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
On Thu, Jun 07, 2018 at 09:01:41AM -0500, Dirk Eddelbuettel wrote: > > Consider the following thought experiment: > > - the change was made in 2014 > - nobody noticed There is no need for a thought experiment. I was working around this bug several times (last time here[1]). The problem simply became obvious since dh-update-R tries to create a sensible set of dependencies - formerly the set was manually craftet and it did not became obvious that its just a bug in r-cran-hmisc. If you need another proof that somebody noticed and also worked around feel free to inspect Graham's commit[2]. > - the bug is filed 'grave' grave makes the package in question unusable or mostly so If you install r-cran-hmisc on a fresh installation it is unusable. > So either nobody uses the package, or it doesn't matter in practical > use. Both ot these cannot be true at the same. There is no definition if "practical use". A package should work out of the box on a fresh installation. R-cran-hmisc does not fulfill this criterion. Moreover it took me only a couple of minutes to prove that the issue caused work for at least two fellow developers. > I am not interested in theoretical consideration quote reference manual or > policy. I have been here long enough to understand that you are correct in > the narrow (and here, irrelevant) sense. I simply still have not given up > hope that you may have some common sense left. I could be wrong. I would love if we could settle with technical argumentation and leave out speculations about common sense. Please be so kind and upload a fixed package instead of defending your inappropriate decrease of the bug severity. Thank you Andreas. [1] https://salsa.debian.org/r-pkg-team/r-bioc-biovizbase/commit/c2aab7de43f385fc20ec966861ca3aaa374c3fcc [2] https://salsa.debian.org/r-pkg-team/r-bioc-cummerbund/commit/367f89148e51f37188480d17f3f12f3dfa7a77e1 -- http://fam-tille.de
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
On 7 June 2018 at 15:32, Andreas Tille wrote: | Hi Dirk, | | On Thu, Jun 07, 2018 at 07:38:36AM -0500, Dirk Eddelbuettel wrote: | > | > severity -1 normal | > quit | > | > On 7 June 2018 at 14:25, Andreas Tille wrote: | > | Package: r-cran-hmisc | > | Severity: grave | > | Tags: patch | > | Justification: renders package unusable | > | > Not really. Those two are "Recommended" package. Any normal R installation has them. | | I will not entertain severity ping-pong but your arguing is wrong. | Pbuilder is creating a minimum installation and the missing Dependency | simply breaks other packages. Consider the following thought experiment: - the change was made in 2014 - nobody noticed - the bug is filed 'grave' So either nobody uses the package, or it doesn't matter in practical use. Both ot these cannot be true at the same. I am not interested in theoretical consideration quote reference manual or policy. I have been here long enough to understand that you are correct in the narrow (and here, irrelevant) sense. I simply still have not given up hope that you may have some common sense left. I could be wrong. Dirk | > Looks like an editing oversight when the Build-Depends got expanded. Given | > the near-official status of those two "Recommended" package, it does hardly | > matter every R installation will have them -- particularly an expanded one | > that could have CRAN package Hmisc. | > | > Fixing it regardless. | | Thank you | | Andreas. | | -- | http://fam-tille.de -- http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
And of course in the rush before getting out of the house I did the R 3.5.0 and package update, but not the bug fix. A -3 revision coming up shortly which truly fixes it. Dirk -- http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
Hi Dirk, On Thu, Jun 07, 2018 at 07:38:36AM -0500, Dirk Eddelbuettel wrote: > > severity -1 normal > quit > > On 7 June 2018 at 14:25, Andreas Tille wrote: > | Package: r-cran-hmisc > | Severity: grave > | Tags: patch > | Justification: renders package unusable > > Not really. Those two are "Recommended" package. Any normal R installation > has them. I will not entertain severity ping-pong but your arguing is wrong. Pbuilder is creating a minimum installation and the missing Dependency simply breaks other packages. > Looks like an editing oversight when the Build-Depends got expanded. Given > the near-official status of those two "Recommended" package, it does hardly > matter every R installation will have them -- particularly an expanded one > that could have CRAN package Hmisc. > > Fixing it regardless. Thank you Andreas. -- http://fam-tille.de
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
severity -1 normal quit On 7 June 2018 at 14:25, Andreas Tille wrote: | Package: r-cran-hmisc | Severity: grave | Tags: patch | Justification: renders package unusable Not really. Those two are "Recommended" package. Any normal R installation has them. | Hi, | | the package is lacking | |Depends: r-cran-foreign, r-cran-nnet Looks like an editing oversight when the Build-Depends got expanded. Given the near-official status of those two "Recommended" package, it does hardly matter every R installation will have them -- particularly an expanded one that could have CRAN package Hmisc. Fixing it regardless. Dirk -- http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
Bug#900974: r-cran-hmisc: Missing Depends: r-cran-foreign, r-cran-nnet
Package: r-cran-hmisc
Severity: grave
Tags: patch
Justification: renders package unusable
Hi,
the package is lacking
Depends: r-cran-foreign, r-cran-nnet
I've attached a debdiff which I created using dh-update-R which fixes
the issue. Please note that the debdiff contains
Testsuite: autopkgtest-pkg-r
An activated autopkgtest easily uncovers missing Depends.
Kind regards
Andreas.
-- System Information:
Debian Release: 9.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-5-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages r-cran-hmisc depends on:
ii libc62.24-11+deb9u1
pn libgfortran3
ii libquadmath0 6.3.0-18+deb9u1
pn r-api-3
pn r-base-core
pn r-cran-acepack
pn r-cran-base64enc
pn r-cran-chron
pn r-cran-cluster
pn r-cran-data.table
pn r-cran-formula
pn r-cran-ggplot2
pn r-cran-gridextra
pn r-cran-gtable
pn r-cran-htmltable
pn r-cran-htmltools
pn r-cran-lattice
pn r-cran-latticeextra
pn r-cran-rpart
pn r-cran-survival
pn r-cran-viridis
r-cran-hmisc recommends no packages.
r-cran-hmisc suggests no packages.
diff -u hmisc-4.1-1/debian/changelog hmisc-4.1-1/debian/changelog
--- hmisc-4.1-1/debian/changelog
+++ hmisc-4.1-1/debian/changelog
@@ -1,3 +1,11 @@
+hmisc (4.1-1-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * d/control: Fixing dependencies by using dh-upgrade-R
+ * d/rules: use dh-r
+
+ -- Andreas Tille Thu, 07 Jun 2018 13:51:56 +0200
+
hmisc (4.1-1-1) unstable; urgency=medium
* New upstream release
diff -u hmisc-4.1-1/debian/control hmisc-4.1-1/debian/control
--- hmisc-4.1-1/debian/control
+++ hmisc-4.1-1/debian/control
@@ -1,18 +1,43 @@
Source: hmisc
+Maintainer: Dirk Eddelbuettel
Section: gnu-r
+Testsuite: autopkgtest-pkg-r
Priority: optional
-Maintainer: Dirk Eddelbuettel
-Build-Depends: debhelper (>= 7.0), r-base-dev (>= 3.4.3), cdbs, r-cran-chron,
r-cran-lattice, r-cran-cluster, r-cran-survival, r-cran-rpart, r-cran-formula,
r-cran-latticeextra, r-cran-nnet, r-cran-foreign, r-cran-acepack,
r-cran-ggplot2 (>= 2.0.0), r-cran-gridextra, r-cran-data.table,
r-cran-htmltools, r-cran-gtable, r-cran-viridis, r-cran-htmltable,
r-cran-base64enc
-Standards-Version: 4.1.1
+Build-Depends: debhelper (>= 11~),
+ dh-r,
+ r-base-dev,
+ r-cran-chron,
+ r-cran-lattice,
+ r-cran-cluster,
+ r-cran-survival,
+ r-cran-rpart,
+ r-cran-formula,
+ r-cran-latticeextra,
+ r-cran-nnet,
+ r-cran-foreign,
+ r-cran-acepack,
+ r-cran-ggplot2 (>= 2.0.0),
+ r-cran-gridextra,
+ r-cran-data.table,
+ r-cran-htmltools,
+ r-cran-gtable,
+ r-cran-viridis,
+ r-cran-htmltable,
+ r-cran-base64enc
+Standards-Version: 4.1.4
Homepage: http://biostat.mc.vanderbilt.edu/s/Hmisc
Package: r-cran-hmisc
Architecture: any
-Replaces: r-noncran-hmisc
+Depends: ${R:Depends},
+ ${shlibs:Depends},
+ ${misc:Depends}
+Recommends: ${R:Recommends}
+Suggests: ${R:Suggests}
Conflicts: r-noncran-hmisc
Provides: r-noncran-hmisc
-Depends: ${shlibs:Depends}, ${misc:Depends}, ${R:Depends}, r-cran-chron,
r-cran-lattice, r-cran-cluster, r-cran-survival, r-cran-formula, r-cran-rpart,
r-cran-latticeextra, r-cran-acepack, r-cran-ggplot2, r-cran-gridextra,
r-cran-data.table, r-cran-htmltools, r-cran-gtable, r-cran-viridis,
r-cran-htmltable, r-cran-base64enc
-Description: GNU R miscellaneous functions by Frank Harrell
+Replaces: r-noncran-hmisc
+Description: GNU R miscellaneous functions by Frank Harrell
The Hmisc library contains many functions useful for data
analysis, high-level graphics, utility operations, functions for
computing sample size and power, translating SAS datasets,
diff -u hmisc-4.1-1/debian/rules hmisc-4.1-1/debian/rules
--- hmisc-4.1-1/debian/rules
+++ hmisc-4.1-1/debian/rules
@@ -2,6 +2,3 @@
-# -*- makefile -*-
-# debian/rules file for the Debian/GNU Linux r-cran-hmisc package
-# Copyright 2003 - 2017 by Dirk Eddelbuettel
-
-include /usr/share/R/debian/r-cran.mk
+%:
+ dh $@ --buildsystem R
