Source: ckermit
Version: 302-5.3
Severity: serious
Justification: policy section 4.6
Tags: upstream

ckermit does not trap errors from make. Failing to do so is prohibited
by the Debian policy section 4.6, because it can cause silent misbuilds
and makes debugging failures unnecessarily hard.

The cause is spread around the upstream makefile. For instance in the
linux+krb5+openssl target used by debian rules, the final "$(MAKE) linux
..." invocation is chained with ";". It then proceeds to checking for
missing files, but ultimately, the return code of the shell snipped is
always successful. A typical fix is putting "set -e; \" at the beginning
of such command chains. Though it needs to be fixed in a lot of places
here.

Helmut

Reply via email to