Bug#910217: [pkg-apparmor] Bug#910217: apparmor: removed shipped file: /var/cache/apparmor/CACHEDIR.TAG

[intrigeri]

Hi,

> 0m35.9s ERROR: FAIL: debsums reports modifications inside the chroot:
>   debsums: missing file /var/cache/apparmor/CACHEDIR.TAG (from apparmor 
> package)

Good catch! Looks like I did not realize the conflict between two set
of changes I've merged roughly at the same time (adding CACHEDIR.TAG
and cleaning up the obsolete cache files), ouch!

Sven Joachim:
> Attached is a patch (untested).

Thanks a lot. The patch looks good to me. I have some time booked next
week-end for AppArmor in Debian and I plan to test and upload then.
But feel free to beat me to it and NMU earlier after testing the
proposed command line. Bonus points if you submit the changes in your
upload as a merge request against
https://salsa.debian.org/apparmor-team/apparmor :)

Cheers,
-- 
intrigeri

Processed: Re: Bug#910217: apparmor: removed shipped file: /var/cache/apparmor/CACHEDIR.TAG

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + patch
Bug #910217 [apparmor] apparmor: removed shipped file: 
/var/cache/apparmor/CACHEDIR.TAG
Added tag(s) patch.

-- 
910217: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910217
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#910217: apparmor: removed shipped file: /var/cache/apparmor/CACHEDIR.TAG

[Sven Joachim]

Control: tags -1 + patch

On 2018-10-03 17:33 +0200, Andreas Beckmann wrote:

> Package: apparmor
> Version: 2.13-8
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
>
> Hi,
>
> during a test with piuparts I noticed your package removes files that
> it has shipped.
>
> From the attached log (scroll to the bottom...):
>
> 0m35.9s ERROR: FAIL: debsums reports modifications inside the chroot:
>   debsums: missing file /var/cache/apparmor/CACHEDIR.TAG (from apparmor 
> package)
>
>
> This was observed after a stretch->buster upgrade.

Attached is a patch (untested).

Cheers,
   Sven

>From 6c6d71192d2b1dc0ec47757f8c6acaf0c85a079e Mon Sep 17 00:00:00 2001
From: Sven Joachim 
Date: Fri, 12 Oct 2018 10:54:04 +0200
Subject: [PATCH] Do not remove /var/cache/apparmor/CACHEDIR.TAG on upgrades

Closes: #910217
---
 debian/apparmor.postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/apparmor.postinst b/debian/apparmor.postinst
index 7fefe18c..28cb4c78 100644
--- a/debian/apparmor.postinst
+++ b/debian/apparmor.postinst
@@ -32,7 +32,7 @@ case "$1" in
 	# since 2.13-1 apparmor_parser won't create cache files at the root
 	# of the cache-loc, but instead in sub-directories.
 	if dpkg --compare-versions "$2" lt-nl "2.13-7"; then
-		find /var/cache/apparmor -maxdepth 1 -type f -delete
+		find /var/cache/apparmor -maxdepth 1 -type f '!' -name CACHEDIR.TAG -delete
 	fi
 
 	# Try to determine values for apparmor/homedirs if the administrator
-- 
2.19.1

Bug#910217: apparmor: removed shipped file: /var/cache/apparmor/CACHEDIR.TAG

[Andreas Beckmann]

Package: apparmor
Version: 2.13-8
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package removes files that
it has shipped.

>From the attached log (scroll to the bottom...):

0m35.9s ERROR: FAIL: debsums reports modifications inside the chroot:
  debsums: missing file /var/cache/apparmor/CACHEDIR.TAG (from apparmor package)


This was observed after a stretch->buster upgrade.


cheers,

Andreas


apparmor_2.13-8.log.gz
Description: application/gzip