Bug#911510: nfs-utils: scripts using rpcinfo don't find it

2018-10-22 Thread Laurent Bigonville

Le 22/10/18 à 09:34, Sven Joachim a écrit :

Control: severity -1 serious
Control: reassign -1 rpcbind 1.2.5-0.1
Control: retitle -1 rpcbind: changed location of rpcinfo breaks nfs-utils

Am 21.10.2018 um 09:54 schrieb Elimar Riesebieter:


Source: nfs-utils
Version: 1.3.4-2.2
Severity: grave
Tags: patch
Justification: renders package unusable


bug- and initscripts using rpcinfo are looking in $PREFIX/sbin.
Since rpcbind installs rpcinfo in $PREFIX/bin we need to adjust the
scripts as proposed in the attached patch.

It would also be necessary to add adjust the dependency on rpcbind to
(>= 1.2.5), since earlier versions of rpcbind installed rpcinfo in
/usr/sbin.  And rpcbind would need a versioned Breaks on
nfs-{common,kernel-server}.


Or we need to change rpcbind to install rpcinfo in $PREFIX/sbin

That's where it was before the rpcbind NMUs.  Certainly /usr/bin is a
more logical place for rpcinfo; the reason why it was put into /usr/sbin
is that libc-bin versions before 2.16 used to ship /usr/bin/rpcinfo.
See also #707589 on that topic.


I see[0] different things hardcoding the /usr/sbin path, I think the 
best would be to add a symlink in /usr/sbin (?)


[0] https://codesearch.debian.net/search?q=%2Fsbin%2Frpcinfo



Processed: Re: Bug#911510: nfs-utils: scripts using rpcinfo don't find it

2018-10-22 Thread Debian Bug Tracking System
Processing control commands:

> severity -1 serious
Bug #911510 [src:nfs-utils] nfs-utils: scripts using rpcinfo don't find it
Severity set to 'serious' from 'grave'
> reassign -1 rpcbind 1.2.5-0.1
Bug #911510 [src:nfs-utils] nfs-utils: scripts using rpcinfo don't find it
Bug reassigned from package 'src:nfs-utils' to 'rpcbind'.
No longer marked as found in versions nfs-utils/1:1.3.4-2.3.
Ignoring request to alter fixed versions of bug #911510 to the same values 
previously set
Bug #911510 [rpcbind] nfs-utils: scripts using rpcinfo don't find it
Marked as found in versions rpcbind/1.2.5-0.1.
> retitle -1 rpcbind: changed location of rpcinfo breaks nfs-utils
Bug #911510 [rpcbind] nfs-utils: scripts using rpcinfo don't find it
Changed Bug title to 'rpcbind: changed location of rpcinfo breaks nfs-utils' 
from 'nfs-utils: scripts using rpcinfo don't find it'.

-- 
911510: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911510
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#911510: nfs-utils: scripts using rpcinfo don't find it

2018-10-22 Thread Sven Joachim
Control: severity -1 serious
Control: reassign -1 rpcbind 1.2.5-0.1
Control: retitle -1 rpcbind: changed location of rpcinfo breaks nfs-utils

Am 21.10.2018 um 09:54 schrieb Elimar Riesebieter:

> Source: nfs-utils
> Version: 1.3.4-2.2
> Severity: grave
> Tags: patch
> Justification: renders package unusable
>
>
> bug- and initscripts using rpcinfo are looking in $PREFIX/sbin.
> Since rpcbind installs rpcinfo in $PREFIX/bin we need to adjust the
> scripts as proposed in the attached patch.

It would also be necessary to add adjust the dependency on rpcbind to
(>= 1.2.5), since earlier versions of rpcbind installed rpcinfo in
/usr/sbin.  And rpcbind would need a versioned Breaks on
nfs-{common,kernel-server}.

> Or we need to change rpcbind to install rpcinfo in $PREFIX/sbin

That's where it was before the rpcbind NMUs.  Certainly /usr/bin is a
more logical place for rpcinfo; the reason why it was put into /usr/sbin
is that libc-bin versions before 2.16 used to ship /usr/bin/rpcinfo.
See also #707589 on that topic.

Cheers,
   Sven



Bug#911510: nfs-utils: scripts using rpcinfo don't find it

2018-10-21 Thread Elimar Riesebieter
Source: nfs-utils
Version: 1.3.4-2.2
Severity: grave
Tags: patch
Justification: renders package unusable


bug- and initscripts using rpcinfo are looking in $PREFIX/sbin.
Since rpcbind installs rpcinfo in $PREFIX/bin we need to adjust the
scripts as proposed in the attached patch.

Or we need to change rpcbind to install rpcinfo in $PREFIX/sbin

-- 
   Elimar
>From fd47a590a82c2bcced8c0d5f45ae8a37cb660744 Mon Sep 17 00:00:00 2001
From: Elimar Riesebieter 
Date: Sun, 21 Oct 2018 09:43:58 +0200
Subject: [PATCH] Change binary dir of rpcinfo

---
 debian/nfs-common.bugscript| 2 +-
 debian/nfs-common.init | 4 ++--
 debian/nfs-kernel-server.bugscript | 2 +-
 debian/nfs-kernel-server.init  | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/debian/nfs-common.bugscript b/debian/nfs-common.bugscript
index 7e6a73a..7af3df0 100644
--- a/debian/nfs-common.bugscript
+++ b/debian/nfs-common.bugscript
@@ -2,7 +2,7 @@
 set -e
 
 echo '-- rpcinfo --' >&3
-/usr/sbin/rpcinfo -p >&3
+/usr/bin/rpcinfo -p >&3
 
 echo '-- /etc/default/nfs-common --' >&3
 cat /etc/default/nfs-common|grep -v -e '^\#' -e '^$' >&3
diff --git a/debian/nfs-common.init b/debian/nfs-common.init
index 052de51..134e53f 100644
--- a/debian/nfs-common.init
+++ b/debian/nfs-common.init
@@ -123,8 +123,8 @@ case "$1" in
log_progress_msg "statd"

# See if rpcbind is running
-   if [ -x /usr/sbin/rpcinfo ]; then
-   /usr/sbin/rpcinfo -p >/dev/null 2>&1
+   if [ -x /usr/bin/rpcinfo ]; then
+   /usr/bin/rpcinfo -p >/dev/null 2>&1
RET=$?
if [ $RET != 0 ]; then
   echo
diff --git a/debian/nfs-kernel-server.bugscript 
b/debian/nfs-kernel-server.bugscript
index eed581d..5599834 100644
--- a/debian/nfs-kernel-server.bugscript
+++ b/debian/nfs-kernel-server.bugscript
@@ -2,7 +2,7 @@
 set -e
 
 echo '-- rpcinfo --' >&3
-/usr/sbin/rpcinfo -p >&3
+/usr/bin/rpcinfo -p >&3
 
 echo '-- /etc/default/nfs-kernel-server --' >&3
 cat /etc/default/nfs-kernel-server|grep -v -e '\#' -e '^$' >&3
diff --git a/debian/nfs-kernel-server.init b/debian/nfs-kernel-server.init
index e0c51d6..f25db3f 100644
--- a/debian/nfs-kernel-server.init
+++ b/debian/nfs-kernel-server.init
@@ -90,7 +90,7 @@ case "$1" in
log_progress_msg "nfsd"

# See if rpcbind is running
-   $PREFIX/sbin/rpcinfo -p >/dev/null 2>&1
+   $PREFIX/bin/rpcinfo -p >/dev/null 2>&1
RET=$?
if [ $RET != 0 ]; then
echo
-- 
2.19.1