Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
On 24/02/23 1:53 pm, gregor herrmann wrote: On Wed, 25 May 2022 11:34:20 +0200, gregor herrmann wrote: On Mon, 21 Feb 2022 21:18:10 +, Damyan Ivanov wrote: -=| intrigeri, 22.05.2020 08:47:25 +0200 |=- Niko Tyni (2020-05-21): libcolor-calc-perl has just one reverse dependency AFAICS: libcgi-application-plugin-authentication-perl. I took a quick look. Me too, a longer one :) … Then I read your comments about removal :) The last rdep is gone, so I guess we can just RM libcolor-calc-perl? Or we can salvage it, as mtj has added another patch, which makes the tests pass. Not sure if it's woth it; if yes we probably should 1) merge the two patches and 2) upload quickly. i'm happy to merge the patches today
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
On Wed, 25 May 2022 11:34:20 +0200, gregor herrmann wrote: > On Mon, 21 Feb 2022 21:18:10 +, Damyan Ivanov wrote: > > -=| intrigeri, 22.05.2020 08:47:25 +0200 |=- > > > Niko Tyni (2020-05-21): > > > > libcolor-calc-perl has just one reverse dependency AFAICS: > > > > libcgi-application-plugin-authentication-perl. > > > I took a quick look. > > Me too, a longer one :) > … > > Then I read your comments about removal :) > The last rdep is gone, so I guess we can just RM libcolor-calc-perl? Or we can salvage it, as mtj has added another patch, which makes the tests pass. Not sure if it's woth it; if yes we probably should 1) merge the two patches and 2) upload quickly. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
On Mon, 21 Feb 2022 21:18:10 +, Damyan Ivanov wrote: > -=| intrigeri, 22.05.2020 08:47:25 +0200 |=- > > Niko Tyni (2020-05-21): > > > libcolor-calc-perl has just one reverse dependency AFAICS: > > > libcgi-application-plugin-authentication-perl. > > I took a quick look. > Me too, a longer one :) … > Then I read your comments about removal :) The last rdep is gone, so I guess we can just RM libcolor-calc-perl? Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
-=| intrigeri, 22.05.2020 08:47:25 +0200 |=- > Hi, > > Niko Tyni (2020-05-21): > > So IMO we should either to package Graphics::ColorNames::HTML even though > > it's deprecated, or drop Color::Calc from Debian. > > > libcolor-calc-perl has just one reverse dependency AFAICS: > > libcgi-application-plugin-authentication-perl. > > I took a quick look. Me too, a longer one :) I just pushed a patch in Git that makes Color::Calc use '::WWW' instead of '::HTML', sorting hash keys so that color names are enumerated in a deterministic order and adapted almost all of the tests (mainly "gray"→"grey" and "aqua"→"cyan"). There is one test still failing, about "safe" colors. Then I read your comments about removal :) Uncertain what to do with the "safe" color conversion, looking at the aged upstream release, I decided to stop here. Maybe someone some day will find the patch useful. --dam
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
Hi, Niko Tyni (2020-05-21): > So IMO we should either to package Graphics::ColorNames::HTML even though > it's deprecated, or drop Color::Calc from Debian. > libcolor-calc-perl has just one reverse dependency AFAICS: > libcgi-application-plugin-authentication-perl. I took a quick look. At runtime, Color::Calc optionally enhances libcgi-application-plugin-authentication-perl: it allows providing one base color and letting the module derive other colors from it — as opposed to sticking with the default colors, or specifying every color one wants to use. At build time, it seems libcgi-application-plugin-authentication-perl should build just fine if Color::Calc is not available: the corresponding tests should be skipped. So that reverse build-dependency is probably not, in itself, a blocker for removing Color::Calc from Debian. libcolor-calc-perl's popcon is low and steadily decreasing since 10 years.
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
On Wed, May 20, 2020 at 10:22:31PM +0300, Niko Tyni wrote: > Package: libcolor-calc-perl > Version: 1.074-2 > Severity: grave > Tags: bullseye sid > X-Debbugs-Cc: libgraphics-colornames-p...@packages.debian.org > > Color::Calc uses Graphics::ColorNames::HTML, which was recently dropped > from the libgraphics-colornames-perl package in Debian. > > Graphics::ColorNames::HTML is now available separately on CPAN, with a > deprecation notice pointing users to Graphics::ColorNames::WWW (packaged > in Debian as libgraphics-colornames-www-perl) instead. > > So Color::Calc needs to adapt, or Graphics::ColorNames::HTML needs to be > packaged separately despite the deprecation. > > Also, libgraphics-colornames-perl should add a Breaks entry for the > versions of libcolor-calc-perl it broke. I had a look at making Color::Calc use Graphics::ColorNames::WWW instead. The API is a drop-in replacement, but the test suite blows up because it has more color names to choose from (17 in ::HTML vs 148 in ::WWW). The module seems to be partly about these subtle differences between different color schemes, so I'm a bit uneasy about patching it to use ::WWW by default and patching the test suite. We could also inline the small ::HTML hash, but part of the Color::Calc API is being able to choose a Graphics::ColorNames submodule, so we can't really hide it very deep. And if it's going to be a public module, it's cleaner to just package it separately I think. So IMO we should either to package Graphics::ColorNames::HTML even though it's deprecated, or drop Color::Calc from Debian. libcolor-calc-perl has just one reverse dependency AFAICS: libcgi-application-plugin-authentication-perl. -- Niko Tyni nt...@debian.org
Bug#961147: libcolor-calc-perl: broken by new libgraphics-colornames-perl
Package: libcolor-calc-perl Version: 1.074-2 Severity: grave Tags: bullseye sid X-Debbugs-Cc: libgraphics-colornames-p...@packages.debian.org Color::Calc uses Graphics::ColorNames::HTML, which was recently dropped from the libgraphics-colornames-perl package in Debian. Graphics::ColorNames::HTML is now available separately on CPAN, with a deprecation notice pointing users to Graphics::ColorNames::WWW (packaged in Debian as libgraphics-colornames-www-perl) instead. So Color::Calc needs to adapt, or Graphics::ColorNames::HTML needs to be packaged separately despite the deprecation. Also, libgraphics-colornames-perl should add a Breaks entry for the versions of libcolor-calc-perl it broke. -- Niko Tyni nt...@debian.org
