Bug#970762: in package pciutils marked as pending
Control: tag 970762 pending Hi! Bug #970762 in package pciutils reported by you has been fixed in the debian/pkgs/pciutils.git Git repository. You can see the changelog below, and you can check the diff of the fix at: https://git.hadrons.org/cgit/debian/pkgs/pciutils.git/diff/?id=83ee091 --- commit 83ee091b2f7cb02f7d75b554a8d969eee6870821 Author: Guillem Jover Date: Mon Oct 5 01:41:55 2020 +0200 Force update-pciids to generate a non-compressed pci.ids database Closes: #970762 diff --git a/debian/changelog b/debian/changelog index 9f34d5a..501d0b0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -5,6 +5,8 @@ pciutils (1:3.7.0-4) UNRELEASED; urgency=medium * Update patches meta-information: - Add Forwarded meta-fields. - Switch a literal Debian bug URL into a Bug-Debian meta-field. + * Force update-pciids to generate a non-compressed pci.ids database. +Closes: #970762 -- Guillem Jover Wed, 23 Sep 2020 20:08:26 +0200
Processed: Bug#970762 in package pciutils marked as pending
Processing control commands: > tag 970762 pending Bug #970762 [pciutils] virt-manger fails to open vm console/info with: Error launching details: g-io-error-quark: Error opening file /usr/share/misc/pci.ids: No such file or directory Ignoring request to alter tags of bug #970762 to the same tags previously set -- 970762: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970762 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#970762: in package pciutils marked as pending
Hi! On Fri, 2020-09-25 at 20:44:54 +0200, Daniel Leidert wrote: > Control: reopen 970762 > > Am Mittwoch, den 23.09.2020, 03:13 +0200 schrieb Guillem Jover: > > --- > > commit c2c28549a513b93898d8c49f6eb8cefc1670a1e2 > > Author: Guillem Jover > > Date: Wed Sep 23 03:00:35 2020 +0200 > > > > Force the hardlink for the backup pci.ids database in update-pciids > > > > Closes: #970762, #970762 > > This patch only fixes the creation of the hardlink of pci.ids.gz.old -> > pci.ids.gz, which btw seems really odd to me (why do we need this link? > shouldn't .old be or at least link to the previous database?). The hardlink is used to make a backup, then the destination file gets replaced with the new database. > However /usr/share/misc/pci.ids is still deleted and breaks virt-manager. > > I was checking the script and it seems it fails somwhere at lines 52-60. If I > print out the commands it looks like this: Ugh, sorry completely missed this in the original report. :( I've checked the code, and it seems there are several wrong things, which I'll be fixing. First the PCI_IDS defaults to the compressed file, but the pci.ids.deb ships an uncompressed one. Then the script conflates the format that it downloads from, but does not cover what it should write it to. > Reopening report. Thanks, will fix this tomorrow. Regards, Guillem
Bug#970762: in package pciutils marked as pending
Control: reopen 970762 Am Mittwoch, den 23.09.2020, 03:13 +0200 schrieb Guillem Jover: [..] > --- > commit c2c28549a513b93898d8c49f6eb8cefc1670a1e2 > Author: Guillem Jover > Date: Wed Sep 23 03:00:35 2020 +0200 > > Force the hardlink for the backup pci.ids database in update-pciids > > Closes: #970762, #970762 This patch only fixes the creation of the hardlink of pci.ids.gz.old -> pci.ids.gz, which btw seems really odd to me (why do we need this link? shouldn't .old be or at least link to the previous database?). However /usr/share/misc/pci.ids is still deleted and breaks virt-manager. I was checking the script and it seems it fails somwhere at lines 52-60. If I print out the commands it looks like this: > + DECOMP=cat > + SRC=https://pci-ids.ucw.cz/v2.2/pci.ids.gz > + GREP=zgrep > + which curl > + DL=curl -o /usr/share/misc/pci.ids.gz.new > https://pci-ids.ucw.cz/v2.2/pci.ids.gz > + false > + curl -o /usr/share/misc/pci.ids.gz.new > https://pci-ids.ucw.cz/v2.2/pci.ids.gz > % Total% Received % Xferd Average Speed TimeTime Time > Current > Dload Upload Total SpentLeft Speed > 100 278k 100 278k0 0 814k 0 --:--:-- --:--:-- --:--:-- 814k > + cat > + > + zgrep ^C /usr/share/misc/pci.ids.gz.neww > sh: 0: getcwd() failed: No such file or directory > + [ -f /usr/share/misc/pci.ids.gz ] > + ln -f /usr/share/misc/pci.ids.gz /usr/share/misc/pci.ids.gz.old > + chmod -f --reference=/usr/share/misc/pci.ids.gz.old > /usr/share/misc/pci.ids.gz.neww > + mv /usr/share/misc/pci.ids.gz.neww /usr/share/misc/pci.ids.gz > + rm /usr/share/misc/pci.ids.gz.new > + [ /usr/share/misc/pci.ids != /usr/share/misc/pci.ids.gz ] > + rm -f /usr/share/misc/pci.ids /usr/share/misc/pci.ids.old > + false > + echo Done. Note the getcwd() failure. Reopening report. -- Regards, Daniel Leidert | https://www.wgdd.de/ GPG-Key RSA4096 / BEED4DED5544A4C03E283DC74BCD0567C296D05D GPG-Key ED25519 / BD3C132D8B3805D1808123AB7ACE00941E338C78 If you like my work consider sponsoring me via https://www.patreon.com/join/dleidert signature.asc Description: This is a digitally signed message part
Processed: Re: Bug#970762: in package pciutils marked as pending
Processing control commands:
> reopen 970762
Bug #970762 {Done: Guillem Jover } [pciutils] virt-manger
fails to open vm console/info with: Error launching details: g-io-error-quark:
Error opening file /usr/share/misc/pci.ids: No such file or directory
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions pciutils/1:3.7.0-3.
--
970762: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970762
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Processed: Bug#970762 in package pciutils marked as pending
Processing control commands:
> tag 970762 pending
Bug #970762 {Done: Guillem Jover } [pciutils] virt-manger
fails to open vm console/info with: Error launching details: g-io-error-quark:
Error opening file /usr/share/misc/pci.ids: No such file or directory
Added tag(s) pending.
--
970762: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970762
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#970762: in package pciutils marked as pending
Control: tag 970762 pending Hi! Bug #970762 in package pciutils reported by you has been fixed in the debian/pkgs/pciutils.git Git repository. You can see the changelog below, and you can check the diff of the fix at: https://git.hadrons.org/cgit/debian/pkgs/pciutils.git/diff/?id=c2c2854 --- commit c2c28549a513b93898d8c49f6eb8cefc1670a1e2 Author: Guillem Jover Date: Wed Sep 23 03:00:35 2020 +0200 Force the hardlink for the backup pci.ids database in update-pciids Closes: #970762, #970762 diff --git a/debian/changelog b/debian/changelog index f288704..56849fd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +pciutils (1:3.7.0-3) UNRELEASED; urgency=medium + + * Force the hardlink for the backup pci.ids database in update-pciids. +Closes: #970762, #970762 + + -- Guillem Jover Wed, 23 Sep 2020 02:58:44 +0200 + pciutils (1:3.7.0-2) unstable; urgency=medium * Fix build failure on Hurd, by taking a patch from upstream git.
