Bug#1066689: kdrill: FTBFS: init.c:171:12: error: implicit declaration of function ‘isMapped’; did you mean ‘IsUnmapped’? [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: kdrill
Followup-For: Bug #1066689
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch 
kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
--- kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
2024-04-10 15:56:58.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066689
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: kdrill-6.5deb2/init.c
+===
+--- kdrill-6.5deb2.orig/init.c
 kdrill-6.5deb2/init.c
+@@ -24,6 +24,7 @@
+ #include "searchwidgets.h"
+ #include "widgets.h"
+ #include "timeout.h"
++#include "utils.h"
+ 
+ #include "icon_xbm"
+ 
diff -Nru kdrill-6.5deb2/debian/patches/series 
kdrill-6.5deb2/debian/patches/series
--- kdrill-6.5deb2/debian/patches/series2021-10-20 10:11:20.0 
-0700
+++ kdrill-6.5deb2/debian/patches/series2024-04-10 15:55:23.0 
-0700
@@ -12,3 +12,4 @@
 use-env-flags.diff
 warning-fixes.diff
 rename-getline.diff
+no-implicit-declarations.patch


Bug#1066689: kdrill: FTBFS: init.c:171:12: error: implicit declaration of function ‘isMapped’; did you mean ‘IsUnmapped’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: kdrill
Version: 6.5deb2-13
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -c -g -O2 -fno-strict-aliasing   -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -I/usr/include/X11 -Dlinux 
> -D__amd64__ -D_POSIX_C_SOURCE=199309L
> -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE 
> -D_SVID_SOURCE -D_LARGEFILE_SOURCE 
> -D_FILE_OFFSET_BITS=64
>-DFUNCPROTO=15 -DNARROWPROTO  -Wdate-time -D_FORTIFY_SOURCE=2
> -DDICTLOCATION='"KDrill*kdictfile:/usr/share/edict/kanjidic"' 
> -DEDICTLOCATION='"KDrill*edictfile: /usr/share/edict/edict"' 
> -DRADLOCATION='"KDrill*radkfile:   /var/lib/xjdic/radkfile"'  init.c
> In file included from 
> /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
>  from /usr/include/stdlib.h:26,
>  from init.c:1:
> /usr/include/features.h:195:3: warning: #warning "_BSD_SOURCE and 
> _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
>   195 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use 
> _DEFAULT_SOURCE"
>   |   ^~~
> init.c: In function ‘handle_delete’:
> init.c:171:12: error: implicit declaration of function ‘isMapped’; did you 
> mean ‘IsUnmapped’? [-Werror=implicit-function-declaration]
>   171 | if(isMapped(w)){
>   |^~~~
>   |IsUnmapped
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:1140: init.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/kdrill_6.5deb2-13_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.