Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Hello! John Paul Adrian Glaubitz has written on Saturday, 5 January, at 21:10: I consider his proposal as the best solution for wheezy. May I NMU to unstable? Since no one has replied to your suggestion yet, I would suggest that you make an NMU and upload it into DELAYED/10 which will give the maintainers enough time for review. This bug is a serious issue and an RC bug and should therefore not be delayed too long. And remember that is not a solution but a workaround which breaks one of functions of pcmanfm and that breakage is another bug. Real fix will be upgrade to the 1.1.1 version which will be possible only after wheezy release (via backports). With best wishes. Andriy. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Hi Nicolas, I consider his proposal as the best solution for wheezy. May I NMU to unstable? Since no one has replied to your suggestion yet, I would suggest that you make an NMU and upload it into DELAYED/10 which will give the maintainers enough time for review. This bug is a serious issue and an RC bug and should therefore not be delayed too long. Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Followup-For: Bug #593607 Control: reassign -1 libfm 0.1.17-2 Control: affects -1 + pcmanfm Control: tags -1 + fixed On my computer, copying a huge directory to a small loop device... - triggers the bug with libfm-0.1.17-2 - does not anymore with the attached patch So Ulrik is right. I consider his proposal as the best solution for wheezy. May I NMU to unstable? diff -Nru libfm-0.1.17/debian/changelog libfm-0.1.17/debian/changelog --- libfm-0.1.17/debian/changelog 2012-04-16 22:32:23.0 +0200 +++ libfm-0.1.17/debian/changelog 2013-01-01 00:06:38.0 +0100 @@ -1,3 +1,13 @@ +libfm (0.1.17-2.1) UNRELEASED; urgency=low + + * Non-maintainer upload. + * patches/02-keep_source_when_copying.patch: keep source when +cut/pasting a directory across filesystems, avoiding data loss when +the copy fails. Next upstream really fixes #593607, but this +work-around downgrades its severity from critical to normal in wheezy. + + -- Nicolas Boulenguez nico...@debian.org Mon, 31 Dec 2012 23:36:03 +0100 + libfm (0.1.17-2) unstable; urgency=low * Updating maintainer field. diff -Nru libfm-0.1.17/debian/patches/02-keep_source_when_copying.patch libfm-0.1.17/debian/patches/02-keep_source_when_copying.patch --- libfm-0.1.17/debian/patches/02-keep_source_when_copying.patch 1970-01-01 01:00:00.0 +0100 +++ libfm-0.1.17/debian/patches/02-keep_source_when_copying.patch 2012-12-31 23:34:59.0 +0100 @@ -0,0 +1,15 @@ +diff --git a/src/job/fm-file-ops-job-xfer.c b/src/job/fm-file-ops-job-xfer.c +index 351ff1d..a46d9b9 100644 +--- a/src/job/fm-file-ops-job-xfer.c b/src/job/fm-file-ops-job-xfer.c +@@ -440,8 +440,8 @@ _retry_query_src_info: + } + /* if this is a cross-device move operation, delete source files. */ + /* ret == TRUE means the copy is successful. */ +-if( !fm_job_is_cancelled(fmjob) ret delete_src ) +-ret = _fm_file_ops_job_delete_file(FM_JOB(job), src, inf); /* delete the source file. */ ++/* if( !fm_job_is_cancelled(fmjob) ret delete_src ) */ ++/* ret = _fm_file_ops_job_delete_file(FM_JOB(job), src, inf); /\* delete the source file. *\/ */ + + if(new_dest) + g_object_unref(new_dest); diff -Nru libfm-0.1.17/debian/patches/series libfm-0.1.17/debian/patches/series --- libfm-0.1.17/debian/patches/series 2012-04-16 21:45:43.0 +0200 +++ libfm-0.1.17/debian/patches/series 2012-12-31 23:37:10.0 +0100 @@ -1 +1,2 @@ 01-lxde-conf.patch +02-keep_source_when_copying.patch
Bug#593607: bug #593607: pcmanfm wrongly deleted some files in a failed move operation
control: reopen -1 Why not to reopen this bug if it hasn't been fixed yet? ;)
Processed: Re: bug #593607: pcmanfm wrongly deleted some files in a failed move operation
Processing control commands:
reopen -1
Bug #593607 {Done: Andrew Lee ajq...@debian.org} [pcmanfm] pcmanfm wrongly
deleted some files in a failed move operation
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions pcmanfm/0.9.8-1.
--
593607: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593607
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: bug #593607: pcmanfm wrongly deleted some files in a failed move operation
Why not to reopen this bug if it hasn't been fixed yet? ;) In fact, it's fixed in upstream. The reporter confirmed it is fixed. And all commits for the fix are included in latest stable release of libfm and pcmanfm (1.1.0). If reopening this bug gives a possibility for 1.1.0 to come into Wheezy then why not? But I hardly doubt it is possible to gather all fixes for the subject and apply them on ancient libfm 0.1.17. If you ask me I would never try that, I don't know which side effects will that cause, because changing major number of upstream version sure was for reason, and the diff between 0.1.17 and 1.1.0 is near 4MB while unpacked libfm tarball takes near 7MB. May be it is still good for everyone to postpone fix to time after Wheezy release. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: bug #593607: pcmanfm wrongly deleted some files in a failed move operation
Processing commands for cont...@bugs.debian.org:
forwarded 593607
https://sourceforge.net/tracker/?func=detailaid=3565792group_id=156956atid=801864
Bug #593607 {Done: Andrew Lee ajq...@debian.org} [pcmanfm] pcmanfm wrongly
deleted some files in a failed move operation
Changed Bug forwarded-to-address to
'https://sourceforge.net/tracker/?func=detailaid=3565792group_id=156956atid=801864'
from
'https://sourceforge.net/tracker/?func=detailaid=3052037group_id=156956atid=801864'
thank you
Stopping processing here.
Please contact me if you need assistance.
--
593607: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593607
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: bug #593607: pcmanfm wrongly deleted some files in a failed move operation
forwarded 593607 https://sourceforge.net/tracker/?func=detailaid=3565792group_id=156956atid=801864 thank you This bug was a bit hard to reproduce as it didn't happen when moving just a bunch of files. It also happened when no space left on destination device. Fixed in upstream by commit f8441418b8c5087b266b60ed0bf02ee1645711f1 few moments ago. Thank you. -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
user release.debian@packages.debian.org tag 593607 squeeze-ignore usertag 593607 squeeze-can-defer kthxbye On Wed, Dec 29, 2010 at 11:39:16 +0800, Andrew Lee wrote: On 2010年12月29日 02:42, Julien Cristau wrote: On 12/06/2010 01:56 AM, Andrew Lee wrote: Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? Sorry but those have big changes. I'm not sure that it's wise to accept them at this stage of the freeze. I'd prefer targeted fixes. ping? If this doesn't get fixed very soon, we'll have to remove pcmanfm and lxde-common from squeeze, as far as I can tell. Actually, britney won't let me do that, since that would break the lxde desktop task. So tagging as can-defer, since I don't think it should be a blocker. I know 0.9.8 version have many changes. Cause upstream fixed this problem and many others. I'd suggest to accept 0.9.8 into squeeze, so that we can benifit from many other distros which are using 0.9.8 version too. If anything, the criteria now are stricter than they were when you were told no the first time. So this needs targetted fixes, I won't spend my time reviewing the full 0.9.8 diff. If there are other bugs you feel should be fixed at the same time, that can be considered, but on a case by case basis, not an all or nothing thing. Cheers, Julien signature.asc Description: Digital signature
Processed: Re: Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Processing commands for cont...@bugs.debian.org:
user release.debian@packages.debian.org
Setting user to release.debian@packages.debian.org (was
jcris...@debian.org).
tag 593607 squeeze-ignore
Bug #593607 {Done: Andrew Lee ajq...@debian.org} [pcmanfm] pcmanfm wrongly
deleted some files in a failed move operation
Added tag(s) squeeze-ignore.
usertag 593607 squeeze-can-defer
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
There were no usertags set.
Usertags are now: squeeze-can-defer.
kthxbye
Stopping processing here.
Please contact me if you need assistance.
--
593607: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593607
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On Thu, Dec 23, 2010 at 16:43:03 +0100, Julien Cristau wrote: On Mon, Dec 6, 2010 at 09:58:20 +0100, Mehdi Dogguy wrote: On 12/06/2010 01:56 AM, Andrew Lee wrote: Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? Sorry but those have big changes. I'm not sure that it's wise to accept them at this stage of the freeze. I'd prefer targeted fixes. ping? If this doesn't get fixed very soon, we'll have to remove pcmanfm and lxde-common from squeeze, as far as I can tell. Cheers, Julien signature.asc Description: Digital signature
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On 2010年12月29日 02:42, Julien Cristau wrote: On 12/06/2010 01:56 AM, Andrew Lee wrote: Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? Sorry but those have big changes. I'm not sure that it's wise to accept them at this stage of the freeze. I'd prefer targeted fixes. ping? If this doesn't get fixed very soon, we'll have to remove pcmanfm and lxde-common from squeeze, as far as I can tell. I know 0.9.8 version have many changes. Cause upstream fixed this problem and many others. I'd suggest to accept 0.9.8 into squeeze, so that we can benifit from many other distros which are using 0.9.8 version too. -Andrew -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On Mon, Dec 6, 2010 at 09:58:20 +0100, Mehdi Dogguy wrote: On 12/06/2010 01:56 AM, Andrew Lee wrote: Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? Sorry but those have big changes. I'm not sure that it's wise to accept them at this stage of the freeze. I'd prefer targeted fixes. ping? Cheers, Julien signature.asc Description: Digital signature
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On 12/06/2010 01:56 AM, Andrew Lee wrote: On 2010年12月06日 05:13, Mehdi Dogguy wrote: On 12/01/2010 10:21 AM, Alexander Reichle-Schmehl wrote: Am 01.12.2010 10:13, schrieb Andrew Lee: Thanks Alexander for the reminder. Since there is no response and we are in a freeze status. I assume this has been fixed, and close this bug now. Fine, fine. I also marked the current version in sid as not affected by this bug. Can you please ask the release team for an unblock? I'm not sure we could accept this version since it's a bit large and depends on a newer libfm, which is also large. Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? Sorry but those have big changes. I'm not sure that it's wise to accept them at this stage of the freeze. I'd prefer targeted fixes. Regards, -- Mehdi Dogguy مهدي الدڤي http://dogguy.org/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On 12/01/2010 10:21 AM, Alexander Reichle-Schmehl wrote: Am 01.12.2010 10:13, schrieb Andrew Lee: Thanks Alexander for the reminder. Since there is no response and we are in a freeze status. I assume this has been fixed, and close this bug now. Fine, fine. I also marked the current version in sid as not affected by this bug. Can you please ask the release team for an unblock? I'm not sure we could accept this version since it's a bit large and depends on a newer libfm, which is also large. The best plan seems to be to prepare a fixed version with minimal changes to upload via t-p-u. Regards, -- Mehdi Dogguy مهدي الدڤي http://dogguy.org/ -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
On 2010年12月06日 05:13, Mehdi Dogguy wrote: On 12/01/2010 10:21 AM, Alexander Reichle-Schmehl wrote: Am 01.12.2010 10:13, schrieb Andrew Lee: Thanks Alexander for the reminder. Since there is no response and we are in a freeze status. I assume this has been fixed, and close this bug now. Fine, fine. I also marked the current version in sid as not affected by this bug. Can you please ask the release team for an unblock? I'm not sure we could accept this version since it's a bit large and depends on a newer libfm, which is also large. Both newer version of libfm and pcmanfm are bug fixes release from upstream. Would this be an exception, please? -Andrew -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
fixed 593607 0.9.8-1 thanks Hi Andrew! Am 01.12.2010 10:13, schrieb Andrew Lee: Thanks Alexander for the reminder. Since there is no response and we are in a freeze status. I assume this has been fixed, and close this bug now. Fine, fine. I also marked the current version in sid as not affected by this bug. Can you please ask the release team for an unblock? Please feel free to reopen it if you can reproduct this problem still. Sorry, but I don't use pcmanfm myself; I'm just a rc bug hunter stumbling over this bug. Best regards, Alexander -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Processing commands for cont...@bugs.debian.org:
fixed 593607 0.9.8-1
Bug #593607 {Done: Andrew Lee ajq...@debian.org} [pcmanfm] pcmanfm wrongly
deleted some files in a failed move operation
Bug Marked as fixed in versions pcmanfm/0.9.8-1.
thanks
Stopping processing here.
Please contact me if you need assistance.
--
593607: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593607
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Hi maitainers! * Renaud Lacour ren...@home-dn.net [100819 17:57]: During a move operation, the hard drive of the destination filesystem encountered a power failure. Although not all relevant files were copied, pcmanfm deleted all of them! Could you please update the status of this bug? As you surely know it is release critical and we are in a freeze... I'm also a bit confussed, as upstream claiming on 2010-08-27 this bug would have been fixed, while the upload of a new upstream release 0.9.8-1 two month later didn't say anything about this bug... Best Regards, Alexander -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#593607: pcmanfm wrongly deleted some files in a failed move operation
Package: pcmanfm Version: 0.9.7-1 Severity: critical Tags: upstream Justification: causes serious data loss During a move operation, the hard drive of the destination filesystem encountered a power failure. Although not all relevant files were copied, pcmanfm deleted all of them! -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (101, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages pcmanfm depends on: ii libc6 2.11.2-2 Embedded GNU C Library: Shared lib ii libcairo2 1.8.10-5 The Cairo 2D vector graphics libra ii libfm-gtk00.1.12-1 file management support - GTK+ GUI ii libfm00.1.12-1 file management support - core lib ii libglib2.0-0 2.24.1-1 The GLib library of C routines ii libgtk2.0-0 2.20.1-1 The GTK+ graphical user interface ii libpango1.0-0 1.28.1-1 Layout and rendering of internatio ii libx11-6 2:1.3.3-3 X11 client-side library Versions of packages pcmanfm recommends: ii gnome-icon-theme 2.22.0-1 GNOME Desktop icon theme ii gvfs-backends 1.6.3-1userspace virtual filesystem - bac pn gvfs-fuse none (no description available) pcmanfm suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
