Bug#679966: New upstream release - was: Re: Bug#679966: ksh: cd ../name does not work
Hi Oliver, would you mind packaging the latest upstream release of ksh (version tagged as 2012-08-24) for unstable? I have uploaded a fixed version 93u+-1.2 for testing-proposed-updates and the current upstream release would fix the bug for the unstable version. I'd be happy to sponsor the upload. We could then finally close the bug both for Wheezy and Sid. Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
Hi,
I have looked at the upstream changes addressing the problem and I
have generated a patch which seems fix the problem completely:
glaubitz@z6:..debian/ksh-93u+ ksh -l
$ pwd
/home/glaubitz/debian/ksh-93u+
$ cd /etc
$ pwd
/etc
$ cd ..
$ pwd
/
$ cd /home/glaubitz/Videos
$ pwd
/home/glaubitz/Videos
$ cd ../Downloads
$ pwd
/home/glaubitz/Downloads
$ echo $KSH_VERSION
Version JM 93u+ 2012-02-29
$
I am attaching the debdiff which drops Jonathan's patch and adds my
new patch with the upstream changes in the last commit.
If you agree, I'll upload the fixed package for t-p-u.
Cheers,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
diff -ru ksh-93u+-1.1/debian/changelog ksh-93u+-1.2/debian/changelog
--- ksh-93u+-1.1/debian/changelog 2012-10-13 23:58:47.0 +0200
+++ ksh-93u+-1.2/debian/changelog 2013-01-02 18:41:55.256504333 +0100
@@ -1,3 +1,12 @@
+ksh (93u+-1.2) testing-proposed-updates; urgency=low
+
+ * Non-maintainer upload.
+ * Fix handling of cd ../../.. and similar using
+the upstream changes from ee4582a commit, drop previous patch
+by Jonathan Wiltshire j...@debian.org (Closes: #679966).
+
+ -- John Paul Adrian Glaubitz glaub...@physik.fu-berlin.de Wed, 02 Jan 2013 18:41:22 +0100
+
ksh (93u+-1.1) testing-proposed-updates; urgency=low
* Non-maintainer upload.
Only in ksh-93u+-1.1/debian/patches: cddotdot.patch
Only in ksh-93u+-1.2/debian/patches: fix-cd-builtin.patch
diff -ru ksh-93u+-1.1/debian/patches/series ksh-93u+-1.2/debian/patches/series
--- ksh-93u+-1.1/debian/patches/series 2012-10-13 23:54:37.0 +0200
+++ ksh-93u+-1.2/debian/patches/series 2013-01-02 18:34:31.359970762 +0100
@@ -2,4 +2,4 @@
cleanup-man-title.patch
no-rpath.patch
handle-removed-working-dir.patch
-cddotdot.patch
+fix-cd-builtin.patch
diff -ru ksh-93u+-1.1/.pc/applied-patches ksh-93u+-1.2/.pc/applied-patches
--- ksh-93u+-1.1/.pc/applied-patches 2013-01-02 18:53:45.594190269 +0100
+++ ksh-93u+-1.2/.pc/applied-patches 2013-01-02 18:34:31.367970552 +0100
@@ -2,4 +2,4 @@
cleanup-man-title.patch
no-rpath.patch
handle-removed-working-dir.patch
-cddotdot.patch
+fix-cd-builtin.patch
Only in ksh-93u+-1.1/.pc: cddotdot.patch
Only in ksh-93u+-1.2/.pc: fix-cd-builtin.patch
diff -ru ksh-93u+-1.1/src/cmd/ksh93/bltins/cd_pwd.c ksh-93u+-1.2/src/cmd/ksh93/bltins/cd_pwd.c
--- ksh-93u+-1.1/src/cmd/ksh93/bltins/cd_pwd.c 2013-01-02 18:53:45.0 +0100
+++ ksh-93u+-1.2/src/cmd/ksh93/bltins/cd_pwd.c 2013-01-02 18:34:31.0 +0100
@@ -112,23 +112,31 @@
if(*dir=='.')
{
/* test for pathname . ./ .. or ../ */
- if(*(dp=dir+1) == '.')
- dp++;
- if(*dp==0 || *dp=='/')
+ int n=0;
+ char *sp;
+ for(dp=dir; *dp=='.'; dp++)
{
- if((dp-dir)==2)
+ if(*++dp=='.' (*++dp=='/' || *dp==0))
+n++;
+ else if(*dp *dp!='/')
+break;
+ if(*dp==0)
+break;
+ }
+ if(n)
+ {
+ cdpath = 0;
+ sp = oldpwd + strlen(oldpwd);
+ while(n--)
{
-char *sp;
-sfputr(shp-strbuf,oldpwd,0);
-if(*dp)
- sfputr(shp-strbuf,dp+1,0);
-sp = sfstruse(shp-strbuf);
-*(dir=strrchr(sp,'/'))=0;
-if(*dp)
- strcpy(dir,dp);
-dir = (char*)sp;
+while(--sp oldpwd *sp!='/');
+if(sp==oldpwd)
+ break;
+
}
- cdpath = 0;
+ sfwrite(shp-strbuf,oldpwd,sp+1-oldpwd);
+ sfputr(shp-strbuf,dp,0);
+ dir = sfstruse(shp-strbuf);
}
}
rval = -1;
@@ -205,6 +213,8 @@
if(*dir != '/')
return(0);
nv_putval(opwdnod,oldpwd,NV_RDONLY);
+ if(oldpwd)
+ free(oldpwd);
flag = strlen(dir);
/* delete trailing '/' */
while(--flag0 dir[flag]=='/')
@@ -215,8 +225,6 @@
nv_scan(shp-track_tree,rehash,(void*)0,NV_TAGGED,NV_TAGGED);
path_newdir(shp,shp-pathlist);
path_newdir(shp,shp-cdpathlist);
- if(oldpwd)
- free(oldpwd);
return(0);
}
Description: fix-cd-builtin
This patch integrates the changes from the upstream commit
ee4582a which fixes the built-in cd command which caused
'cd ..' when the parent directory was the root directory.
.
ksh (93u+-1.2) testing-proposed-updates; urgency=low
.
* Non-maintainer upload.
* Fix handling of cd ../../.. and similar using
the upstream changes from ee4582a commit, drop previous patch
by Jonathan Wiltshire j...@debian.org (Closes: #679966).
Author: John Paul Adrian Glaubitz glaub...@physik.fu-berlin.de
Bug-Debian: http://bugs.debian.org/679966
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: vendor|upstream|other, url of original patch
Bug: url in upstream bugtracker
Bug-Debian: http://bugs.debian.org/bugnumber
Bug-Ubuntu: https://launchpad.net/bugs/bugnumber
Forwarded: no|not-needed|url proving that it has been forwarded
Reviewed-By: name and email
Bug#679966: ksh: cd ../name does not work
John Paul Adrian Glaubitz wrote: Works for me with version 93u+-1.1: Therefore marked as fixed in 93u+-1.1. Note that bug 691200 was merged in as a duplicate of this one and the example in the initial description for that bug is most definitely not fixed in 93u+-1.1. Issues with cd .. are wider than the example you tried and the bug remains unfixed in 93u+-1.1. Oliver -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
On Tue, Jan 01, 2013 at 09:48:15AM +0100, Oliver Kiddle wrote: John Paul Adrian Glaubitz wrote: Works for me with version 93u+-1.1: Therefore marked as fixed in 93u+-1.1. Note that bug 691200 was merged in as a duplicate of this one and the example in the initial description for that bug is most definitely not fixed in 93u+-1.1. Issues with cd .. are wider than the example you tried and the bug remains unfixed in 93u+-1.1. Then you should address the problem as the maintainer of ksh. Since it's grave bug, it's blocking the release of Debian Wheezy and should therefore addressed as soon as possible! The last action on this bug has been on October, 22nd even though the bug is considered to be grave. Please go ahead and fix it by cherry-picking the proper fix from the unstable version. Thank you! Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
Control: reopen -1 Control: retitle -1 ksh: cd builtin is broken in various ways Control: notfixed -1 93u+-1.1 Control: notfixed -1 93u+20120628-1 On Tue, Jan 01, 2013 at 01:14:21PM +0100, John Paul Adrian Glaubitz wrote: On Tue, Jan 01, 2013 at 09:48:15AM +0100, Oliver Kiddle wrote: John Paul Adrian Glaubitz wrote: Works for me with version 93u+-1.1: Therefore marked as fixed in 93u+-1.1. Note that bug 691200 was merged in as a duplicate of this one and the example in the initial description for that bug is most definitely not fixed in 93u+-1.1. Issues with cd .. are wider than the example you tried and the bug remains unfixed in 93u+-1.1. ...so you should reopen the bug to reflect this. Then you should address the problem as the maintainer of ksh. Since it's grave bug, it's blocking the release of Debian Wheezy and should therefore addressed as soon as possible! The last action on this bug has been on October, 22nd even though the bug is considered to be grave. Please go ahead and fix it by cherry-picking the proper fix from the unstable version. See the discussion on #687799; a proper fix for this bug is too large or complicated or something. Maintainer: please follow up on your mail of 23rd October [1] where you intended to upload the Squeeze version of this package to Wheezy, or request removal. If there is no change in a reasonable time I will file an RM bug myself. Thank you! Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 1: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687779#42 -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 directhex i have six years of solaris sysadmin experience, from 8-10. i am well qualified to say it is made from bonghits layered on top of bonghits signature.asc Description: Digital signature
Processed: Re: Bug#679966: ksh: cd ../name does not work
Processing control commands:
reopen -1
Bug #679966 {Done: Jonathan Wiltshire j...@debian.org} [ksh] ksh: cd ../name
does not work
Bug #691200 {Done: Jonathan Wiltshire j...@debian.org} [ksh] ksh: cd ..
doesn't work in many cases
'reopen' may be inappropriate when a bug has been closed with a version;
all fixed versions will be cleared, and you may need to re-add them.
Bug reopened
No longer marked as fixed in versions ksh/93u+20120628-1 and ksh/93u+-1.1.
No longer marked as fixed in versions ksh/93u+20120628-1 and ksh/93u+-1.1.
retitle -1 ksh: cd builtin is broken in various ways
Bug #679966 [ksh] ksh: cd ../name does not work
Bug #691200 [ksh] ksh: cd .. doesn't work in many cases
Changed Bug title to 'ksh: cd builtin is broken in various ways' from 'ksh: cd
../name does not work'
Changed Bug title to 'ksh: cd builtin is broken in various ways' from 'ksh: cd
.. doesn't work in many cases'
notfixed -1 93u+-1.1
Bug #679966 [ksh] ksh: cd builtin is broken in various ways
Bug #691200 [ksh] ksh: cd builtin is broken in various ways
Ignoring request to alter fixed versions of bug #679966 to the same values
previously set
Ignoring request to alter fixed versions of bug #691200 to the same values
previously set
notfixed -1 93u+20120628-1
Bug #679966 [ksh] ksh: cd builtin is broken in various ways
Bug #691200 [ksh] ksh: cd builtin is broken in various ways
Ignoring request to alter fixed versions of bug #679966 to the same values
previously set
Ignoring request to alter fixed versions of bug #691200 to the same values
previously set
--
679966: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679966
691200: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691200
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
John Paul Adrian Glaubitz wrote: Then you should address the problem as the maintainer of ksh. Since it's grave bug, it's blocking the release of Debian Wheezy and should therefore addressed as soon as possible! The package has been up for adoption for some time because I don't have the time or interest to deal with this issue. Fixing it properly without either introducing new bugs or missing parts of the original bug is not trivial for me. Oliver -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
On Tue, Jan 01, 2013 at 11:18:10PM +0100, Oliver Kiddle wrote: John Paul Adrian Glaubitz wrote: Then you should address the problem as the maintainer of ksh. Since it's grave bug, it's blocking the release of Debian Wheezy and should therefore addressed as soon as possible! The package has been up for adoption for some time because I don't have the time or interest to deal with this issue. Fixing it properly without either introducing new bugs or missing parts of the original bug is not trivial for me. So what is your plan? An RFA does not absolve you of the responsibility to deal with this bug, either by fix or removal from testing. -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 directhex i have six years of solaris sysadmin experience, from 8-10. i am well qualified to say it is made from bonghits layered on top of bonghits signature.asc Description: Digital signature
Bug#679966: ksh: cd ../name does not work
Package: ksh Followup-For: Bug #679966 Works for me with version 93u+-1.1: $ pwd /home/glaubitz $ cd name2 $ cd ../name $ pwd /home/glaubitz/name $ echo $KSH_VERSION Version JM 93u+ 2012-02-29 $ Therefore marked as fixed in 93u+-1.1. Cheers, Adrian -- System Information: Debian Release: 7.0 APT prefers testing APT policy: (500, 'testing'), (100, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.6-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages ksh depends on: ii libc6 2.16-0experimental1 ksh recommends no packages. ksh suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679966: ksh: cd ../name does not work
Package: ksh Version: 93u+-1 Justification: renders package unusable Severity: grave Dear Maintainer, I've done this: sirius ~MOD/wmesa % ksh -c 'pwd; (cd ../alias; pwd); (cd ./../alias; pwd)' /home/hzoli/dev/wmesa /home/hzoli/dev /home/hzoli/dev/alias sirius ~MOD/wmesa % ksh --version version sh (ATT Research) 93u+ 2012-02-29 Notive that cd ../alias does not work, but cd ./../alias does. Setting CDPATH does not work. This used to work with the previous version, ksh-93u. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.4-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Versions of packages ksh depends on: ii libc6 2.13-34 ksh recommends no packages. ksh suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
