Bug#853599: [Debian-med-packaging] Bug#853599: opensurgsim: ftbfs with GCC-7
On Wed, Dec 6, 2017, at 11:28 AM, Andreas Tille wrote: > On Wed, Dec 06, 2017 at 04:51:17PM +0100, Fabian Klötzl wrote: > > // TODO(bert): There is some Eigen flag that causes matrices and > > vectors> > to be > > // initialized after all! We should check for that here. > > > > So I am guessing that the authors knew that their test was flaky and> > > > thus we should be save deactivating them. If you agree, I will go > > ahead.> > Sounds sensible - so I agree. :-) > > An information to upstream that we skip the test and by doing so > informing them that it really causes problems in a practical > application> would complete the work on the bug. > > Kind regards > > Andreas. > > -- > http://fam-tille.de > Sorry again for not looking at this. These tests appear to be from the Unit Tests that test Eigen and not really opensurgsim. I think they can all be safely disabled, since we can trust that Eigen works. These failures are mostly floating point errors. So yes Fabian, please go ahead and disable them. If you want to just disable them all, I think if you set BUILD_TESTING_EIGEN to OFF on line 29 in Debian/rules, you should solve this and other future issues.
Bug#853599: [Debian-med-packaging] Bug#853599: opensurgsim: ftbfs with GCC-7
On Wed, Dec 06, 2017 at 04:51:17PM +0100, Fabian Klötzl wrote: > // TODO(bert): There is some Eigen flag that causes matrices and vectors > to be > // initialized after all! We should check for that here. > > So I am guessing that the authors knew that their test was flaky and > thus we should be save deactivating them. If you agree, I will go ahead. Sounds sensible - so I agree. :-) An information to upstream that we skip the test and by doing so informing them that it really causes problems in a practical application would complete the work on the bug. Kind regards Andreas. -- http://fam-tille.de
Bug#853599: [Debian-med-packaging] Bug#853599: opensurgsim: ftbfs with GCC-7
Hi, Above one of the failing tests is a peculiar comment: // TODO(bert): There is some Eigen flag that causes matrices and vectors to be // initialized after all! We should check for that here. So I am guessing that the authors knew that their test was flaky and thus we should be save deactivating them. If you agree, I will go ahead. Best, Fabian