Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Funny. It seems we worked on this bug at the same time. I can confirm that [2] resolved the FTBFS with GCC 7. Looks like it. :) Thanks for uploading the patch and the other packaging changes. (I've already picked it up and integrated it into the packaging we do upstream for our PPA [1]) I've also added a short description and pointing to the backported patch in the original GCC7-merge proposal for others who may come across it. I suggest to add a simple patch to bug reports next time which tremendously simplifies things for non-regular uploaders of Widelands. Yes, I considered adding a patch. The main reason I didn't is that I use quilt too seldom to really remember how it works from time to time. So I would need to look up the commands, which is not neccessarily hard, but takes time and I knew I would be busy the following days. Since I didn't know when I'd have the time to prepare a proper patch, I figuered I could at least point to the existing patch, so that no one would need to add GCC7 support from scratch. If it hadn't been picked up, I would have prepared a patch when I got the time, but it seemed quicker to add a link and let someone who knew the toolchain integrate it. If I find the time, there will be a proper patch next time ;) [1] https://code.launchpad.net/~hjd/widelands/debian-merge/+merge/329686 --- mvh / best regards Hans Joachim Desserud http://desserud.org
Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Control: tags -1 pending Am 23.08.2017 um 21:56 schrieb Hans Joachim Desserud: > Control: tags -1 confirmed > Control: forwarded -1 https://bugs.launchpad.net/widelands/+bug/1695879 > > Hello > > We ran into the same issue upstream a while back when attempting to > build with GCC7, > see [1] for details. The issue was fixed, and since we expected distros > would switch to GCC7 > as the default compiler at some point the changes was also backported to > our build19 branch. > You can find the specific patch at [2] or [3] for the whole branch. > (Note that the branch > also includes a fix for the wrong en_GB translations [4], so you might > want to include that at > the same time) > > Hope this helps. Let us know if you have any comments or questions. :) > > [1] https://bugs.launchpad.net/widelands/+bug/1695879 > [2] http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149 > [3] https://code.launchpad.net/~widelands-dev/widelands/b19 > [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853052 Funny. It seems we worked on this bug at the same time. I can confirm that [2] resolved the FTBFS with GCC 7. However it was not clear to me how [3] could fix [4]. I suggest to add a simple patch to bug reports next time which tremendously simplifies things for non-regular uploaders of Widelands. Anyway I believe this bug should be fixed in a couple of minutes. Thank you for your assistance. Regards, Markus signature.asc Description: OpenPGP digital signature
Processed: Re: Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Processing control commands: > tags -1 pending Bug #871114 [src:widelands] widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized] Added tag(s) pending. -- 871114: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871114 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Hi Hans Joachim, it appears you are involved in upstream development for Widelands. The game currently fails to build from source with GCC 7. I discovered this [1] merge commit which shall resolve GCC 7 issues but unfortunately it doesn't apply cleanly for the recent 1.19 release of Widelands. Do you know if a targeted fix for 1.19 exists already or are there any plans to release a new version of Widelands to resolve this issue? Thanks, Markus [1] https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576 signature.asc Description: OpenPGP digital signature
Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Control: tags -1 confirmed Control: forwarded -1 https://bugs.launchpad.net/widelands/+bug/1695879 Hello We ran into the same issue upstream a while back when attempting to build with GCC7, see [1] for details. The issue was fixed, and since we expected distros would switch to GCC7 as the default compiler at some point the changes was also backported to our build19 branch. You can find the specific patch at [2] or [3] for the whole branch. (Note that the branch also includes a fix for the wrong en_GB translations [4], so you might want to include that at the same time) Hope this helps. Let us know if you have any comments or questions. :) [1] https://bugs.launchpad.net/widelands/+bug/1695879 [2] http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149 [3] https://code.launchpad.net/~widelands-dev/widelands/b19 [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853052 -- mvh / best regards Hans Joachim Desserud http://desserud.org
Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Source: widelands Version: 1:19+repack-3 Severity: serious Tags: buster sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20170805 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > cd /<>/widelands-19+repack/obj-x86_64-linux-gnu/src/network && > /usr/bin/c++ -I/<>/widelands-19+repack/src > -I/<>/widelands-19+repack/obj-x86_64-linux-gnu/src -isystem > /usr/include/SDL2 -isystem /usr/include/minizip -isystem /usr/include/GL -g > -O2 -fdebug-prefix-map=/<>/widelands-19+repack=. > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG > -std=c++11 -fext-numeric-literals -g -O3 -DNDEBUG -DNOPARACHUTE -Wall > -Wpedantic -Wdeprecated-declarations -Wextra -Wformat -Wformat-nonliteral > -Wformat-security -Wformat-y2k -Winit-self -Winvalid-pch -Wlogical-op > -Wmissing-include-dirs -Wno-undef -Wold-style-cast -Woverlength-strings > -Wpacked -Wpointer-arith -Wredundant-decls -Wsign-promo -Wsync-nand > -Wtrampolines -Wundef -Wunused -Wunused-macros -Werror=format-security > -Werror=return-type -Werror=shadow -Werror=uninitialized -o > CMakeFiles/network.dir/network_player_settings_backend.cc.o -c > /<>/widelands-19+repack/src/network/network_player_settings_backend.cc > In file included from > /<>/widelands-19+repack/src/network/network.h:29:0, > from > /<>/widelands-19+repack/src/network/network.cc:20: > /<>/widelands-19+repack/src/network/network.h: In member function > 'virtual const char* ProtocolException::what() const': > /<>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw > will always call terminate() [-Wterminate] > #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code > was reached.") > > ^ > /<>/widelands-19+repack/src/network/network.h:184:3: note: in > expansion of macro 'NEVER_HERE' >NEVER_HERE(); >^~ > In file included from > /<>/widelands-19+repack/src/network/network.h:29:0, > from > /<>/widelands-19+repack/src/network/internet_gaming.h:34, > from > /<>/widelands-19+repack/src/network/internet_gaming.cc:20: > /<>/widelands-19+repack/src/network/network.h: In member function > 'virtual const char* ProtocolException::what() const': > /<>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw > will always call terminate() [-Wterminate] > #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code > was reached.") > > ^ > /<>/widelands-19+repack/src/network/network.h:184:3: note: in > expansion of macro 'NEVER_HERE' >NEVER_HERE(); >^~ > In file included from > /<>/widelands-19+repack/src/scripting/lua_errors.h:25:0, > from > /<>/widelands-19+repack/src/scripting/lua_table.h:32, > from > /<>/widelands-19+repack/src/logic/map_objects/tribes/tribe_basic_info.h:29, > from > /<>/widelands-19+repack/src/logic/game_settings.h:28, > from > /<>/widelands-19+repack/src/network/nethost.h:24, > from > /<>/widelands-19+repack/src/network/nethost.cc:20: > /<>/widelands-19+repack/src/network/network.h: In member function > 'virtual const char* ProtocolException::what() const': > /<>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw > will always call terminate() [-Wterminate] > #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code > was reached.") > > ^ > /<>/widelands-19+repack/src/network/network.h:184:3: note: in > expansion of macro 'NEVER_HERE' >NEVER_HERE(); >^~ > In file included from > /<>/widelands-19+repack/src/scripting/lua_errors.h:25:0, > from > /<>/widelands-19+repack/src/scripting/lua_table.h:32, > from > /<>/widelands-19+repack/src/logic/map_objects/tribes/tribe_basic_info.h:29, > from > /<>/widelands-19+repack/src/logic/game_settings.h:28, > from > /<>/widelands-19+repack/src/network/netclient.h:25, > from > /<>/widelands-19+repack/src/network/netclient.cc:20: > /<>/widelands-19+repack/src/network/network.h: In member function > 'virtual const char* ProtocolException::what() const': > /<>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw > will always call terminate() [-Wterminate] > #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code > was reached.") > > ^ >
