Bug#883698: freetype: incorrect shlibs file generation

[Hugh McMaster]

Hi Cyril,

On Thursday, 21 December 2017 11:53 PM, Cyril Brulebois wrote:
> Yeah, that would look good to me, provided there's nothing added in a
> x.y.z version that would make the udeb depend on x.y (in the metadata
> section) while it actually depends on a feature introduced in a x.y.z
> (on a shared object level).

This shouldn't happen, since freetype uses x.y.z as major.minor.patch.
So a release incrementing z should only fix bugs, not alter the API.

> FWIW dh_makeshlibs supports being called with a -V option. Excerpt of
> its manpage:
> [snip]
> That might be a safer approach?

Yes, but it is conservative, perhaps. 'dh_makeshlibs -V' then depends on 2.8.1.
Given what we know about freetype's versioning, this doesn't seem necessary IMO.

On another note, I was wondering if using 'cut' is simpler than 'sed'?
$(shell echo "$(ver)" | cut -f-2 -d'.')

Thanks,
Hugh

Bug#883698: freetype: incorrect shlibs file generation

[Cyril Brulebois]

Hi Hugh,

Hugh McMaster  (2017-12-21):
> Assuming I understand the problem correctly, the attached patch should help.
> 
> After compiling and installing, I have the following in
> /var/lib/dpkg/info/libfreetype6:amd64.shlibs:
> 
> libfreetype 6 libfreetype6 (>= 2.8)
> udeb: libfreetype 6 libfreetype6-udeb (>= 2.8)

Yeah, that would look good to me, provided there's nothing added in a
x.y.z version that would make the udeb depend on x.y (in the metadata
section) while it actually depends on a feature introduced in a x.y.z
(on a shared object level).

FWIW dh_makeshlibs supports being called with a -V option. Excerpt of
its manpage:
| If -V is specified with no dependency information, the current upstream
| version of the package is plugged into a dependency that looks like
| "packagename (>= packageversion)". Note that in debhelper compatibility
| levels before v4, the Debian part of the package version number is also
| included. If -V is specified with parameters, the parameters can be
| used to specify the exact dependency information needed (be sure to
| include the package name).

That might be a safer approach?


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#883698: freetype: incorrect shlibs file generation

[Hugh McMaster]

Hi Cyril,

Assuming I understand the problem correctly, the attached patch should help.

After compiling and installing, I have the following in
/var/lib/dpkg/info/libfreetype6:amd64.shlibs:

libfreetype 6 libfreetype6 (>= 2.8)
udeb: libfreetype 6 libfreetype6-udeb (>= 2.8)

Hope this helps.

Hugh


freetype2-shlibs.patch
Description: freetype2-shlibs.patch

Bug#883698: freetype: incorrect shlibs file generation

[Cyril Brulebois]

Source: freetype
Version: 2.8.1-0.1
Severity: serious

(Please keep debian-b...@lists.debian.org in copy of your replies.)

Hi,

While preparing the release announcement for Buster Alpha 2, I've
stumbled upon the symbols addition in your last upload. Checking the
dependency for the udeb, it seems to be stuck at 2.6, while it should be
at the maximum version (udebs don't use symbols files):
| libfreetype 6 libfreetype6 (>= 2.6)
| udeb: libfreetype 6 libfreetype6-udeb (>= 2.6)

This is due to:
| dependency = $(libpkg) (>= 2.6)
| […]
| override_dh_makeshlibs:
| dh_makeshlibs -V '$(dependency)' --add-udeb '$(udebpkg)'


KiBi.