Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-09 Thread Nicholas D Steeves 
Hi Sandro,

On Thu, Feb 08, 2018 at 10:47:08PM -0500, Sandro Tosi wrote:
> Hello Nicholas,
> 
> On Tue, Feb 6, 2018 at 10:15 PM, Nicholas D Steeves  
> wrote:
> >
> > Hi Sandro,
> >
> > Would you like a patch for current_version-new_revision or for
> > new_upstream_version-1?  I assumed the latter, and send two patches
> > also assuming that you'd squash them.  Of course I'd be happy to
> > squash them myself and rewrite the messages.  Whatever you prefer :-)
> 
> i would prefer a single patch for current_version-new_revision (small
> upload to fix the issue) - i'll then prepare a new upstream release
> soon after.
> 
> Thanks,
> -- 
> Sandro "morph" Tosi
> My website: http://sandrotosi.me/
> Me at Debian: http://wiki.debian.org/SandroTosi
> G+: https://plus.google.com/u/0/+SandroTosi

Patch is attached.  It would be nice for the -dbg packages to be
symlinks to their respective packages, which would be safe because the
-dbg packages depend on the non-dbg ones...but I couldn't figure out
an easy way to handle both stretch2buster and
buster_intermediary_version2buster_release, other than switching to
dbgsym.

Cheers,
Nicholas
From 50b123c8912bb10d3f5906676d9951a7db36e5c4 Mon Sep 17 00:00:00 2001
From: Nicholas D Steeves 
Date: Tue, 6 Feb 2018 15:43:34 -0500
Subject: [PATCH] Correct errors in maintscripts. (Closes: #886944)

---
 debian/python-regex-dbg.maintscript  | 2 +-
 debian/python3-regex-dbg.maintscript | 2 +-
 debian/python3-regex.maintscript | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/python-regex-dbg.maintscript b/debian/python-regex-dbg.maintscript
index 06d5276..98054e4 100644
--- a/debian/python-regex-dbg.maintscript
+++ b/debian/python-regex-dbg.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python-regex-dbg python-regex-dbg 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python-regex-dbg python-regex 0.1.20171212-2~
diff --git a/debian/python3-regex-dbg.maintscript b/debian/python3-regex-dbg.maintscript
index cb7b44f..3316dc3 100644
--- a/debian/python3-regex-dbg.maintscript
+++ b/debian/python3-regex-dbg.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python3-regex-dbg python3-regex-dbg 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python3-regex-dbg python-regex 0.1.20171212-2~
diff --git a/debian/python3-regex.maintscript b/debian/python3-regex.maintscript
index 899180d..e99ccd2 100644
--- a/debian/python3-regex.maintscript
+++ b/debian/python3-regex.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python3-regex python3-regex 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python3-regex python-regex 0.1.20171212-2~
-- 
2.11.0



signature.asc
Description: PGP signature

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-08 Thread Sandro Tosi 
Hello Nicholas,

On Tue, Feb 6, 2018 at 10:15 PM, Nicholas D Steeves  wrote:
>
> Hi Sandro,
>
> Would you like a patch for current_version-new_revision or for
> new_upstream_version-1?  I assumed the latter, and send two patches
> also assuming that you'd squash them.  Of course I'd be happy to
> squash them myself and rewrite the messages.  Whatever you prefer :-)

i would prefer a single patch for current_version-new_revision (small
upload to fix the issue) - i'll then prepare a new upstream release
soon after.

Thanks,
-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Nicholas D Steeves 
Hi Sandro,

Would you like a patch for current_version-new_revision or for
new_upstream_version-1?  I assumed the latter, and send two patches
also assuming that you'd squash them.  Of course I'd be happy to
squash them myself and rewrite the messages.  Whatever you prefer :-)

Hi Andreas,

On Wed, Feb 07, 2018 at 12:50:05AM +0100, Andreas Beckmann wrote:
> On 2018-02-06 23:01, Nicholas D Steeves wrote:
> > On Tue, Feb 06, 2018 at 04:02:07PM -0500, Sandro Tosi wrote:
> >>patch is welcome, NMU is not; feel free to upload the patch to this bug
> >>and i'll take care of the upload. thanks for working on this Debian bug
> > 
> > That's fair.  The main thing I'd like to avoid is the autoremoval of
> > rdepending packages ;-)
> 
> You already reset the timer by keeping the discussion in this bug alive ;-)

That's a relief!

> > I pushed to the following remote and have also
> > attached the patches (see commit messages for more info):
> > https://salsa.debian.org/sten-guest/python-regex.git
> 
> Assuming the next upload will be versioned 0.1.20171212-2, the version
> in the .maintscript files needs to be 0.1.20171212-2~, i.e. you want
> ""+"~".
> That version will also be OK if a new upstream release comes with the
> fix, but not for a NMU (that would be versioned 0.1.20171212-1.1 and you
> would need to use 0.1.20171212-1.1~ in that case).

Touché.  I originally tested new upstream version, then reworked it
for a minimal NMU, then reworked the commits into what I hoped would
potentially be useful to someone who happened to wonder how to fix a
similar bug.

> You should squash the two patches, the separation just causes
> confusion.

I'll do this (if necessary) as soon as I hear back from Sandro about
his preference.  Ah, yes, and now I see how it would have been best to use
0.1.20171212-2~ in the first patch.

> There is no need to bump the version in the .maintscript files for
> further uploads to buster (unless you need more bugfixes to the d-m-h
> calls) (or unless you are uploading new upstream releases to stretch).
> There are only two cases while upgrading: upgrading from a version
> without the fix (e.g. stretch or 0.1.20171212-1) or a version with the
> fix (in that case the migration can be skipped)

Thank you for clearing this up, I might be inductively challenged
haha!  Might you be willing to add something to this effect to
dpkg-maintscript-helper(1)?

> regarding the commit message:
> 
> >Maintscripts had:
> > symlink_to_dir pathname new-target
> 
> There is no such thing as a "new-target" for symlink_to_dir.
> I think the maintscripts had "symlink_to_dir pathname current-package".

Yes d-m-h(1) has
symlink_to_dir /path/name old-target [prior-version [package]]

It took longer than I'd like to admit to realise that symlink_to_dir
functions like this.  eg, for /path/name

cd /path
ln -s name symlink-name (aka: new-target)

corresponds to

dir_to_symlink /path/name symlink-name

which is reversed with

symlink_to_dir /path/name symlink-name (aka: old-target)
  |
where this is not the new_dir_name  <-|

For some reason I kept seeing

symlink_to_dir /existing/symlink-name new_dir_name

> PS: I would likely have sponsored a delayed NMU, after several rounds of
> revision  ;-)

Thank you for your support :-) On the topic of rounds of revision,
because a package-dbg depends on package ${binary:Version}, should all
package-dbgs do this:

dir_to_symlink /path/package-dbg package ?

similarly to how automatic -dbgsym packages are handled?  If so, I
think my patch can be improved by adding this operation to each of the
-dbg.maintscripts.


Regards,
Nicholas


signature.asc
Description: PGP signature

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Andreas Beckmann 
On 2018-02-06 23:01, Nicholas D Steeves wrote:
> On Tue, Feb 06, 2018 at 04:02:07PM -0500, Sandro Tosi wrote:
>>patch is welcome, NMU is not; feel free to upload the patch to this bug
>>and i'll take care of the upload. thanks for working on this Debian bug
> 
> That's fair.  The main thing I'd like to avoid is the autoremoval of
> rdepending packages ;-)

You already reset the timer by keeping the discussion in this bug alive ;-)

> I pushed to the following remote and have also
> attached the patches (see commit messages for more info):
> https://salsa.debian.org/sten-guest/python-regex.git

Assuming the next upload will be versioned 0.1.20171212-2, the version
in the .maintscript files needs to be 0.1.20171212-2~, i.e. you want
""+"~".
That version will also be OK if a new upstream release comes with the
fix, but not for a NMU (that would be versioned 0.1.20171212-1.1 and you
would need to use 0.1.20171212-1.1~ in that case).

There is no need to bump the version in the .maintscript files for
further uploads to buster (unless you need more bugfixes to the d-m-h
calls) (or unless you are uploading new upstream releases to stretch).
There are only two cases while upgrading: upgrading from a version
without the fix (e.g. stretch or 0.1.20171212-1) or a version with the
fix (in that case the migration can be skipped)

You should squash the two patches, the separation just causes confusion.

regarding the commit message:

>Maintscripts had:
> symlink_to_dir pathname new-target

There is no such thing as a "new-target" for symlink_to_dir.
I think the maintscripts had "symlink_to_dir pathname current-package".


Andreas

PS: I would likely have sponsored a delayed NMU, after several rounds of
revision  ;-)

Processed: Re: Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Debian Bug Tracking System 
Processing control commands:

> tags -1 patch
Bug #886944 [python3-regex] python3-regex: unhandled symlink to directory 
conversion: /usr/share/doc/PACKAGE
Added tag(s) patch.

-- 
886944: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886944
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Nicholas D Steeves 
Control: tags -1 patch

Hi Sandro,

On Tue, Feb 06, 2018 at 04:02:07PM -0500, Sandro Tosi wrote:
>patch is welcome, NMU is not; feel free to upload the patch to this bug
>and i'll take care of the upload. thanks for working on this Debian bug

That's fair.  The main thing I'd like to avoid is the autoremoval of
rdepending packages ;-) I pushed to the following remote and have also
attached the patches (see commit messages for more info):
https://salsa.debian.org/sten-guest/python-regex.git

Cheers,
Nicholas

>On Tue, Feb 6, 2018 at 3:54 PM, Nicholas D Steeves 
>wrote:
> 
>  Hi Andreas,
>  On Mon, Feb 05, 2018 at 06:32:35PM -0500, Nicholas D Steeves wrote:
>  > Hi Andreas and Sandro,
>  >
>  > On Thu, Jan 11, 2018 at 05:04:13PM +0100, Andreas Beckmann wrote:
>  > > Followup-For: Bug #886944
>  > > Control: affects -1 + python-regex-dbg
>  > >
>  > > Hi,
>  > >
>  > > similar issue in python-regex-dbg:
>  > >
>  > > 0m33.5s ERROR: FAIL: silently overwrites files via directory
>  symlinks:
>  > >   /usr/share/doc/python-regex-dbg/Features.html (python-regex-dbg)
>  != /usr/share/doc/python-regex/Features.html (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >   /usr/share/doc/python-regex-dbg/Features.rst.gz
>  (python-regex-dbg) != /usr/share/doc/python-regex/Features.rst.gz
>  (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >   /usr/share/doc/python-regex-dbg/README (python-regex-dbg) !=
>  /usr/share/doc/python-regex/README (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >   /usr/share/doc/python-regex-dbg/UnicodeProperties.txt.gz
>  (python-regex-dbg) !=
>  /usr/share/doc/python-regex/UnicodeProperties.txt.gz (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >   /usr/share/doc/python-regex-dbg/changelog.Debian.gz
>  (python-regex-dbg) != /usr/share/doc/python-regex/changelog.Debian.gz
>  (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >   /usr/share/doc/python-regex-dbg/copyright (python-regex-dbg) !=
>  /usr/share/doc/python-regex/copyright (python-regex)
>  > >     /usr/share/doc/python-regex-dbg -> python-regex
>  > >
>  > > and probably python3-regex-dbg as well, although that does not get
>  > > tested by piuparts as long as python3-regex fails.
>  > >
>  > >
>  > > Andreas
>  >
>  > I'll attempt to fix this evening, because if calibre is removed from
>  > testing than my planned backport will be in jeopardy.  If I succeed
>  > I'll prepare an NMU, but in any case I'll reply to this bug with my
>  > results.
>  >
>  > Cheers,
>  > Nicholas
> 
>  Solved it!  I'll prepare a minimal NMU later today.  Would you please
>  consider sponsoring the upload (I'll CC you for the RFS)?
> 
>  Regards,
>  Nicholas
> 
>--
>Sandro "morph" Tosi
>My website: http://sandrotosi.me/
>Me at Debian: http://wiki.debian.org/SandroTosi
>G+: https://plus.google.com/u/0/+SandroTosi
From d7bcc37b3f9361413495e181159b4d9db317d524 Mon Sep 17 00:00:00 2001
From: Nicholas D Steeves 
Date: Tue, 6 Feb 2018 15:43:34 -0500
Subject: [PATCH 1/2] Correct errors in maintscripts. (Closes: #886944)

From dpkg-maintscript-helper(1):
 symlink_to_dir pathname old-target

Maintscripts had:
 symlink_to_dir pathname new-target
---
 debian/python-regex-dbg.maintscript  | 2 +-
 debian/python3-regex-dbg.maintscript | 2 +-
 debian/python3-regex.maintscript | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/python-regex-dbg.maintscript b/debian/python-regex-dbg.maintscript
index 06d5276..f3c7bd1 100644
--- a/debian/python-regex-dbg.maintscript
+++ b/debian/python-regex-dbg.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python-regex-dbg python-regex-dbg 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python-regex-dbg python-regex 0.1.20171212-1~
diff --git a/debian/python3-regex-dbg.maintscript b/debian/python3-regex-dbg.maintscript
index cb7b44f..62674c9 100644
--- a/debian/python3-regex-dbg.maintscript
+++ b/debian/python3-regex-dbg.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python3-regex-dbg python3-regex-dbg 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python3-regex-dbg python-regex 0.1.20171212-1~
diff --git a/debian/python3-regex.maintscript b/debian/python3-regex.maintscript
index 899180d..c476fdd 100644
--- a/debian/python3-regex.maintscript
+++ b/debian/python3-regex.maintscript
@@ -1 +1 @@
-symlink_to_dir /usr/share/doc/python3-regex python3-regex 0.1.20171212-1
+symlink_to_dir /usr/share/doc/python3-regex python-regex 0.1.20171212-1~
-- 
2.11.0

From e11e4ceecb1a0192825201f0aa80371d9c2ec890 Mon Sep 17 00:00:00 2001
From:

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Sandro Tosi 
patch is welcome, NMU is not; feel free to upload the patch to this bug and
i'll take care of the upload. thanks for working on this Debian bug

On Tue, Feb 6, 2018 at 3:54 PM, Nicholas D Steeves 
wrote:

> Hi Andreas,
>
> On Mon, Feb 05, 2018 at 06:32:35PM -0500, Nicholas D Steeves wrote:
> > Hi Andreas and Sandro,
> >
> > On Thu, Jan 11, 2018 at 05:04:13PM +0100, Andreas Beckmann wrote:
> > > Followup-For: Bug #886944
> > > Control: affects -1 + python-regex-dbg
> > >
> > > Hi,
> > >
> > > similar issue in python-regex-dbg:
> > >
> > > 0m33.5s ERROR: FAIL: silently overwrites files via directory symlinks:
> > >   /usr/share/doc/python-regex-dbg/Features.html (python-regex-dbg) !=
> /usr/share/doc/python-regex/Features.html (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >   /usr/share/doc/python-regex-dbg/Features.rst.gz (python-regex-dbg)
> != /usr/share/doc/python-regex/Features.rst.gz (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >   /usr/share/doc/python-regex-dbg/README (python-regex-dbg) !=
> /usr/share/doc/python-regex/README (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >   /usr/share/doc/python-regex-dbg/UnicodeProperties.txt.gz
> (python-regex-dbg) != /usr/share/doc/python-regex/UnicodeProperties.txt.gz
> (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >   /usr/share/doc/python-regex-dbg/changelog.Debian.gz
> (python-regex-dbg) != /usr/share/doc/python-regex/changelog.Debian.gz
> (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >   /usr/share/doc/python-regex-dbg/copyright (python-regex-dbg) !=
> /usr/share/doc/python-regex/copyright (python-regex)
> > > /usr/share/doc/python-regex-dbg -> python-regex
> > >
> > > and probably python3-regex-dbg as well, although that does not get
> > > tested by piuparts as long as python3-regex fails.
> > >
> > >
> > > Andreas
> >
> > I'll attempt to fix this evening, because if calibre is removed from
> > testing than my planned backport will be in jeopardy.  If I succeed
> > I'll prepare an NMU, but in any case I'll reply to this bug with my
> > results.
> >
> > Cheers,
> > Nicholas
>
> Solved it!  I'll prepare a minimal NMU later today.  Would you please
> consider sponsoring the upload (I'll CC you for the RFS)?
>
> Regards,
> Nicholas
>



-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-06 Thread Nicholas D Steeves 
Hi Andreas,

On Mon, Feb 05, 2018 at 06:32:35PM -0500, Nicholas D Steeves wrote:
> Hi Andreas and Sandro,
> 
> On Thu, Jan 11, 2018 at 05:04:13PM +0100, Andreas Beckmann wrote:
> > Followup-For: Bug #886944
> > Control: affects -1 + python-regex-dbg
> > 
> > Hi,
> > 
> > similar issue in python-regex-dbg:
> > 
> > 0m33.5s ERROR: FAIL: silently overwrites files via directory symlinks:
> >   /usr/share/doc/python-regex-dbg/Features.html (python-regex-dbg) != 
> > /usr/share/doc/python-regex/Features.html (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> >   /usr/share/doc/python-regex-dbg/Features.rst.gz (python-regex-dbg) != 
> > /usr/share/doc/python-regex/Features.rst.gz (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> >   /usr/share/doc/python-regex-dbg/README (python-regex-dbg) != 
> > /usr/share/doc/python-regex/README (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> >   /usr/share/doc/python-regex-dbg/UnicodeProperties.txt.gz 
> > (python-regex-dbg) != /usr/share/doc/python-regex/UnicodeProperties.txt.gz 
> > (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> >   /usr/share/doc/python-regex-dbg/changelog.Debian.gz (python-regex-dbg) != 
> > /usr/share/doc/python-regex/changelog.Debian.gz (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> >   /usr/share/doc/python-regex-dbg/copyright (python-regex-dbg) != 
> > /usr/share/doc/python-regex/copyright (python-regex)
> > /usr/share/doc/python-regex-dbg -> python-regex
> > 
> > and probably python3-regex-dbg as well, although that does not get
> > tested by piuparts as long as python3-regex fails.
> > 
> > 
> > Andreas
> 
> I'll attempt to fix this evening, because if calibre is removed from
> testing than my planned backport will be in jeopardy.  If I succeed
> I'll prepare an NMU, but in any case I'll reply to this bug with my
> results.
> 
> Cheers,
> Nicholas

Solved it!  I'll prepare a minimal NMU later today.  Would you please
consider sponsoring the upload (I'll CC you for the RFS)?

Regards,
Nicholas


signature.asc
Description: PGP signature

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-02-05 Thread Nicholas D Steeves 
Hi Andreas and Sandro,

On Thu, Jan 11, 2018 at 05:04:13PM +0100, Andreas Beckmann wrote:
> Followup-For: Bug #886944
> Control: affects -1 + python-regex-dbg
> 
> Hi,
> 
> similar issue in python-regex-dbg:
> 
> 0m33.5s ERROR: FAIL: silently overwrites files via directory symlinks:
>   /usr/share/doc/python-regex-dbg/Features.html (python-regex-dbg) != 
> /usr/share/doc/python-regex/Features.html (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
>   /usr/share/doc/python-regex-dbg/Features.rst.gz (python-regex-dbg) != 
> /usr/share/doc/python-regex/Features.rst.gz (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
>   /usr/share/doc/python-regex-dbg/README (python-regex-dbg) != 
> /usr/share/doc/python-regex/README (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
>   /usr/share/doc/python-regex-dbg/UnicodeProperties.txt.gz (python-regex-dbg) 
> != /usr/share/doc/python-regex/UnicodeProperties.txt.gz (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
>   /usr/share/doc/python-regex-dbg/changelog.Debian.gz (python-regex-dbg) != 
> /usr/share/doc/python-regex/changelog.Debian.gz (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
>   /usr/share/doc/python-regex-dbg/copyright (python-regex-dbg) != 
> /usr/share/doc/python-regex/copyright (python-regex)
> /usr/share/doc/python-regex-dbg -> python-regex
> 
> and probably python3-regex-dbg as well, although that does not get
> tested by piuparts as long as python3-regex fails.
> 
> 
> Andreas

I'll attempt to fix this evening, because if calibre is removed from
testing than my planned backport will be in jeopardy.  If I succeed
I'll prepare an NMU, but in any case I'll reply to this bug with my
results.

Cheers,
Nicholas


signature.asc
Description: PGP signature

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-01-11 Thread Andreas Beckmann 
Followup-For: Bug #886944
Control: affects -1 + python-regex-dbg

Hi,

similar issue in python-regex-dbg:

0m33.5s ERROR: FAIL: silently overwrites files via directory symlinks:
  /usr/share/doc/python-regex-dbg/Features.html (python-regex-dbg) != 
/usr/share/doc/python-regex/Features.html (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex
  /usr/share/doc/python-regex-dbg/Features.rst.gz (python-regex-dbg) != 
/usr/share/doc/python-regex/Features.rst.gz (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex
  /usr/share/doc/python-regex-dbg/README (python-regex-dbg) != 
/usr/share/doc/python-regex/README (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex
  /usr/share/doc/python-regex-dbg/UnicodeProperties.txt.gz (python-regex-dbg) 
!= /usr/share/doc/python-regex/UnicodeProperties.txt.gz (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex
  /usr/share/doc/python-regex-dbg/changelog.Debian.gz (python-regex-dbg) != 
/usr/share/doc/python-regex/changelog.Debian.gz (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex
  /usr/share/doc/python-regex-dbg/copyright (python-regex-dbg) != 
/usr/share/doc/python-regex/copyright (python-regex)
/usr/share/doc/python-regex-dbg -> python-regex

and probably python3-regex-dbg as well, although that does not get
tested by piuparts as long as python3-regex fails.


Andreas

Bug#886944: python3-regex: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE

2018-01-11 Thread Andreas Beckmann 
Package: python3-regex
Version: 0.1.20171212-1
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

an upgrade test with piuparts revealed that your package installs files
over existing symlinks and possibly overwrites files owned by other
packages. This usually means an old version of the package shipped a
symlink but that was later replaced by a real (and non-empty)
directory. This kind of overwriting another package's files cannot be
detected by dpkg.

This was observed on the following upgrade paths:

  stretch -> buster

For /usr/share/doc/PACKAGE this may not be problematic as long as both
packages are installed, ship byte-for-byte identical files and are
upgraded in lockstep. But once one of the involved packages gets
removed, the other one will lose its documentation files, too,
including the copyright file, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/#copyright-information

For other overwritten locations anything interesting may happen.

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/#details-of-unpack-phase-of-installation-or-upgrade

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


>From the attached log (scroll to the bottom...):

0m38.9s ERROR: FAIL: silently overwrites files via directory symlinks:
  /usr/share/doc/python3-regex/Features.html (python3-regex) != 
/usr/share/doc/python-regex/Features.html (python-regex)
/usr/share/doc/python3-regex -> python-regex
  /usr/share/doc/python3-regex/Features.rst.gz (python3-regex) != 
/usr/share/doc/python-regex/Features.rst.gz (python-regex)
/usr/share/doc/python3-regex -> python-regex
  /usr/share/doc/python3-regex/README (python3-regex) != 
/usr/share/doc/python-regex/README (python-regex)
/usr/share/doc/python3-regex -> python-regex
  /usr/share/doc/python3-regex/UnicodeProperties.txt.gz (python3-regex) != 
/usr/share/doc/python-regex/UnicodeProperties.txt.gz (python-regex)
/usr/share/doc/python3-regex -> python-regex
  /usr/share/doc/python3-regex/changelog.Debian.gz (python3-regex) != 
/usr/share/doc/python-regex/changelog.Debian.gz (python-regex)
/usr/share/doc/python3-regex -> python-regex
  /usr/share/doc/python3-regex/copyright (python3-regex) != 
/usr/share/doc/python-regex/copyright (python-regex)
/usr/share/doc/python3-regex -> python-regex


cheers,

Andreas


python3-regex_0.1.20171212-1.log.gz
Description: application/gzip