Bug#887769: starplot FTBFS: error: 'starstrings' has not been declared

[Juhani Numminen]

Control: tags -1 patch

On Fri, 19 Jan 2018 20:40:27 +0200 Adrian Bunk  wrote:
> Source: starplot
> ...
> classes/specclass.cc: In function 'double roman_to_int(const string&)':
> classes/specclass.cc:23:7: error: 'starstrings' has not been declared
>if (starstrings::compare_n(roman_num, "VI", 2)) return 6.0;

I think that src/classes/strings.h did not get included because its header
guard _STRINGS_H conflicted with /usr/include/strings.h. Patch attached.

In combination with the other patch
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862065#10
the package compiles and the program can be started.

Regards,
Juhani
Description: Fix FTBFS: error: 'starstrings' has not been declared
 src/classes/strings.h did not get included because its header guard
 _STRINGS_H conflicted with /usr/include/strings.h.
Author: Juhani Numminen 
Bug-Debian: https://bugs.debian.org/887769
Last-Update: 2018-01-24

--- a/src/classes/strings.h
+++ b/src/classes/strings.h
@@ -1,5 +1,5 @@
-#ifndef _STRINGS_H
-#define _STRINGS_H
+#ifndef STARPLOT_STRINGS_H
+#define STARPLOT_STRINGS_H
 
 #include "../../lib/compat.h"
 #include "cxx_macros.h"

Bug#887769: starplot FTBFS:

[Adrian Bunk]

Source: starplot
Version: 0.95.5-8.2
Severity: serious
Tags: buster sid

Some recent change in unstable makes starplot FTBFS:

https://tests.reproducible-builds.org/debian/history/starplot.html
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/starplot.html

...
classes/specclass.cc: In function 'double roman_to_int(const string&)':
classes/specclass.cc:23:7: error: 'starstrings' has not been declared
   if (starstrings::compare_n(roman_num, "VI", 2)) return 6.0;
   ^~~