Bug#889006: [debhelper-devel] Bug#889006: dh-autoreconf is run before patching
On Thu, Feb 01, 2018 at 07:01:00PM +, Niels Thykier wrote: >... > Indeed, from my PoV we would ideally fix this issue in dpatch. However, > we need to handle backports as well and that puts quilt back the table > as well. I am not quite sure that I want to backport quilt and dpatch > to provide further debhelper backports. Why not? dpatch is a mostly obsolete Debian native package, most recent upload 2015. quilt still has some upstream development, but nothing big. It might still be easier to revert the change in dh-autoreconf, but dpatch and quilt are not packages where I would see any potential problems with making and supporting a backport. > Thanks, > ~Niels cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
Bug#889006: [debhelper-devel] Bug#889006: dh-autoreconf is run before patching
On Thu, Feb 01, 2018 at 07:01:00PM +, Niels Thykier wrote: > Indeed, from my PoV we would ideally fix this issue in dpatch. However, > we need to handle backports as well and that puts quilt back the table > as well. I am not quite sure that I want to backport quilt and dpatch > to provide further debhelper backports. Can't we instead: * ignore this bug * have packages move away from dpatch (I believe now lintian even warns about quilt packages using it? at least for 3.0 which is not this case but still) * don't worry about backports: new dh-autoreconf/debhelper won't be pulled automatically, and if a package from sid doesn't build in bpo isn't really a problem (this is of course different if a package already in bpo already pulling a bpo debhelper/dh-autoreconf would fail) There are only 82 packages with a build-dep on dpatch, and I doubt there are many that uses the dh addon AND autoreconf AND have a patch that modifies the configure script. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#889006: [debhelper-devel] Bug#889006: dh-autoreconf is run before patching
Sven Joachim:
> [ CC'ing dpatch maintainer. ]
>
> On 2018-02-01 08:56 +0200, Adrian Bunk wrote:
>
>> [...]
>
> The dansguardian package uses dpatch:
>
> ,
> | %:
> | dh $@ --with dpatch,autotools_dev,autoreconf
> `
>
> And /usr/share/perl5/Debian/Debhelper/Sequence/dpatch.pm has this line:
>
> insert_before("dh_auto_configure", "dh_dpatch_patch");
>
> I think this should be changed to
>
> insert_before("dh_update_autotools_config", "dh_dpatch_patch");
>
> as is the case in quilt.pm (since quilt 0.63-8.2). Haven't tested it,
> though.
>
> Cheers,
>Sven
>
Hi Sven,
Thanks for forwarding the issue to dpatch.
Indeed, from my PoV we would ideally fix this issue in dpatch. However,
we need to handle backports as well and that puts quilt back the table
as well. I am not quite sure that I want to backport quilt and dpatch
to provide further debhelper backports.
Thanks,
~Niels
