Bug#889928: salt-formula-cinder: FTBFS and Debci failure with salt 2017.7.2

2018-02-14 Thread Benjamin Drung
forwarded 889928 https://github.com/salt-formulas/salt-formula-cinder/pull/23
thanks

Hi,

the build failure is caused by missing Python 3 support. I created a
upstream pull request and backported that commit for the Debian package.
An attached patch that I applied for the Ubuntu package is attached.

On Thu, 08 Feb 2018 23:03:43 +0200 Adrian Bunk  wrote:
> Source: salt-formula-cinder
> Version: 2016.12.1-1
> Severity: serious
> 
> https://ci.debian.net/packages/s/salt-formula-cinder/unstable/amd64/
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/sal
t-formula-cinder.html
> 
> ...
>dh_auto_test
>   make -j15 test
> make[1]: Entering directory '/build/1st/salt-formula-cinder-2016.12.1'
> [ ! -d tests ] || (cd tests; ./run_tests.sh)
> /usr/bin/salt-call
> [WARNING ] Failed to open log file, do you have permission to write to
/var/log/salt/minion?
> [ERROR   ] Rendering exception occurred: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [CRITICAL] Rendering SLS 'base:cinder.controller' failed: Jinja
variable 'salt.utils.odict.OrderedDict object' has no attribute
'iteritems'
> [ERROR   ] Rendering exception occurred: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [CRITICAL] Rendering SLS 'base:cinder.volume' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> local:
> - Rendering SLS 'base:cinder.controller' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> - Rendering SLS 'base:cinder.volume' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [ERROR] Execution of cinder.ceph_single failed
> [ERROR] Execution failed
> Makefile:22: recipe for target 'test' failed
> make[1]: *** [test] Error 1
> 
> 
-- 
Benjamin Drung
Debian & Ubuntu Developerdiff -Nru salt-formula-cinder-2016.12.1/debian/changelog salt-formula-cinder-2016.12.1/debian/changelog
--- salt-formula-cinder-2016.12.1/debian/changelog	2016-12-25 17:05:43.0 +0100
+++ salt-formula-cinder-2016.12.1/debian/changelog	2018-02-15 00:25:17.0 +0100
@@ -1,3 +1,9 @@
+salt-formula-cinder (2016.12.1-1ubuntu1) bionic; urgency=medium
+
+  * Support Python 3 (Closes: #889928)
+
+ -- Benjamin Drung   Thu, 15 Feb 2018 00:25:17 +0100
+
 salt-formula-cinder (2016.12.1-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru salt-formula-cinder-2016.12.1/debian/control salt-formula-cinder-2016.12.1/debian/control
--- salt-formula-cinder-2016.12.1/debian/control	2016-11-21 15:55:43.0 +0100
+++ salt-formula-cinder-2016.12.1/debian/control	2018-02-15 00:25:17.0 +0100
@@ -1,5 +1,6 @@
 Source: salt-formula-cinder
-Maintainer: PKG OpenStack 
+Maintainer: Ubuntu Developers 
+XSBC-Original-Maintainer: PKG OpenStack 
 Uploaders: Filip Pytloun ,
Ondřej Nový ,
 Section: admin
diff -Nru salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch
--- salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch	1970-01-01 01:00:00.0 +0100
+++ salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch	2018-02-15 00:25:17.0 +0100
@@ -0,0 +1,270 @@
+From c5ea00cd7379b8a1dfcdc224c4a8de81553a8f28 Mon Sep 17 00:00:00 2001
+From: Benjamin Drung 
+Date: Wed, 14 Feb 2018 23:44:07 +0100
+Subject: [PATCH] Support Python 3
+
+Bug-Debian: https://bugs.debian.org/889928
+Forwarded: https://github.com/salt-formulas/salt-formula-cinder/pull/23
+---
+ cinder/client.sls  | 4 ++--
+ cinder/controller.sls  | 4 ++--
+ cinder/files/juno/cinder.conf.controller.Debian| 4 ++--
+ cinder/files/juno/cinder.conf.volume.Debian| 4 ++--
+ cinder/files/kilo/cinder.conf.controller.Debian| 4 ++--
+ cinder/files/kilo/cinder.conf.volume.Debian| 4 ++--
+ cinder/files/liberty/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/liberty/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/mitaka/cinder.conf.controller.Debian  | 4 ++--
+ cinder/files/mitaka/cinder.conf.volume.Debian  | 4 ++--
+ cinder/files/newton/cinder.conf.controller.Debian  | 4 ++--
+ cinder/files/newton/cinder.conf.volume.Debian  | 4 ++--
+ cinder/files/ocata/cinder.conf.controller.Debian   | 4 ++--
+ cinder/files/ocata/cinder.conf.volume.Debian   | 4 ++--
+ cinder/files/pike/cinder.conf.controller.Debian| 4 ++--
+ cinder/files/pike/cinder.conf.volume.Debian| 4 ++--
+ cinder/meta/sphinx.yml | 4 ++--
+ cinder/volume.sls  | 2 +-
+ 18 files changed, 35 insertions(+), 35 deletions(-)
+
+--- a/cinder/controller.sls
 b/cinder/controller.sls
+@@ -51,7 +51,7 @@
+ 
+ {# new way #}
+ 
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, b

Bug#889928: salt-formula-cinder: FTBFS and Debci failure with salt 2017.7.2

2018-02-08 Thread Adrian Bunk
Source: salt-formula-cinder
Version: 2016.12.1-1
Severity: serious

https://ci.debian.net/packages/s/salt-formula-cinder/unstable/amd64/
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/salt-formula-cinder.html

...
   dh_auto_test
make -j15 test
make[1]: Entering directory '/build/1st/salt-formula-cinder-2016.12.1'
[ ! -d tests ] || (cd tests; ./run_tests.sh)
/usr/bin/salt-call
[WARNING ] Failed to open log file, do you have permission to write to 
/var/log/salt/minion?
[ERROR   ] Rendering exception occurred: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
[CRITICAL] Rendering SLS 'base:cinder.controller' failed: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
[ERROR   ] Rendering exception occurred: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
[CRITICAL] Rendering SLS 'base:cinder.volume' failed: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
local:
- Rendering SLS 'base:cinder.controller' failed: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
- Rendering SLS 'base:cinder.volume' failed: Jinja variable 
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
[ERROR] Execution of cinder.ceph_single failed
[ERROR] Execution failed
Makefile:22: recipe for target 'test' failed
make[1]: *** [test] Error 1