Bug#893411: sat4j FTBFS with openjdk-9

[Markus Koschany]

Control: tags -1 pending

Dear maintainer,

I've uploaded a new revision of sat4j versioned as 2.3.5-0.3 to fix
Debian bug #893411. Please find attached the debdiff.

Regards,

Markus
diff -Nru sat4j-2.3.5/debian/changelog sat4j-2.3.5/debian/changelog
--- sat4j-2.3.5/debian/changelog2016-11-04 23:10:51.0 +0100
+++ sat4j-2.3.5/debian/changelog2018-04-13 18:54:47.0 +0200
@@ -1,3 +1,10 @@
+sat4j (2.3.5-0.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add encoding.patch and fix FTBFS with Java 9. (Closes: #893411)
+
+ -- Markus Koschany   Fri, 13 Apr 2018 18:54:47 +0200
+
 sat4j (2.3.5-0.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru sat4j-2.3.5/debian/patches/encoding.patch 
sat4j-2.3.5/debian/patches/encoding.patch
--- sat4j-2.3.5/debian/patches/encoding.patch   1970-01-01 01:00:00.0 
+0100
+++ sat4j-2.3.5/debian/patches/encoding.patch   2018-04-13 18:54:47.0 
+0200
@@ -0,0 +1,32 @@
+From: Markus Koschany 
+Date: Fri, 13 Apr 2018 18:53:35 +0200
+Subject: encoding
+
+Fix FTBFS with Java 9 by specifying the encoding everywhere.
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893411
+---
+ build.xml | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/build.xml b/build.xml
+index 88f9620..e6016a5 100644
+--- a/build.xml
 b/build.xml
+@@ -326,6 +326,7 @@
+   destdir="${build}"
+   source="1.5"
+   target="${target}"
++  encoding="iso-8859-1"
+   debug="true"
+   includeantruntime="true">
+   
+@@ -430,7 +431,8 @@
+ 
+   Compiling test files
+-  
++  
+   
+   
+   Running JUNIT tests
diff -Nru sat4j-2.3.5/debian/patches/series sat4j-2.3.5/debian/patches/series
--- sat4j-2.3.5/debian/patches/series   2016-11-04 22:57:45.0 +0100
+++ sat4j-2.3.5/debian/patches/series   2018-04-13 18:54:47.0 +0200
@@ -1,2 +1,3 @@
 commmons-cli
 debian-build
+encoding.patch


signature.asc
Description: OpenPGP digital signature

Bug#893411: sat4j FTBFS with openjdk-9

[Juhani Numminen]

On Sun, 18 Mar 2018 19:58:15 +0200 Adrian Bunk  wrote:
> Source: sat4j
> Version: 2.3.5-0.2
> ...
> [javac] 
> /build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
>  error: unmappable character (0xC3) for encoding US-ASCII
> [javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
> Computing Backbones of

There are a couple upstream commits about encoding issues:
https://gitlab.ow2.org/sat4j/sat4j/commit/3e5212ca
https://gitlab.ow2.org/sat4j/sat4j/commit/77920af8


Juhani

Bug#893411: sat4j FTBFS with openjdk-9

[Adrian Bunk]

Source: sat4j
Version: 2.3.5-0.2
Severity: serious
Tags: buster sid

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/sat4j.html

...
build:
 [echo] Compiling source code org.sat4j.core/src/main/java using target 1.5
[javac] Using javac -source 1.5 is no longer supported, switching to 1.6
[javac] Using javac -target 1.5 is no longer supported, switching to 1.6
[javac] Compiling 215 source files to /build/1st/sat4j-2.3.5/bin
[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 1.6
[javac] warning: [options] source value 1.6 is obsolete and will be removed 
in a future release
[javac] warning: [options] target value 1.6 is obsolete and will be removed 
in a future release
[javac] warning: [options] To suppress warnings about obsolete options, use 
-Xlint:-options.
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]  ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xA3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]   ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]  ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xA1) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]   ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:54:
 error: unmappable character (0xAA) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac] ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]  ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xA3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]   ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]  ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xA1) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]   ^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xC3) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac]^
[javac] 
/build/1st/sat4j-2.3.5/org.sat4j.core/src/main/java/org/sat4j/tools/Backbone.java:70:
 error: unmappable character (0xAA) for encoding US-ASCII
[javac]  * Jo??o Marques-Silva, Mikol??s Janota, In??s Lynce: On 
Computing Backbones of
[javac] ^
[javac] 12 errors
[javac] 4 warnings

BUILD FAILED
/build/1st/sat4j-2.3.5/build.xml:210: The following error occurred while 
executing this line:
/build/1st/sat4j-2.3.5/build.xml:330: Compile failed; see the compiler error 
output for details.

Total time: 2 seconds
make[1]: *** [debian/rules:44: override_dh_auto_build] Error 1