Bug#893577: sbuild-debian-developer-setup: Should not rely on files in /usr/share/doc

[Johannes Schauer]

Quoting Michael Stapelberg (2018-04-09 09:21:46)
> josch, could you let me know whether the attached patch does what you have
> in mind please? Thanks!

Yes, that looks good.

cheers, josch


signature.asc
Description: signature

Bug#893577: sbuild-debian-developer-setup: Should not rely on files in /usr/share/doc

[Michael Stapelberg]

josch, could you let me know whether the attached patch does what you have
in mind please? Thanks!

On Tue, Mar 27, 2018 at 2:47 PM, Johannes Schauer  wrote:

> Hi all,
>
> > At the end of the script, it runs
> >
> > symlink("/usr/share/doc/sbuild/examples/sbuild-update-all",
> "/etc/cron.daily/sbuild-debian-developer-setup-update-all");
> >
> > which requires the file in /usr/share/doc to be present. Policy 12.3
> says that
> > packages can't do that and says that such files should be in
> > /usr/share/package with a symlink into /usr/share/doc/package/ as
> > appropriate.
>
> probably the right thing to do would be to let the
> sbuild-debian-developer-setup package directly install sbuild-update-all
> into
> /etc/cron.daily/sbuild-debian-developer-setup-update-all. If necessary,
> sbuild-update-all has to be adapted such that it will not barf if the user
> has
> not yet run sbuild-debian-developer-setup.
>
> This would mean that the same copy of sbuild-update-all would potentially
> exist
> twice on a system, but I don't think that's much of a problem.
>
> Michael, can you take care of this?
>
> Thanks!
>
> cheers, josch
>



-- 
Best regards,
Michael
diff --git i/debian/rules w/debian/rules
index bc15c043..b1bfe785 100755
--- i/debian/rules
+++ w/debian/rules
@@ -3,5 +3,10 @@
 %:
 	dh $@
 
+override_dh_install:
+	cp etc/sbuild-update-all etc/sbuild-debian-developer-setup-update-all
+	chmod +x etc/sbuild-debian-developer-setup-update-all
+	dh_install
+
 override_dh_installinit:
 	dh_installinit --no-start --no-restart-on-upgrade
diff --git i/debian/sbuild-debian-developer-setup.install w/debian/sbuild-debian-developer-setup.install
index 406b3af9..6d2a1699 100644
--- i/debian/sbuild-debian-developer-setup.install
+++ w/debian/sbuild-debian-developer-setup.install
@@ -1 +1,2 @@
 usr/bin/sbuild-debian-developer-setup
+etc/sbuild-debian-developer-setup-update-all etc/cron.daily
diff --git i/etc/sbuild-update-all w/etc/sbuild-update-all
index 12a394cb..3e22d05a 100644
--- i/etc/sbuild-update-all
+++ w/etc/sbuild-update-all
@@ -76,7 +76,7 @@ exec 1>&8
 if ! ls /etc/schroot/chroot.d/$PATTERN >/dev/null 2>&1
 then
 	echo "No chroots defined"
-	break
+	exit 0
 fi
 
 for fullname in /etc/schroot/chroot.d/$PATTERN

Bug#893577: sbuild-debian-developer-setup: Should not rely on files in /usr/share/doc

[Johannes Schauer]

Hi all,

> At the end of the script, it runs
> 
> symlink("/usr/share/doc/sbuild/examples/sbuild-update-all", 
> "/etc/cron.daily/sbuild-debian-developer-setup-update-all");
> 
> which requires the file in /usr/share/doc to be present. Policy 12.3 says that
> packages can't do that and says that such files should be in
> /usr/share/package with a symlink into /usr/share/doc/package/ as
> appropriate.

probably the right thing to do would be to let the
sbuild-debian-developer-setup package directly install sbuild-update-all into
/etc/cron.daily/sbuild-debian-developer-setup-update-all. If necessary,
sbuild-update-all has to be adapted such that it will not barf if the user has
not yet run sbuild-debian-developer-setup.

This would mean that the same copy of sbuild-update-all would potentially exist
twice on a system, but I don't think that's much of a problem.

Michael, can you take care of this?

Thanks!

cheers, josch


signature.asc
Description: signature

Bug#893577: sbuild-debian-developer-setup: Should not rely on files in /usr/share/doc

[Stuart Prescott]

Package: sbuild-debian-developer-setup
Version: 0.74.0-1
Severity: serious
Justification: Policy 12.3 Packages must not require the existence of any files 
in /usr/share/doc/ in order to function.

Dear Maintainer,

Thanks for adding sbuild-debian-developer-setup - it indeed looks like a good
way of a new user getting started with sbuild.

At the end of the script, it runs

symlink("/usr/share/doc/sbuild/examples/sbuild-update-all", 
"/etc/cron.daily/sbuild-debian-developer-setup-update-all");

which requires the file in /usr/share/doc to be present. Policy 12.3 says that
packages can't do that and says that such files should be in /usr/share/package
with a symlink into /usr/share/doc/package/ as appropriate.

regards
Stuart