Bug#895701: dlib: Incomplete debian/copyright?

[Hugo Lefeuvre]

Hi Chris,

> I just ACCEPTed dlib from NEW but noticed it was missing attribution 
> in debian/copyright for at least assert.h, numerical_integration.cpp,
> fhog.h, and possibly all of dlib-models, I am unsure..
> 
> (This is in no way exhaustive so please check over the entire package 
> carefully and address these on your next upload.)

Right, we didn't notice these dlib/ files:

 setup.py: Copyright (C) 2015  Ehsan Azar (dash...@linux.com)

 dlib/sockets/sockets_kernel_1.cpp:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_2.h:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_1.h:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_2.cpp:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg

 dlib/matlab/mex_wrapper.cpp:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory
 dlib/matlab/mex_wrapper.cpp:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory
 dlib/matlab/call_matlab.h:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory

 dlib/gui_widgets/nativefont.h:// Copyright (C) 2006 Keita Mochizuki 

 dlib/gui_core/gui_core_kernel_2.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_2.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_1.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki 
 dlib/gui_core/gui_core_kernel_1.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/drawable.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/drawable.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/unicode/unicode.cpp:// Copyright (C) 2008 Keita Mochizuki, Davis E. King 
(da...@dlib.net)

 dlib/gui_widgets/fonts_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Nils Labugt, Keita Mochizuki
 dlib/gui_widgets/fonts.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt, Keita Mochizuki
 dlib/gui_widgets/fonts.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt, Keita Mochizuki

 dlib/test/numerical_integration.cpp:// Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com)
 dlib/numerical_integration.h:// Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com)
 dlib/numerical_integration/integrate_function_adapt_simpson.h:// Copyright (C) 
2013 Steve Taylor (steve98...@gmail.com)
 dlib/numerical_integration/integrate_function_adapt_simpson_abstract.h:// 
Copyright (C) 2013 Steve Taylor (steve98...@gmail.com)

 dlib/statistics/statistics.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Steve Taylor
 dlib/statistics/statistics_abstract.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Steve Taylor
 dlib/numeric_constants.h://Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com), Davis E. King

 dlib/matrix/lapack/fortran_id.h://  Copyright (C) 2002, 2003 Si-Lab b.v.b.a., 
Toon Knapen and Kresimir Fresl 

 dlib/image_loader/jpeg_loader.h:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader.cpp:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader_abstract.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/jpeg_loader.cpp:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/gui_widgets/canvas_drawing_abstract.h:// Copyright (C) 2005  Davis E. 
King (da...@dlib.net), and Nils Labugt
 dlib/image_loader/load_image_abstract.h:// Copyright (C) 2011  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/jpeg_loader_abstract.h:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/gui_widgets/canvas_drawing.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/gui_widgets/style.h:// Copyright (C) 2008  Davis E. King 

Bug#895701: dlib: Incomplete debian/copyright?

[Chris Lamb]

Source: dlib
Version: 19.10-1
Severity: serious
Justication: Policy 12.5
X-Debbugs-CC: Hugo Lefeuvre 

Hi,

I just ACCEPTed dlib from NEW but noticed it was missing attribution 
in debian/copyright for at least assert.h, numerical_integration.cpp,
fhog.h, and possibly all of dlib-models, I am unsure..

(This is in no way exhaustive so please check over the entire package 
carefully and address these on your next upload.)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-