Your message dated Sun, 04 Nov 2018 21:05:00 +0000
with message-id <e1gjpzs-000igu...@fasolo.debian.org>
and subject line Bug#912190: fixed in mixxx 2.1.5~dfsg-1
has caused the Debian Bug report #912190,
regarding mixx uses inappropriate compiler flags on arm.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
912190: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912190
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: mixxx
version: 2.1.3~dfsg-1
severity: serious
tags: patch
mixxx unconditionally uses -mfloat-abi=hard and -mfpu=neon on arm*. These are
inappropriate in Debian.
On armhf "-mfloat-abi=hard" is redundant but not harmful "-mfpu=neon" will
likely result in binaries that will break on the baseline CPU level for the port.
On armel "-mfloat-abi=hard" breaks the build (the error message shown in the
build log does not show the real cause but inspecting config.log after a build attempt
does). I think -mfpu is a no-op on armel unless -mfloat-abi is also used but it is still
not good practice to use it.
On arm64 "-mfloat-abi=hard" and "-mfpu=neon" both break the build.
I did my research with version 2.1.4~dfsg-1 but looking at the build logs it
looks like 2.1.3~dfsg-1 was probably affected by the same issue.
While working on the above issue I also found that the clean target was not
cleaning up properly.
Attached is a debdiff that removes the offending compiler flags and fixes the
clean target.
diff -Nru mixxx-2.1.4~dfsg/debian/changelog mixxx-2.1.4~dfsg/debian/changelog
--- mixxx-2.1.4~dfsg/debian/changelog 2018-10-07 13:15:30.000000000 +0000
+++ mixxx-2.1.4~dfsg/debian/changelog 2018-10-28 03:49:20.000000000 +0000
@@ -1,3 +1,11 @@
+mixxx (2.1.4~dfsg-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Remove inappropriate compiler flags on arm.
+ * Fix clean target.
+
+ -- Peter Michael Green <plugw...@debian.org> Sun, 28 Oct 2018 03:49:20 +0000
+
mixxx (2.1.4~dfsg-1) unstable; urgency=medium
[ Olivier Humbert ]
diff -Nru
mixxx-2.1.4~dfsg/debian/patches/0004-remove-inapprorpriate-arm-compiler-flags.patch
mixxx-2.1.4~dfsg/debian/patches/0004-remove-inapprorpriate-arm-compiler-flags.patch
---
mixxx-2.1.4~dfsg/debian/patches/0004-remove-inapprorpriate-arm-compiler-flags.patch
1970-01-01 00:00:00.000000000 +0000
+++
mixxx-2.1.4~dfsg/debian/patches/0004-remove-inapprorpriate-arm-compiler-flags.patch
2018-10-28 03:38:36.000000000 +0000
@@ -0,0 +1,31 @@
+Description: Remove inappropriate compiler flags on arm.
+ The flags used by this package result in build failures
+ and violations of the minimum CPU baseline. Remove them.
+Author: Peter Micheal Green <plugw...@debian.org>
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: https://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: 2018-10-28
+
+--- mixxx-2.1.4~dfsg.orig/build/features.py
++++ mixxx-2.1.4~dfsg/build/features.py
+@@ -1163,8 +1163,8 @@ class Optimize(Feature):
+ build.env.Append(CCFLAGS='-mfpmath=sse')
+ elif build.architecture_is_arm:
+ self.status = self.build_status(optimize_level)
+- build.env.Append(CCFLAGS='-mfloat-abi=hard')
+- build.env.Append(CCFLAGS='-mfpu=neon')
++ #build.env.Append(CCFLAGS='-mfloat-abi=hard')
++ #build.env.Append(CCFLAGS='-mfpu=neon')
+ else:
+ self.status = self.build_status(optimize_level)
+ # this sets macros __SSE2_MATH__ __SSE_MATH__ __SSE2__ __SSE__
diff -Nru mixxx-2.1.4~dfsg/debian/patches/series
mixxx-2.1.4~dfsg/debian/patches/series
--- mixxx-2.1.4~dfsg/debian/patches/series 2018-08-23 20:58:34.000000000
+0000
+++ mixxx-2.1.4~dfsg/debian/patches/series 2018-10-28 03:36:48.000000000
+0000
@@ -1,3 +1,4 @@
0001-disable_soundsourcem4a.patch
0002-desktop_file.patch
0003-soundtouch.patch
+0004-remove-inapprorpriate-arm-compiler-flags.patch
diff -Nru mixxx-2.1.4~dfsg/debian/rules mixxx-2.1.4~dfsg/debian/rules
--- mixxx-2.1.4~dfsg/debian/rules 2018-05-02 15:02:09.000000000 +0000
+++ mixxx-2.1.4~dfsg/debian/rules 2018-10-28 03:49:20.000000000 +0000
@@ -54,6 +54,7 @@
dh_clean .sconsign.dblite cachecustom.py \
config.log src/build.h build/*.pyc mixxx.1
dh_auto_clean
+ rm -rf lin*_build/
override_dh_auto_install:
scons $(SCONS_OPTS) install
--- End Message ---
--- Begin Message ---
Source: mixxx
Source-Version: 2.1.5~dfsg-1
We believe that the bug you reported is fixed in the latest version of
mixxx, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 912...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matteo F. Vescovi <m...@debian.org> (supplier of updated mixxx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 04 Nov 2018 15:52:15 +0100
Source: mixxx
Binary: mixxx mixxx-data
Architecture: source
Version: 2.1.5~dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multime...@lists.debian.org>
Changed-By: Matteo F. Vescovi <m...@debian.org>
Description:
mixxx - Digital Disc Jockey Interface
mixxx-data - Digital Disc Jockey Interface -- data files
Closes: 912190
Changes:
mixxx (2.1.5~dfsg-1) unstable; urgency=medium
.
[ Matteo F. Vescovi ]
* New upstream release
.
[ Peter Green ]
* debian/patches/: patchset updated (Closes: #912190)
- 0004-remove-inappropriate-arm-compiler-flags.patch added
* Fix clean target
Checksums-Sha1:
2188b4d0fa448cd922ab2dbe0a8c63b2ab8a68c1 2936 mixxx_2.1.5~dfsg-1.dsc
77f68f2d3b0577d93b89034c98163a0a5e522467 14978324 mixxx_2.1.5~dfsg.orig.tar.xz
2d24d97004284167f3cf91259d8f1c42cd0833a5 20784 mixxx_2.1.5~dfsg-1.debian.tar.xz
257cab156de4b9223477a41b0e936a2678832d06 9942
mixxx_2.1.5~dfsg-1_source.buildinfo
Checksums-Sha256:
4882b43e70cd00841978b185d5dee8af1e7b5cbaec50c8657931f31da4311b4a 2936
mixxx_2.1.5~dfsg-1.dsc
3213b2a6d56c85864b6b98a866813b19755de131a1e6a7eb3d1ad6b33ea3be9d 14978324
mixxx_2.1.5~dfsg.orig.tar.xz
999f609d261f5de5bad77c8097f1e31d95f66661b88b2d7845bc9c13d091ab35 20784
mixxx_2.1.5~dfsg-1.debian.tar.xz
75b86c779112e0ee0dc82458cfd123639f58f286e02106df2b65aaa6ecb5e91d 9942
mixxx_2.1.5~dfsg-1_source.buildinfo
Files:
d4e709d8d3f2b897aafd9c72772a01ac 2936 sound optional mixxx_2.1.5~dfsg-1.dsc
dfae468a00f0875ce7a73aa0c3366fa8 14978324 sound optional
mixxx_2.1.5~dfsg.orig.tar.xz
4cdad29c86a06c9c3328c8484c8f42b3 20784 sound optional
mixxx_2.1.5~dfsg-1.debian.tar.xz
8721eaa03aa1606d51a25f28a6ba9188 9942 sound optional
mixxx_2.1.5~dfsg-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
Comment: Debian powered!
iQKTBAEBCgB9FiEE890J+NqH0d9QRsmbBhL0lE7NzVoFAlvfB9dfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEYz
REQwOUY4REE4N0QxREY1MDQ2Qzk5QjA2MTJGNDk0NEVDRENENUEACgkQBhL0lE7N
zVo94A/+O26oQSnd8ttvziDcguROUAXWrBGVCh3ys3Cdt+hN79bCQ9Ras8b75bzF
RVFLfFZ6NuVwt8wrWVfsBmXNDoxoB9stPWVF90X/038TZ3cqy+qlCn3oDB60t4wk
+Du09TGBfn72C5YkpynZvaL66f5BFC9pQ6nvLGM8zproWvMve/9ojMHPUSB8Zrj1
M1z6JWYNNoHrunElOG8/2g/dv+nCZ+hs+CSxDSNBz+zbFL1UKUNaZS6LmR29JkNA
hsUAOZcHCM3E0Rm5qCXUVyr1n0RhSEvrAnyd4yxnz6yOEQTRmIhdMOX+IozRQ7xr
LlCuCXb7fdLGE1iGJO6SU6fE1Ytl4Bqn+7J0xP0gsmdXEvM1EozhqB1oI6VOodZk
YiZs8+u6DDIc6aigPSpXRQSnAWMNZrNGSN8x6G1jOWbo5pj+tP9XAgR7zRYaAzzS
tzk/7DiX8eKRucAR9cM4jpL2cJ58cV2sIHxKWaW/1DRZn4C+fyaZ1FdMl6JAU83x
jwH0Wg26GW+djXdCW2zpAF4QUR8u6N2Ng/Hjjj37T4eeFL6Q7IGcw817K1u/6xKc
X334+Qs31x5WXJGjl7fSXDwvDPITSs4lTdh/9ARxCjLOEa3YqCoOlFhRqLHw2bCM
Wd6o/nFcijUov0JGESUqsZBjKXHByuDhuU5OptA6cRY+WZr4nZk=
=dBgq
-----END PGP SIGNATURE-----
--- End Message ---
