Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
Daniel, et al.
I was preparing a fix for this by copying some support scripts from
other exporters when I noticed a couple of things, and wanted to check
with you before making any change.
This exporter is running with user postfix, while all the others use the
prometheus user. I understand that you need to access the queue
directly, but this could be done by granting the postqueue group when
starting the process instead.
Another thing is that this requires a special log configuration
(duplicating all postfix entries to a new file, and making that file
writable by the user this exporter runs as), which probably should be
documented in a Debian readme, and I have no idea how to do this with
systemd? Also, I'd suggest moving that log to /var/{lib,log}/prometheus
Honestly, back in the day I had looked at this exporter and decided it
was not great because of the log requirement, and started using mtail
for monitoring postfix.
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
My recollection is that you mail debian-release and ask. Scott y On February 7, 2019 7:51:29 AM UTC, Michael Stapelberg wrote: >On Thu, Feb 7, 2019 at 8:46 AM Scott Kitterman >wrote: > >> No. It's an actual policy violation, so the bug is correct. I'd >leave it >> as is and ask the release team to mark it buster-ignore. >> > >Could you kindly point me to where the process is described for this? >I’m >not sure what I’d need to do to get it marked buster-ignore. Thanks. > > >> >> Scott K >> >> On February 7, 2019 7:29:01 AM UTC, Michael Stapelberg < >> stapelb...@debian.org> wrote: >> >On Wed, Feb 6, 2019 at 11:01 PM Scott Kitterman > >> >wrote: >> > >> >> It's not the FTP Team's job to fix policy compliance issues in >> >packages. >> >> If you have a problem with that being a policy must, then you >should >> >take >> >> it up with the policy team. >> >> >> > >> >Yeah, I’ll post to #911165 >> > >> > >> >> >> >> I completely understand the frustration, but in my own packages I >> >take the >> >> time to do it because Debian policy says it's required, not >because I >> >> particularly care about sysvinit. >> >> >> > >> >I don’t think fulfilling the policy for fulfilling the policy’s sake >is >> >a >> >good use of anyone’s time. >> > >> >Can we close this bug until someone comes along who actually cares? >:) >> > >> > >> >> >> >> Scott K >> >> >> >> On February 6, 2019 9:23:46 PM UTC, Michael Stapelberg < >> >> stapelb...@debian.org> wrote: >> >> >Can you provide a patch if you care about sysvinit please? The Go >> >> >packaging >> >> >team is pretty manpower-constrained and non-systemd is a niche >case, >> >so >> >> >any >> >> >help is appreciated. Thanks! >> >> > >> >> >On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman >> > >> >> >wrote: >> >> > >> >> >> Package: prometheus-postfix-exporter >> >> >> Version: 0.1.2-1 >> >> >> Severity: serious >> >> >> Justification: Policy 9.11 >> >> >> >> >> >> Excerpt from policy 9.11: >> >> >> >> >> >> However, any package integrating with other init systems >> >> >> must also be backwards-compatible with sysvinit by providing a >> >SysV- >> >> >> style init script with the same name as and equivalent >> >functionality >> >> >> to any init-specific job, as this is the only start-up >> >configuration >> >> >> method guaranteed to be supported by all init implementations. >> >> >> >> >> >> The package violates a policy must by not providing s sysvint >init >> >> >script. >> >> >> >> >> >> Scott K >> >> >> >> >> >> ___ >> >> >> Pkg-go-maintainers mailing list >> >> >> pkg-go-maintain...@alioth-lists.debian.net >> >> >> >> >> > >> >> >> > >> >https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers >> >> >>
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
On Thu, Feb 7, 2019 at 8:46 AM Scott Kitterman wrote: > No. It's an actual policy violation, so the bug is correct. I'd leave it > as is and ask the release team to mark it buster-ignore. > Could you kindly point me to where the process is described for this? I’m not sure what I’d need to do to get it marked buster-ignore. Thanks. > > Scott K > > On February 7, 2019 7:29:01 AM UTC, Michael Stapelberg < > stapelb...@debian.org> wrote: > >On Wed, Feb 6, 2019 at 11:01 PM Scott Kitterman > >wrote: > > > >> It's not the FTP Team's job to fix policy compliance issues in > >packages. > >> If you have a problem with that being a policy must, then you should > >take > >> it up with the policy team. > >> > > > >Yeah, I’ll post to #911165 > > > > > >> > >> I completely understand the frustration, but in my own packages I > >take the > >> time to do it because Debian policy says it's required, not because I > >> particularly care about sysvinit. > >> > > > >I don’t think fulfilling the policy for fulfilling the policy’s sake is > >a > >good use of anyone’s time. > > > >Can we close this bug until someone comes along who actually cares? :) > > > > > >> > >> Scott K > >> > >> On February 6, 2019 9:23:46 PM UTC, Michael Stapelberg < > >> stapelb...@debian.org> wrote: > >> >Can you provide a patch if you care about sysvinit please? The Go > >> >packaging > >> >team is pretty manpower-constrained and non-systemd is a niche case, > >so > >> >any > >> >help is appreciated. Thanks! > >> > > >> >On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman > > > >> >wrote: > >> > > >> >> Package: prometheus-postfix-exporter > >> >> Version: 0.1.2-1 > >> >> Severity: serious > >> >> Justification: Policy 9.11 > >> >> > >> >> Excerpt from policy 9.11: > >> >> > >> >> However, any package integrating with other init systems > >> >> must also be backwards-compatible with sysvinit by providing a > >SysV- > >> >> style init script with the same name as and equivalent > >functionality > >> >> to any init-specific job, as this is the only start-up > >configuration > >> >> method guaranteed to be supported by all init implementations. > >> >> > >> >> The package violates a policy must by not providing s sysvint init > >> >script. > >> >> > >> >> Scott K > >> >> > >> >> ___ > >> >> Pkg-go-maintainers mailing list > >> >> pkg-go-maintain...@alioth-lists.debian.net > >> >> > >> > > >> > > > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers > >> > -- Best regards, Michael
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
No. It's an actual policy violation, so the bug is correct. I'd leave it as is and ask the release team to mark it buster-ignore. Scott K On February 7, 2019 7:29:01 AM UTC, Michael Stapelberg wrote: >On Wed, Feb 6, 2019 at 11:01 PM Scott Kitterman >wrote: > >> It's not the FTP Team's job to fix policy compliance issues in >packages. >> If you have a problem with that being a policy must, then you should >take >> it up with the policy team. >> > >Yeah, I’ll post to #911165 > > >> >> I completely understand the frustration, but in my own packages I >take the >> time to do it because Debian policy says it's required, not because I >> particularly care about sysvinit. >> > >I don’t think fulfilling the policy for fulfilling the policy’s sake is >a >good use of anyone’s time. > >Can we close this bug until someone comes along who actually cares? :) > > >> >> Scott K >> >> On February 6, 2019 9:23:46 PM UTC, Michael Stapelberg < >> stapelb...@debian.org> wrote: >> >Can you provide a patch if you care about sysvinit please? The Go >> >packaging >> >team is pretty manpower-constrained and non-systemd is a niche case, >so >> >any >> >help is appreciated. Thanks! >> > >> >On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman > >> >wrote: >> > >> >> Package: prometheus-postfix-exporter >> >> Version: 0.1.2-1 >> >> Severity: serious >> >> Justification: Policy 9.11 >> >> >> >> Excerpt from policy 9.11: >> >> >> >> However, any package integrating with other init systems >> >> must also be backwards-compatible with sysvinit by providing a >SysV- >> >> style init script with the same name as and equivalent >functionality >> >> to any init-specific job, as this is the only start-up >configuration >> >> method guaranteed to be supported by all init implementations. >> >> >> >> The package violates a policy must by not providing s sysvint init >> >script. >> >> >> >> Scott K >> >> >> >> ___ >> >> Pkg-go-maintainers mailing list >> >> pkg-go-maintain...@alioth-lists.debian.net >> >> >> > >> >https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers >>
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
On Wed, Feb 6, 2019 at 11:01 PM Scott Kitterman wrote: > It's not the FTP Team's job to fix policy compliance issues in packages. > If you have a problem with that being a policy must, then you should take > it up with the policy team. > Yeah, I’ll post to #911165 > > I completely understand the frustration, but in my own packages I take the > time to do it because Debian policy says it's required, not because I > particularly care about sysvinit. > I don’t think fulfilling the policy for fulfilling the policy’s sake is a good use of anyone’s time. Can we close this bug until someone comes along who actually cares? :) > > Scott K > > On February 6, 2019 9:23:46 PM UTC, Michael Stapelberg < > stapelb...@debian.org> wrote: > >Can you provide a patch if you care about sysvinit please? The Go > >packaging > >team is pretty manpower-constrained and non-systemd is a niche case, so > >any > >help is appreciated. Thanks! > > > >On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman > >wrote: > > > >> Package: prometheus-postfix-exporter > >> Version: 0.1.2-1 > >> Severity: serious > >> Justification: Policy 9.11 > >> > >> Excerpt from policy 9.11: > >> > >> However, any package integrating with other init systems > >> must also be backwards-compatible with sysvinit by providing a SysV- > >> style init script with the same name as and equivalent functionality > >> to any init-specific job, as this is the only start-up configuration > >> method guaranteed to be supported by all init implementations. > >> > >> The package violates a policy must by not providing s sysvint init > >script. > >> > >> Scott K > >> > >> ___ > >> Pkg-go-maintainers mailing list > >> pkg-go-maintain...@alioth-lists.debian.net > >> > > > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers > -- Best regards, Michael
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
It's not the FTP Team's job to fix policy compliance issues in packages. If you have a problem with that being a policy must, then you should take it up with the policy team. I completely understand the frustration, but in my own packages I take the time to do it because Debian policy says it's required, not because I particularly care about sysvinit. Scott K On February 6, 2019 9:23:46 PM UTC, Michael Stapelberg wrote: >Can you provide a patch if you care about sysvinit please? The Go >packaging >team is pretty manpower-constrained and non-systemd is a niche case, so >any >help is appreciated. Thanks! > >On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman >wrote: > >> Package: prometheus-postfix-exporter >> Version: 0.1.2-1 >> Severity: serious >> Justification: Policy 9.11 >> >> Excerpt from policy 9.11: >> >> However, any package integrating with other init systems >> must also be backwards-compatible with sysvinit by providing a SysV- >> style init script with the same name as and equivalent functionality >> to any init-specific job, as this is the only start-up configuration >> method guaranteed to be supported by all init implementations. >> >> The package violates a policy must by not providing s sysvint init >script. >> >> Scott K >> >> ___ >> Pkg-go-maintainers mailing list >> pkg-go-maintain...@alioth-lists.debian.net >> >https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers
Bug#921351: [pkg-go] Bug#921351: prometheus-postfix-exporter: Init script missing
Can you provide a patch if you care about sysvinit please? The Go packaging team is pretty manpower-constrained and non-systemd is a niche case, so any help is appreciated. Thanks! On Wed, Feb 6, 2019 at 7:49 PM Scott Kitterman wrote: > Package: prometheus-postfix-exporter > Version: 0.1.2-1 > Severity: serious > Justification: Policy 9.11 > > Excerpt from policy 9.11: > > However, any package integrating with other init systems > must also be backwards-compatible with sysvinit by providing a SysV- > style init script with the same name as and equivalent functionality > to any init-specific job, as this is the only start-up configuration > method guaranteed to be supported by all init implementations. > > The package violates a policy must by not providing s sysvint init script. > > Scott K > > ___ > Pkg-go-maintainers mailing list > pkg-go-maintain...@alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers -- Best regards, Michael
