Re: salsa.debian.org: merge requests and such

2018-11-19 Thread Ian Jackson
Guido Günther writes ("Re: salsa.debian.org: merge requests and such"): > On Fri, Nov 09, 2018 at 07:42:13PM +, Holger Levsen wrote: > > - git wise, I think, I reverted these commits, pushed my changes and > > merged the reverted commits again. No big de

Re: salsa.debian.org: merge requests and such

2018-11-18 Thread Guido Günther
Hi, On Fri, Nov 09, 2018 at 07:42:13PM +, Holger Levsen wrote: > On Fri, Nov 09, 2018 at 05:41:53PM +, Matthew Vernon wrote: > > The particular commit was fine (and had it come as a MR or bug report or > > whatever I'd have had no problem with it at all). > > I'm not sure why you are so

Re: salsa.debian.org: merge requests and such

2018-11-12 Thread Herbert Fortes
On 12/11/2018 13:02, Ian Jackson wrote: Colin Watson writes ("Re: salsa.debian.org: merge requests and such"): Honestly, I think it's better for Debian as a whole that people should be able to do that kind of bulk cleanup with absolutely minimal friction, I absolutely agree. The

Re: salsa.debian.org: merge requests and such

2018-11-12 Thread Ian Jackson
Colin Watson writes ("Re: salsa.debian.org: merge requests and such"): > Honestly, I think it's better for Debian as a whole that people should > be able to do that kind of bulk cleanup with absolutely minimal > friction, I absolutely agree. The disruption from this kind

Re: salsa.debian.org: merge requests and such

2018-11-11 Thread Colin Watson
On Sat, Nov 10, 2018 at 10:36:53AM -0200, Herbert Fortes wrote: > But why the new debian/changelog? It is a honest question. Seems perfectly reasonable to me (and indeed I'd have thought it was best practice): make a change, add a changelog entry to go with it. If the maintainer wants to do

Re: salsa.debian.org: merge requests and such

2018-11-11 Thread James McCoy
On Sun, Nov 11, 2018 at 01:51:56PM +, Jonathan Dowland wrote: > On Fri, Nov 09, 2018 at 04:57:51PM +, Matthew Vernon wrote: > > That's what Vcs-Git et al are for, isn't it? > > I'm sorry I don't understand what you're saying. That was in response to the visibility aspect of your email.

Re: salsa.debian.org: merge requests and such

2018-11-11 Thread Jonathan Dowland
On Fri, Nov 09, 2018 at 04:57:51PM +, Matthew Vernon wrote: That's what Vcs-Git et al are for, isn't it? I'm sorry I don't understand what you're saying. Right now, the only way that someone can indicate that a package is collaboratively maintained via the control file is to have their

Re: salsa.debian.org: merge requests and such

2018-11-11 Thread Marc Haber
On Tue, 6 Nov 2018 15:43:41 + (UTC), Felipe Sateler wrote: >But for example, about a month ago Ond?ej Nový >changed the Format: url of d/copyright to use https on one of my packages >(and I assume a lot more), and didn't notify me. I don't think it is >reasonable to ask for coordination

Re: salsa.debian.org: merge requests and such

2018-11-11 Thread Herbert Fortes
On 10/11/2018 17:18, Phil Morrell wrote: On Sat, Nov 10, 2018 at 10:36:53AM -0200, Herbert Fortes wrote: On 09/11/2018 20:26, Colin Watson wrote: I guessed that the particular commit was https://salsa.debian.org/debian/pcre2/commit/6c14b51ddfc45604fd805bcadc810d437f09a30f. (The same developer

Re: salsa.debian.org: merge requests and such

2018-11-10 Thread Phil Morrell
On Sat, Nov 10, 2018 at 10:36:53AM -0200, Herbert Fortes wrote: > On 09/11/2018 20:26, Colin Watson wrote: > > I guessed that the particular commit was > > https://salsa.debian.org/debian/pcre2/commit/6c14b51ddfc45604fd805bcadc810d437f09a30f. > > (The same developer has also been doing a number of

Re: salsa.debian.org: merge requests and such

2018-11-10 Thread Herbert Fortes
On 09/11/2018 20:26, Colin Watson wrote: On Fri, Nov 09, 2018 at 05:41:53PM +, Matthew Vernon wrote: Ian Jackson writes: Matthew Vernon writes ("Re: salsa.debian.org: merge requests and such"): Colin Watson writes: This seems like a little bit of an overreaction to somebod

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Colin Watson
On Fri, Nov 09, 2018 at 07:42:13PM +, Holger Levsen wrote: > Granted, when I first experienced a git push not working after I > uploaded some package, I was also puzzled and a bit annoyed that someone > pushed into the master branch of 'my' package, but upon reflection I > decided: > > - this

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Colin Watson
On Fri, Nov 09, 2018 at 05:41:53PM +, Matthew Vernon wrote: > Ian Jackson writes: > > Matthew Vernon writes ("Re: salsa.debian.org: merge requests and such"): > >> Colin Watson writes: > >> > This seems like a little bit of an overreaction to somebody

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Holger Levsen
On Fri, Nov 09, 2018 at 05:41:53PM +, Matthew Vernon wrote: > The particular commit was fine (and had it come as a MR or bug report or > whatever I'd have had no problem with it at all). I'm not sure why you are so bothered by it. Granted, when I first experienced a git push not working

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Matthew Vernon
Ian Jackson writes: > Matthew Vernon writes ("Re: salsa.debian.org: merge requests and such"): >> Colin Watson writes: >> > This seems like a little bit of an overreaction to somebody removing a >> > single redundant line from a control file, though. Is

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Ian Jackson
Matthew Vernon writes ("Re: salsa.debian.org: merge requests and such"): > Colin Watson writes: > > This seems like a little bit of an overreaction to somebody removing a > > single redundant line from a control file, though. Is moving it really > > worth the

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Matthew Vernon
Jonathan Dowland writes: > On Fri, Nov 09, 2018 at 11:54:50AM +, Matthew Vernon wrote: >>Putting it under a personal namespace doesn't make it much less visible, >>and folk can still open MRs... > > Oh I beg to differ, there's a huge difference of visibility between the > "main" Debian

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Matthew Vernon
Colin Watson writes: > On Fri, Nov 09, 2018 at 11:54:50AM +, Matthew Vernon wrote: >> Jonathan Dowland writes: >> > On Tue, Nov 06, 2018 at 03:42:01PM +, Matthew Vernon wrote: >> >>Hm, I had not quite appreciated that was the expected behaviour. Ah >> >>well, I can move it :) >> > >> >

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Jonathan Dowland
(Please do not CC me, I am subscribed to the list and have set MFT accordingly, or at least think I have.) On Fri, Nov 09, 2018 at 11:54:50AM +, Matthew Vernon wrote: Putting it under a personal namespace doesn't make it much less visible, and folk can still open MRs... Oh I beg to

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Colin Watson
On Fri, Nov 09, 2018 at 11:54:50AM +, Matthew Vernon wrote: > Jonathan Dowland writes: > > On Tue, Nov 06, 2018 at 03:42:01PM +, Matthew Vernon wrote: > >>Hm, I had not quite appreciated that was the expected behaviour. Ah > >>well, I can move it :) > > > > Please re-consider whether this

Re: salsa.debian.org: merge requests and such

2018-11-09 Thread Matthew Vernon
Jonathan Dowland writes: > On Tue, Nov 06, 2018 at 03:42:01PM +, Matthew Vernon wrote: >>Hm, I had not quite appreciated that was the expected behaviour. Ah >>well, I can move it :) > > Please re-consider whether this trade-off (other people pushing to > master) is a small price to pay for

Re: salsa.debian.org: merge requests and such

2018-11-08 Thread Alex Muntada
Hi Jacob, > Ideally we’d change the default notification settings in Salsa > to always send emails but that won’t work because then all DDs > would get emails about all the merge requests in the Debian > group. I was wondering whether the following setup could work to have notifications enabled

Re: salsa.debian.org: merge requests and such

2018-11-08 Thread Alex Muntada
Hi Matthew, > Relatedly, what's the etiquette about commits to master? I > recently discovered that someone else had pushed a commit to > the tip of master of one of the packages I maintain (and not > notified me); when I complained I was told that emailing would > be too much effort. Am I wrong

Re: salsa.debian.org: merge requests and such

2018-11-08 Thread Guido Günther
Hi, On Tue, Nov 06, 2018 at 04:32:29PM +0100, Guillem Jover wrote: > Hi! > > On Tue, 2018-11-06 at 15:00:03 +, Matthew Vernon wrote: > > Jacob Adams writes: > > > The consensus seems to be that people should enable email > > > notifications in salsa and open a bug when filing a merge

Re: salsa.debian.org: merge requests and such

2018-11-07 Thread Andreas Metzler
Jonathan Dowland wrote: > On Tue, Nov 06, 2018 at 08:06:38PM +0100, Andreas Metzler wrote: >> Could we document this a little bit better in the wiki? This is >> completely different than on alioth, where collab-maint was suggested >> for basically everything that did not need a mailinglist. >>

Re: salsa.debian.org: merge requests and such

2018-11-07 Thread Jonathan Dowland
On Tue, Nov 06, 2018 at 08:06:38PM +0100, Andreas Metzler wrote: Could we document this a little bit better in the wiki? This is completely different than on alioth, where collab-maint was suggested for basically everything that did not need a mailinglist.

Re: salsa.debian.org: merge requests and such

2018-11-07 Thread Jonathan Dowland
On Tue, Nov 06, 2018 at 03:42:01PM +, Matthew Vernon wrote: Hm, I had not quite appreciated that was the expected behaviour. Ah well, I can move it :) Please re-consider whether this trade-off (other people pushing to master) is a small price to pay for the advantages to you and/or the

Re: salsa.debian.org: merge requests and such

2018-11-07 Thread Ondrej Novy
Hi, út 6. 11. 2018 v 16:46 odesílatel Felipe Sateler napsal: > > That seems completely reasonable. Making the repository accessible to > > others is a courtesy that should not be abused. Pushing directly to the > > master branch of a package for which one is not an active maintainer or > >

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Joseph Herlant
Hi, On Tue, Nov 6, 2018 at 11:07 AM Andreas Metzler wrote: > > Guillem Jover wrote: > > On Tue, 2018-11-06 at 15:00:03 +, Matthew Vernon wrote: > [...] > > >> that at least a MR is something I should have expected as a package > >> maintainer, not just commits to master? > cu And- plan for

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Andreas Metzler
Guillem Jover wrote: > On Tue, 2018-11-06 at 15:00:03 +, Matthew Vernon wrote: [...] >> that at least a MR is something I should have expected as a package >> maintainer, not just commits to master? > Assuming that packages is under the Salsa Debian namespace, then I > think that's what you

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Roberto C . Sánchez
On Tue, Nov 06, 2018 at 03:43:41PM +, Felipe Sateler wrote: > > I disagree when it comes to the debian namespace, and the documentation > agrees with me[1]. > Interesting. I was not aware of that. Thanks for sharing. Regards, -Roberto -- Roberto C. Sánchez

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Felipe Sateler
On Tue, 06 Nov 2018 10:17:01 -0500, Roberto C. Sánchez wrote: > On Tue, Nov 06, 2018 at 03:00:03PM +, Matthew Vernon wrote: >> >> Relatedly, what's the etiquette about commits to master? I recently >> discovered that someone else had pushed a commit to the tip of master >> of one of the

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Matthew Vernon
On 06/11/2018 15:32, Guillem Jover wrote: > Because, I'm not sure what's the point of hosting a git repo, on a > platform like gitlab with its trivial forking facilities, on a group > with wide write permissions, if you don't want others to directly > write to it? :) Hm, I had not quite

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Guillem Jover
Hi! On Tue, 2018-11-06 at 15:00:03 +, Matthew Vernon wrote: > Jacob Adams writes: > > The consensus seems to be that people should enable email > > notifications in salsa and open a bug when filing a merge request. > > > > https://lists.debian.org/debian-devel/2018/08/msg00235.html > > > >

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Roberto C . Sánchez
On Tue, Nov 06, 2018 at 03:00:03PM +, Matthew Vernon wrote: > > Relatedly, what's the etiquette about commits to master? I recently > discovered that someone else had pushed a commit to the tip of master of > one of the packages I maintain (and not notified me); when I complained > I was told

Re: salsa.debian.org: merge requests and such

2018-11-06 Thread Matthew Vernon
Jacob Adams writes: > The consensus seems to be that people should enable email > notifications in salsa and open a bug when filing a merge request. > > https://lists.debian.org/debian-devel/2018/08/msg00235.html > > https://lists.debian.org/debian-devel/2018/08/msg00259.html Relatedly, what's

Re: salsa.debian.org: merge requests and such

2018-10-29 Thread Joseph Herlant
Hi Ian, On Mon, Oct 29, 2018 at 3:51 AM Ian Jackson wrote: > If people don't like the emails it generates, this should be "fixed" > by disabling MRs rather than by disabling the email bridge. > > Do you know how to write such a thing ? Where would it be > configured ? (Eg, what if I want to

Re: salsa.debian.org: merge requests and such

2018-10-29 Thread Ian Jackson
Joseph Herlant writes ("Re: salsa.debian.org: merge requests and such"): > I wonder if we should have a custom integration enabled like we do for > setting the tags pending. It would send an email to the maintainer > when a MR or an issue would be created. > I don't ex

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Joseph Herlant
> “My concern is that newcomers will have their merge requests ignored when > maintainers are not emailed. I see no workable solution as yet, so I’ll have > to look more into this and come back to this thread when I find one.” I wonder if we should have a custom integration enabled like we do

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Steve McIntyre
David Bremner wrote: > >I'm not especially proud of it, but I mostly won't see things that don't >arrive in my mailbox. Polling web pages just isn't going to happen for >me. I understand other people have different ways of working, but I >suspect I'm not alone on relying on problems being reported

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Jacob Adams
> On Oct 28, 2018, at 09:44, Jacob Adams wrote: > > >> On Oct 28, 2018, at 08:11, Adam Borowski wrote: >> >> On Sat, Oct 27, 2018 at 12:46:00PM -0400, Jacob Adams wrote: On Oct 27, 2018, at 09:20, Holger Wansing wrote: It looks to me, that many merge requests are lying

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Jacob Adams
> On Oct 28, 2018, at 08:11, Adam Borowski wrote: > > On Sat, Oct 27, 2018 at 12:46:00PM -0400, Jacob Adams wrote: >>> On Oct 27, 2018, at 09:20, Holger Wansing wrote: >>> >>> It looks to me, that many merge requests are lying around on Salsa, but the >>> responsible package maintainers /

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Adam Borowski
On Sun, Oct 28, 2018 at 01:14:29PM +0100, Mattia Rizzolo wrote: > On Sun, Oct 28, 2018 at 01:11:28PM +0100, Adam Borowski wrote: > > Case in point: despite me having read the previous thread, and having set my > > repos accordingly (I don't even remember how to do that anymore!), there's > > a

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread David Bremner
Mattia Rizzolo writes: > At least now DDPO shows such things in the VCS column. I think the "!1" > is way too small and very easy to miss, but that can be improved if > anybody has a shed of ability with UIx/CSS… (which I don't) I'm not especially proud of it, but I mostly won't see things

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Mattia Rizzolo
On Sun, Oct 28, 2018 at 01:11:28PM +0100, Adam Borowski wrote: > Case in point: despite me having read the previous thread, and having set my > repos accordingly (I don't even remember how to do that anymore!), there's > a request rotting on a recent package: >

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Adam Borowski
On Sat, Oct 27, 2018 at 12:46:00PM -0400, Jacob Adams wrote: > > On Oct 27, 2018, at 09:20, Holger Wansing wrote: > > > > It looks to me, that many merge requests are lying around on Salsa, but the > > responsible package maintainers / teams are not aware of them. > > The consensus seems to be

Re: salsa.debian.org: merge requests and such

2018-10-28 Thread Holger Wansing
Hi, Joseph Herlant wrote: > Hi, > > > The consensus seems to be that people should enable email notifications in > > salsa and open a bug when filing a merge request. > > That's indeed the best way to make the bridge between the BTS and the > merge requests on Salsa. Unsure, if this is an

Re: salsa.debian.org: merge requests and such

2018-10-27 Thread Joseph Herlant
Hi, > The consensus seems to be that people should enable email notifications in > salsa and open a bug when filing a merge request. That's indeed the best way to make the bridge between the BTS and the merge requests on Salsa. Note that you can enable the notification programmatically

Re: salsa.debian.org: merge requests and such

2018-10-27 Thread Jacob Adams
> On Oct 27, 2018, at 09:20, Holger Wansing wrote: > > Hi all, > > how is the new Salsa collaborative concept supposed to work with the "old" > workflow in Debian? > > Means: it seems to me, that with Salsa there is a second parallel world is > getting evolved (in parallel to the old world: