Re: MBF proposal: python modules that fail to import

Em 16-04-2018 17:16, Helmut Grohne escreveu: > On Mon, Apr 16, 2018 at 04:14:21PM -0300, Herbert Fortes wrote: >> Package python3-dj-static is on the dd-list. But I can import it. >> >> # on a bananapi >> >> $ python3 >> Python 3.5.3 (default, Jan 19 2017, 14:11:04) >> [GCC 6.3.0 20170124] on

Re: MBF proposal: python modules that fail to import

> > In my initial mail there is a draft.gz that contains the proposed bug > reports. Searching for python3-dj-static yields: > > | After installing python3-dj-static importing the module dj_static > | into a python interpreter fails with the following error: > | > | Traceback (most recent call

Re: MBF proposal: python modules that fail to import

On Tuesday, April 17, 2018 10:45:29 AM Paul Wise wrote: > On Tue, Apr 17, 2018 at 5:00 AM, Helmut Grohne wrote: > > The difficult one is deriving the module name from the list of files. > > It should be just reading top_level.txt from the egg-info directory? For packages that use setuptools,

Re: MBF proposal: python modules that fail to import

On Tue, Apr 17, 2018 at 5:00 AM, Helmut Grohne wrote: > The difficult one is deriving the module name from the list of files. It should be just reading top_level.txt from the egg-info directory? -- bye, pabs https://wiki.debian.org/PaulWise

Re: MBF proposal: python modules that fail to import

On Mon, Apr 16, 2018 at 12:00:24PM +0200, Ondrej Novy wrote: > I tried to do my best :) > > https://sources.debian.org/src/autodep8/0.11.1/support/python/generate/ > > Feel free to add more "magic" for module name detection. There is an easy improvement and a difficult one I can propose. The

Re: MBF proposal: python modules that fail to import

Hi On 16-04-18 12:03, Ondrej Novy wrote: > I think it's good idea to mass commit this (adding Testsuite: > autopkgtest-pkg-python) into Git repos. We should probably merge this > list with Debian CI whitelist one. I assume you mean you want to mass commit the packages that are currently on the

Re: MBF proposal: python modules that fail to import

On Mon, Apr 16, 2018 at 04:14:21PM -0300, Herbert Fortes wrote: > Package python3-dj-static is on the dd-list. But I can import it. > > # on a bananapi > > $ python3 > Python 3.5.3 (default, Jan 19 2017, 14:11:04) > [GCC 6.3.0 20170124] on linux > Type "help", "copyright", "credits" or

Re: MBF proposal: python modules that fail to import

On Mon, Apr 16, 2018 at 01:44:48PM +0200, Piotr Ożarowski wrote: > [Helmut Grohne, 2018-04-15] > > Piotr Ożarowski > >python-changelog (U) > >python-sphinx-paramlinks (U) > >python3-changelog (U) > >python3-sphinx-paramlinks (U) > > These packages provide sphinx

Re: MBF proposal: python modules that fail to import

On Mon, 16 Apr 2018 at 16:14:21 -0300, Herbert Fortes wrote: > Package python3-dj-static is on the dd-list. But I can import it. ... > The package name uses '-' and the module '_'. I think this is a false positive in the preparation of the dd-list. /usr/share/autodep8/support/python/generate

Re: MBF proposal: python modules that fail to import

Hi, Em 15-04-2018 15:56, Helmut Grohne escreveu: > Hi, > > I was surprised to find a python module that failed to import thinking > that our qa would catch this. So I wondered how many other python > modules would fail to import and started a little yak shaving journey. > > It turns that this

Re: MBF proposal: python modules that fail to import

Hi, Quoting Adam Borowski (2018-04-15 22:30:47) > On Sun, Apr 15, 2018 at 09:45:45PM +0200, Helmut Grohne wrote: > > On Sun, Apr 15, 2018 at 09:38:27PM +0200, Christoph Biedl wrote: > > > The src:file package doesn't ship python{,3}-magic any longer, the change > > > was two months ago. Mind to

Re: MBF proposal: python modules that fail to import

[Helmut Grohne, 2018-04-15] > Piotr Ożarowski >python-changelog (U) >python-sphinx-paramlinks (U) >python3-changelog (U) >python3-sphinx-paramlinks (U) These packages provide sphinx plugins and have Enhances: python{,3}-sphinx Missing module is available after

Re: MBF proposal: python modules that fail to import

Hi Ondrej, On Mon, Apr 16, 2018 at 11:58:17AM +0200, Ondrej Novy wrote: > > sry. I only removed useless Testsuite: autopkgtest-pkg in git. > > Checking if d/tests already exists before adding autopkgtest-pkg-python is > really important. You can add autopkgtest-pkg-python even if there is >

Re: MBF proposal: python modules that fail to import

Hi, 2018-04-15 21:27 GMT+02:00 Helmut Grohne : > Note that autopkgtest-pkg-python is only applicable when the module name > matches the package name. That's true for the majority of packages, but > not for all (e.g. capitalization). Nevertheless, a lot of packages are >

Re: MBF proposal: python modules that fail to import

Hi, 2018-04-15 21:32 GMT+02:00 Mattia Rizzolo : > On Sun, Apr 15, 2018 at 09:27:30PM +0200, Helmut Grohne wrote: > > Note that autopkgtest-pkg-python is only applicable when the module name > > matches the package name. That's true for the majority of packages, but > > not for

Re: MBF proposal: python modules that fail to import

Hi, 2018-04-16 11:56 GMT+02:00 Ondrej Novy : > already done in git. > sry. I only removed useless Testsuite: autopkgtest-pkg in git. Checking if d/tests already exists before adding autopkgtest-pkg-python is really important. You can add autopkgtest-pkg-python even if there is

Re: MBF proposal: python modules that fail to import

Hi, 2018-04-16 11:47 GMT+02:00 Andreas Tille : > > W: python-csb source: unnecessary-testsuite-autopkgtest-field > ... > So before doing a MBF "Missing Testsuite: autopkgtest-pkg-python" > this should be checked as well. > already done in git. -- Best regards Ondřej Nový

Re: MBF proposal: python modules that fail to import

Hi Helmut, On Sun, Apr 15, 2018 at 09:27:30PM +0200, Helmut Grohne wrote: > > For more information: https://wiki.debian.org/Python/LibraryStyleGuide > > Note that autopkgtest-pkg-python is only applicable when the module name > matches the package name. That's true for the majority of packages,

Re: MBF proposal: python modules that fail to import

On Sun, Apr 15, 2018 at 09:45:45PM +0200, Helmut Grohne wrote: > On Sun, Apr 15, 2018 at 09:38:27PM +0200, Christoph Biedl wrote: > > > Christoph Biedl > > >file > > > > The src:file package doesn't ship python{,3}-magic any longer, the > > change was two

Re: MBF proposal: python modules that fail to import

On Sun, Apr 15, 2018 at 09:38:27PM +0200, Christoph Biedl wrote: > > Christoph Biedl > >file > > The src:file package doesn't ship python{,3}-magic any longer, the > change was two months ago. Mind to check how file got on this list? I used "apt-cache showsrc

Re: MBF proposal: python modules that fail to import

Helmut Grohne wrote... > Note that autopkgtest-pkg-python is only applicable when the module name > matches the package name. That's true for the majority of packages, but > not for all (e.g. capitalization). Nevertheless, a lot of packages are > missing the flag. Since I have the data at hand, I

Re: MBF proposal: python modules that fail to import

On Sun, Apr 15, 2018 at 09:27:30PM +0200, Helmut Grohne wrote: > On Sun, Apr 15, 2018 at 09:08:55PM +0200, Mattia Rizzolo wrote: > > BTW, last I heard from terceiro about this, I understood that whitelist > > is a workaround and packages are expected to add > > Testsuite:

Re: MBF proposal: python modules that fail to import

On Sunday, April 15, 2018 09:08:55 PM Mattia Rizzolo wrote: > On Sun, Apr 15, 2018 at 08:56:34PM +0200, Helmut Grohne wrote: > > Actually, there is autodep8 at ci.debian.net testing this already. It > > has a whitelist > > (https://salsa.debian.org/ci-team/debian-ci-config/blob/master/cookbooks/d

Re: MBF proposal: python modules that fail to import

On Sun, Apr 15, 2018 at 09:08:55PM +0200, Mattia Rizzolo wrote: > BTW, last I heard from terceiro about this, I understood that whitelist > is a workaround and packages are expected to add > Testsuite: autopkgtest-pkg-python > to their d/control. > > For more information:

Re: MBF proposal: python modules that fail to import

On Sun, Apr 15, 2018 at 08:56:34PM +0200, Helmut Grohne wrote: > Actually, there is autodep8 at ci.debian.net testing this already. It > has a whitelist > (https://salsa.debian.org/ci-team/debian-ci-config/blob/master/cookbooks/debci/files/default/whitelist-python.txt) > of around 800 packages

MBF proposal: python modules that fail to import

Hi, I was surprised to find a python module that failed to import thinking that our qa would catch this. So I wondered how many other python modules would fail to import and started a little yak shaving journey. It turns that this happens for 251 python modules. Since failure to import the main