Raphael Hertzog:
The tool looks neat (just discovered it via LWN.net) for reviewing single
patches but less so to review a full branch as you must submit a single
patch that combines all the commit of your branch.
Yes, therein lies what I see as its greatest flaw.
Really?
Really. That's
Raphael Hertzog:
If you have suggestions or ideas, go ahead. This is a very basic framework
to organize code reviews, it can surely be extended.
Or perhaps look at using a proper code review tool? Review Board -
http://www.reviewboard.org/ - is quite OK, and does have support for
handling
Hi,
Peter Krefting wrote:
Raphael Hertzog:
If you have suggestions or ideas, go ahead. This is a very basic
framework to organize code reviews, it can surely be extended.
Or perhaps look at using a proper code review tool? Review Board -
http://www.reviewboard.org/ - is quite OK, and does
Jonathan Nieder:
Is such a tool actually helpful when there are so few people involved?
They can be helpful to manage review queues and keep track of what has been
reviewed and what has not. And, unlike a Wiki page, they are built to do
just that.
And Review Board has a nice function that
On Fri, 07 May 2010, Peter Krefting wrote:
They can be helpful to manage review queues and keep track of what
has been reviewed and what has not. And, unlike a Wiki page, they
are built to do just that.
And reviewers can approve the patch as being ready to be included (and the
main list can
Peter Krefting pe...@softwolves.pp.se writes:
Raphael Hertzog:
If you have suggestions or ideas, go ahead. This is a very basic
framework to organize code reviews, it can surely be extended.
Or perhaps look at using a proper code review tool? Review Board -
http://www.reviewboard.org/ - is
Hi,
some of you have witnessed it, it's difficult to have a patch merged
in dpkg. There are multiple reasons for this but one of the most annoying
one is that patches are not reviewed in any timely fashion. Small patches
tend to be reviewed from time to time but bigger ones or those touching
core
7 matches
Mail list logo