Re: Bug#1122110: ITP: elpa-pangu-spacing -- Minor-mode to add space between Chinese and English characters.
Hi Yoshiki, Yoshiki Obinata writes: > Hi Xiyue, > > Obinata-san, please feel free to change it back to "pangu-spacing" if >> you prefer, and sorry for the trouble. > > I don't have any strong opinion to add emacs- prefix or not. Anyway, I > switched back to pangu-spacing. Please check. > > Best regards, > I saw that the project has now been moved under emacsen-team on Salsa. I have left a few comments on your commit. Let me know if you have any questions. > 2025年12月11日(木) 10:43 Xiyue Deng : > >> Sean Whitton writes: >> >> > Hello, >> > >> > On Wed 10 Dec 2025 at 07:29am -08, Xiyue Deng wrote: >> > >> >> Hi Sean, >> >> >> >> Sean Whitton writes: >> >> >> >>> Hello, >> >>> >> >>> On Tue 09 Dec 2025 at 09:56pm -08, Xiyue Deng wrote: >> >>> >> I saw that you added me as a developer to your repo. Thanks! I have >> a >> few generic comments before giving a detailed review: >> >> * I would suggest making the source package name >> `emacs-pangu-spacing'. >> The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" >> suffix if >> the name is too generic, though I do think it would be beneficial to >> make it clear that this is Emacs related. >> >>> >> >>> I think it should be just pangu-spacing unless this terminology "pangu" >> >>> is something people generally use outside of an Emacs context (IHNI). >> >>> >> >> >> >> Pangu is a god in Chinese mythology (see more in [1]) and I believe he >> >> is well known in Chinese speaking (or maybe even other Asian) countries. >> >> I think adding the "emacs-" prefix would make it more explicit that this >> >> package is emacs related, or people will need to jump through hoops to >> >> find its relation. >> > >> > Source package names should be more about respecting upstream's choices, >> > I think. Binary package names make it easy to find out. >> >> I found it helps in some cases if source package names gives good hints >> on its connection to Emacs, but as you said the binary package will be >> prefixed with "elpa-" anyway it may be good enough for searching >> purpose. Though I would still like to see the source package prefixed >> with "emacs-", I won't insist on it. >> >> Obinata-san, please feel free to change it back to "pangu-spacing" if >> you prefer, and sorry for the trouble. >> >> > >> > -- >> > Sean Whitton >> >> -- >> Regards, >> Xiyue Deng >> signature.asc Description: PGP signature
Re: Bug#1122110: ITP: elpa-pangu-spacing -- Minor-mode to add space between Chinese and English characters.
Hi Xiyue, Obinata-san, please feel free to change it back to "pangu-spacing" if > you prefer, and sorry for the trouble. I don't have any strong opinion to add emacs- prefix or not. Anyway, I switched back to pangu-spacing. Please check. Best regards, 2025年12月11日(木) 10:43 Xiyue Deng : > Sean Whitton writes: > > > Hello, > > > > On Wed 10 Dec 2025 at 07:29am -08, Xiyue Deng wrote: > > > >> Hi Sean, > >> > >> Sean Whitton writes: > >> > >>> Hello, > >>> > >>> On Tue 09 Dec 2025 at 09:56pm -08, Xiyue Deng wrote: > >>> > I saw that you added me as a developer to your repo. Thanks! I have > a > few generic comments before giving a detailed review: > > * I would suggest making the source package name > `emacs-pangu-spacing'. > The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" > suffix if > the name is too generic, though I do think it would be beneficial to > make it clear that this is Emacs related. > >>> > >>> I think it should be just pangu-spacing unless this terminology "pangu" > >>> is something people generally use outside of an Emacs context (IHNI). > >>> > >> > >> Pangu is a god in Chinese mythology (see more in [1]) and I believe he > >> is well known in Chinese speaking (or maybe even other Asian) countries. > >> I think adding the "emacs-" prefix would make it more explicit that this > >> package is emacs related, or people will need to jump through hoops to > >> find its relation. > > > > Source package names should be more about respecting upstream's choices, > > I think. Binary package names make it easy to find out. > > I found it helps in some cases if source package names gives good hints > on its connection to Emacs, but as you said the binary package will be > prefixed with "elpa-" anyway it may be good enough for searching > purpose. Though I would still like to see the source package prefixed > with "emacs-", I won't insist on it. > > Obinata-san, please feel free to change it back to "pangu-spacing" if > you prefer, and sorry for the trouble. > > > > > -- > > Sean Whitton > > -- > Regards, > Xiyue Deng > -- / * Yoshiki Obinata (大日方 慶樹) * JSK Robotics Lab, The Univ. of Tokyo /
Re: Bug#1122110: ITP: elpa-pangu-spacing -- Minor-mode to add space between Chinese and English characters.
Hi Xiyue,
* I would suggest making the source package name `emacs-pangu-spacing'.
> The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" suffix
> if
> the name is too generic, though I do think it would be beneficial to
> make it clear that this is Emacs related.
I updated both the salsa's project name and package name to
`emacs-pangu-spacing`.
* I would suggest running dh-make-elpa on a clean upstream repo to start
> from a clean state would help avoid many of the residuals from the
> default templates from dh-make.
I see. I pushed the only debianised commit to debian/master branch.
Can I work on the build issue?
Best regards,
2025年12月10日(水) 14:59 Xiyue Deng :
> Hi Obinata-san,
>
> Yoshiki Obinata writes:
>
> > Hi, Deng-san!
> >
> > Thank you for your response.
> >
> > Regarding the Debian packaging, I would suggest checking out the
> >> dh-make-elpa tool[1], which will provide a sensible default for most of
> >> the debian packaging files for an Emacs addon. The details can be found
> >> in its manpage ("man dh-make-elpa") which also contains a typical usage
> >> example for working on a new Emacs addons which I find very useful.
> >> Also checkout the Debian Emacsen team wiki[2] for more info.
> >
> > Thank you. I'll check it. Maybe using dh-make-elpa is the best way to
> > debianize.
> >
> > Meanwhile, as most of the Debian Emacs addons are maintained on
> >> Salsa[3], would you be interested in moving the packaging work there as
> >> well?
> >
> > Yes!
> > I have the salsa account. The ID is @mqcmd196.
> > https://salsa.debian.org/mqcmd196
> >
>
> I saw that you added me as a developer to your repo. Thanks! I have a
> few generic comments before giving a detailed review:
>
> * I would suggest making the source package name `emacs-pangu-spacing'.
> The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" suffix
> if
> the name is too generic, though I do think it would be beneficial to
> make it clear that this is Emacs related.
>
> * I would suggest running dh-make-elpa on a clean upstream repo to start
> from a clean state would help avoid many of the residuals from the
> default templates from dh-make.
>
> I think we can consider moving the repo to the Emacsen team once the
> source package name is settled.
>
> [1] https://wiki.debian.org/Teams/DebianEmacsenTeam
>
> > This is my first time contributing to the Debian team. Maybe I'll ask
> some
> > questions.
> >
> > Best, regards
> >
> > 2025年12月8日(月) 10:36 Xiyue Deng :
> >
> >> Hi Obinata-san,
> >>
> >> Yoshiki Obinata writes:
> >>
> >> > Package: wnpp
> >> > Severity: wishlist
> >> >
> >> > * Package name : elpa-pangu-spacing
> >> > Version : 0.4.0
> >> > Upstream Author : Yen-Chin Lee
> >> > * URL : https://github.com/coldnew/pangu-spacing
> >> > * License : GPL v3
> >> > Description : pangu-spacing-mode is an minor-mode to auto add space
> >> between
> >> > Chinese and English characters.
> >> >
> >> > I've already pushed the initial Debian commit to my local branch.
> >> > https://github.com/mqcmd196/pangu-spacing/tree/debian
> >> >
> >>
> >> Thanks for your interest in adding this package to Debian! I find it a
> >> very useful minor-mode as a Chinese.
> >>
> >> Regarding the Debian packaging, I would suggest checking out the
> >> dh-make-elpa tool[1], which will provide a sensible default for most of
> >> the debian packaging files for an Emacs addon. The details can be found
> >> in its manpage ("man dh-make-elpa") which also contains a typical usage
> >> example for working on a new Emacs addons which I find very useful.
> >> Also checkout the Debian Emacsen team wiki[2] for more info.
> >>
> >> Meanwhile, as most of the Debian Emacs addons are maintained on
> >> Salsa[3], would you be interested in moving the packaging work there as
> >> well?
> >>
> >> [1] https://tracker.debian.org/pkg/dh-make-elpa
> >> [2] https://wiki.debian.org/Teams/DebianEmacsenTeam
> >> [3] https://salsa.debian.org/emacsen-team
> >>
> >> > --
> >> > /
> >> > * Yoshiki Obinata (大日方 慶樹)
> >> > * JSK Robotics Lab, The Univ. of Tokyo
> >> > /
> >>
> >> --
> >> Regards,
> >> Xiyue Deng
> >>
> >
> >
> > --
> > /
> > * Yoshiki Obinata (大日方 慶樹)
> > * JSK Robotics Lab, The Univ. of Tokyo
> > /
>
> --
> Regards,
> Xiyue Deng
>
--
/
* Yoshiki Obinata (大日方 慶樹)
* JSK Robotics Lab, The Univ. of Tokyo
/
