Bug#840260: glibc: please support the tilegx architecture

[Helmut Grohne]

Hi Aurelien,

On Sat, Oct 15, 2016 at 09:15:36PM +0200, Aurelien Jarno wrote:
> Unfortunately this is not enough. Recent dak versions check that the
> architecture is known by dpkg, and ftp-master.debian.org is using
> jessie. If we add tilegx to the Architecture: list, the source package
> will then get rejected.

I agree.

> Please see #835851. Until this is solved or until ftp-master.debian.org
> is fixed, you will have to maintain the patch on your side.

I think this works rather well for me. You took the include change,
which is more relevant for me. rebootstrap automatically adds any
architectures that are missing from all libc*_archs to libc6_archs, so
there is nothing for me to maintain here. I probably won't even notice
when you apply it.

I hope it is ok for you to simply wait until dak has a sufficiently
recent dpkg and then add it. Bringing up full tilegx will take a while
anyway. Next up will be sending a patch for libatomic-ops.

Thanks for your support here.

Helmut

Bug#840260: glibc: please support the tilegx architecture

[Aurelien Jarno]

On 2016-10-10 06:52, Helmut Grohne wrote:
> Source: glibc
> Version: 2.24-3
> Severity: wishlist
> Tags: patch
> User: helm...@debian.org
> Usertags: rebootstrap
> 
> Hi Aurelien,
> 
> Can you add support for the tilegx architecture to glibc? dpkg knows
> about the architecture since 1.18.8 and gcc-6 has some preliminary

Unfortunately this is not enough. Recent dak versions check that the
architecture is known by dpkg, and ftp-master.debian.org is using
jessie. If we add tilegx to the Architecture: list, the source package
will then get rejected.

Please see #835851. Until this is solved or until ftp-master.debian.org
is fixed, you will have to maintain the patch on your side.

> support already. The patch is quite small. Beyond adding it to
> libc6_archs, care needs to be taken to use arch-specific linux headers
> from /usr/include//arch. After applying the patch,

This part has been merged in a different way (see my other email).

Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net


signature.asc
Description: PGP signature

Bug#840260: glibc: please support the tilegx architecture

[Aurelien Jarno]

On 2016-10-10 06:52, Helmut Grohne wrote:
> Source: glibc
> Version: 2.24-3
> Severity: wishlist
> Tags: patch
> User: helm...@debian.org
> Usertags: rebootstrap
> 
> Hi Aurelien,
> 
> Can you add support for the tilegx architecture to glibc? dpkg knows
> about the architecture since 1.18.8 and gcc-6 has some preliminary
> support already. The patch is quite small. Beyond adding it to
> libc6_archs, care needs to be taken to use arch-specific linux headers
> from /usr/include//arch. After applying the patch,
> debian/control must be regeneratd (not included in the patch). Can you
> maintain the diff?
> 
> Helmut

> diff --minimal -Nru glibc-2.24/debian/changelog glibc-2.24/debian/changelog
> --- glibc-2.24/debian/changelog   2016-09-17 20:00:44.0 +0200
> +++ glibc-2.24/debian/changelog   2016-10-10 06:36:11.0 +0200
> @@ -1,3 +1,10 @@
> +glibc (2.24-3.1) UNRELEASED; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Support tilegx. (Closes: #-1)
> +
> + -- Helmut Grohne   Mon, 10 Oct 2016 06:36:01 +0200
> +
>  glibc (2.24-3) unstable; urgency=medium
>  
>[ Aurelien Jarno ]
> diff --minimal -Nru glibc-2.24/debian/rules.d/control.mk 
> glibc-2.24/debian/rules.d/control.mk
> --- glibc-2.24/debian/rules.d/control.mk  2016-09-04 01:26:39.0 
> +0200
> +++ glibc-2.24/debian/rules.d/control.mk  2016-10-10 06:35:57.0 
> +0200
> @@ -1,7 +1,7 @@
>  libc_packages := libc6 libc6.1 libc0.1 libc0.3
>  libc0_1_archs := kfreebsd-amd64 kfreebsd-i386
>  libc0_3_archs := hurd-i386
> -libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
> mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc 
> sparc64 s390x sh4 x32
> +libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
> mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc 
> sparc64 s390x sh4 tilegx x32
>  libc6_1_archs := alpha
>  
>  control_deps := $(wildcard debian/control.in/*) $(addprefix 
> debian/control.in/, $(libc_packages))
> diff --minimal -Nru glibc-2.24/debian/sysdeps/linux.mk 
> glibc-2.24/debian/sysdeps/linux.mk
> --- glibc-2.24/debian/sysdeps/linux.mk2016-09-04 01:26:39.0 
> +0200
> +++ glibc-2.24/debian/sysdeps/linux.mk2016-10-10 06:35:21.0 
> +0200
> @@ -39,6 +39,11 @@
>   else \
>   ln -s $(LINUX_HEADERS)/asm debian/include ; \
>   fi
> + if [ -d "$(LINUX_ARCH_HEADERS)/arch" ]; then \
> + ln -s $(LINUX_ARCH_HEADERS)/arch debian/include ; \
> + else \
> + ln -s $(LINUX_HEADERS)/arch debian/include ; \
> + fi

It seems /usr/include//arch is something tilegx specific, so it
means it will create a dead symlink on other architectures. Not sure
it will cause any arm, but it's not very nice.

Anyway don't need to submit a new patch, I think it's time to rewrite
this part of code with a for loop instead of adding many more similar
lines. I'll work on that.

Otherwise the patch looks fine to me.

Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Bug#840260: glibc: please support the tilegx architecture

[Helmut Grohne]

Source: glibc
Version: 2.24-3
Severity: wishlist
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

Hi Aurelien,

Can you add support for the tilegx architecture to glibc? dpkg knows
about the architecture since 1.18.8 and gcc-6 has some preliminary
support already. The patch is quite small. Beyond adding it to
libc6_archs, care needs to be taken to use arch-specific linux headers
from /usr/include//arch. After applying the patch,
debian/control must be regeneratd (not included in the patch). Can you
maintain the diff?

Helmut
diff --minimal -Nru glibc-2.24/debian/changelog glibc-2.24/debian/changelog
--- glibc-2.24/debian/changelog 2016-09-17 20:00:44.0 +0200
+++ glibc-2.24/debian/changelog 2016-10-10 06:36:11.0 +0200
@@ -1,3 +1,10 @@
+glibc (2.24-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Support tilegx. (Closes: #-1)
+
+ -- Helmut Grohne   Mon, 10 Oct 2016 06:36:01 +0200
+
 glibc (2.24-3) unstable; urgency=medium
 
   [ Aurelien Jarno ]
diff --minimal -Nru glibc-2.24/debian/rules.d/control.mk 
glibc-2.24/debian/rules.d/control.mk
--- glibc-2.24/debian/rules.d/control.mk2016-09-04 01:26:39.0 
+0200
+++ glibc-2.24/debian/rules.d/control.mk2016-10-10 06:35:57.0 
+0200
@@ -1,7 +1,7 @@
 libc_packages := libc6 libc6.1 libc0.1 libc0.3
 libc0_1_archs := kfreebsd-amd64 kfreebsd-i386
 libc0_3_archs := hurd-i386
-libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc sparc64 
s390x sh4 x32
+libc6_archs   := amd64 arm64 armel armhf hppa i386 m68k mips mipsel mipsn32 
mipsn32el mips64 mips64el nios2 powerpc powerpcspe ppc64 ppc64el sparc sparc64 
s390x sh4 tilegx x32
 libc6_1_archs := alpha
 
 control_deps := $(wildcard debian/control.in/*) $(addprefix 
debian/control.in/, $(libc_packages))
diff --minimal -Nru glibc-2.24/debian/sysdeps/linux.mk 
glibc-2.24/debian/sysdeps/linux.mk
--- glibc-2.24/debian/sysdeps/linux.mk  2016-09-04 01:26:39.0 +0200
+++ glibc-2.24/debian/sysdeps/linux.mk  2016-10-10 06:35:21.0 +0200
@@ -39,6 +39,11 @@
else \
ln -s $(LINUX_HEADERS)/asm debian/include ; \
fi
+   if [ -d "$(LINUX_ARCH_HEADERS)/arch" ]; then \
+   ln -s $(LINUX_ARCH_HEADERS)/arch debian/include ; \
+   else \
+   ln -s $(LINUX_HEADERS)/arch debian/include ; \
+   fi
ln -s $(LINUX_HEADERS)/asm-generic debian/include
ln -s $(LINUX_HEADERS)/linux debian/include