Re: Access to Debian Go's Salsa group page
On Fri, Oct 13, 2023 at 10:15:16AM +0100, Tom Parkin wrote: > On Thu, Oct 12, 2023 at 15:17:11 +0530, Nilesh Patra wrote: > > Please also cleanup: > > W: go-l2tp: groff-message troff::112: warning: cannot > > select font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:2] > > W: go-l2tp: groff-message troff::136: warning: cannot > > select font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:2] > > W: go-l2tp: groff-message troff::36: warning: cannot select > > font 'C' [usr/share/man/man1/kpppoed.1.gz:1] > > W: go-l2tp: groff-message troff::48: warning: cannot select > > font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:1] > > W: go-l2tp: groff-message troff::54: warning: cannot select > > font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:1] > > Sorry to bother you again but could you tell me how you generated > these warnings? I don't see them from "gbp buildpackage" or lintian > under bookworm. I could see it with lintian in an unstable schroot. My _guess_ is you're using on older version of groff. With the latest 1.23.0-2 you should be able to see this. Let me know if not. Best, Nilesh signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Nilesh, On Thu, Oct 12, 2023 at 15:17:11 +0530, Nilesh Patra wrote: > Please also cleanup: > W: go-l2tp: groff-message troff::112: warning: cannot select > font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:2] > W: go-l2tp: groff-message troff::136: warning: cannot select > font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:2] > W: go-l2tp: groff-message troff::36: warning: cannot select > font 'C' [usr/share/man/man1/kpppoed.1.gz:1] > W: go-l2tp: groff-message troff::48: warning: cannot select > font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:1] > W: go-l2tp: groff-message troff::54: warning: cannot select > font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:1] Sorry to bother you again but could you tell me how you generated these warnings? I don't see them from "gbp buildpackage" or lintian under bookworm. signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
On Thu, Oct 12, 2023 at 18:38:14 +0530, Nilesh Patra wrote: > On Thu, Oct 12, 2023 at 12:40:45PM +0100, Tom Parkin wrote: > > On Thu, Oct 12, 2023 at 15:17:11 +0530, Nilesh Patra wrote: > Primary usecase is what defined the source package name. If it is > supposed to be mainly a library, then the naming should be > golang-github-foo, and foo otherwise. If it should be used as a library, > the "source package" name also needs to be changed. Thanks for clarifying and ack on the required fixups. > > I'm not sure what to do for the best here. > > I mean, upto you. It'd probably make sense to think of what is the major > component, or what people are more interested in consuming. If it's an > application then I'll just rename it on salsa. Otherwise it needs other > fixes as I stated above. Understood. I think on balance it probably makes sense to use the library naming convention. Although the current driver for Debian packaging is making it easier for users of nm-l2tp to use kl2tpd, the fact remains that go-l2tp as a whole is a library. So choosing the library package name will hopefully make things easier in the future if/when another project has go-l2tp as a dependency. > Ping on the list and maybe CC me when you're done. I'm a Debian > Developer and can help with sponsoring. Smashing, thank you -- much appreciated. All the best, Tom signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
On Thu, Oct 12, 2023 at 12:40:45PM +0100, Tom Parkin wrote: > On Thu, Oct 12, 2023 at 15:17:11 +0530, Nilesh Patra wrote: > > Is this package also supposed to be used as a library? If so please > > provide a library package as well. > > Yes it is. > > I'm not really sure of the semantics of both v.s. combined. > > My assumption is that the primary usecase of the package should > probably dictate what comes first in the control file. Primary usecase is what defined the source package name. If it is supposed to be mainly a library, then the naming should be golang-github-foo, and foo otherwise. If it should be used as a library, the "source package" name also needs to be changed. In your case, the source package name (the one mentioned in d/ch and d/control is go-l2tp however just the salsa repo name is different). > Naively, "both" would mean we don't need to rename the repo :-) and > fits more coherently with the upstream's intentions. go-l2tp is > really supposed to be a library for L2TP applications, and kl2tpd > et al are demo apps as much as anything else, albeit useful ones. > > However, from a pragmatic perspective while I know go-l2tp does have > users building apps around it, as of now the goal of packaging go-l2tp > for Debian is to make nm-l2tp's life easier, as nm-l2tp uses kl2tpd > as its default L2TP daemon. So from that perspective "combined" > seems a more natural fit. > > I'm not sure what to do for the best here. I mean, upto you. It'd probably make sense to think of what is the major component, or what people are more interested in consuming. If it's an application then I'll just rename it on salsa. Otherwise it needs other fixes as I stated above. Ping on the list and maybe CC me when you're done. I'm a Debian Developer and can help with sponsoring. > [1]. https://people.debian.org/~stapelberg/2015/07/27/dh-make-golang.html Best, Nilesh signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Sebastian, On Thu, Oct 12, 2023 at 11:27:01 +0100, Sebastian Crane wrote: > Unfortunately I can't help further at the moment, because I'm going to > be away travelling for quite a while - but if you would like to have a > Jitsi/Zoom chat sometime in November I would be more than happy to > help with any questions you might still have about Debian packaging :) Thanks for your review comments to date, and I hope your travels are enjoyable! I'll also bear in mind your kind offer for a Jitsi/Zoom chat: much appreciated. All the best, Tom signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Nilesh, Thanks for your review! On Thu, Oct 12, 2023 at 15:17:11 +0530, Nilesh Patra wrote: > What is the reason for naming the repository as > "golang-github-katalix-go-l2tp" when the package's name is just > "go-l2tp"? Arg, yes. Digging back through my notes I realise that I was making reference to the dh-make-golang tutorial[1] when I created the salsa project. Because the tutorial is dealing with a library I used the library naming convention by mistake :-( I've just re-run dh-make-golang now and of course it is detecting that go-l2tp is a program because it defines a main package. So it's using the program naming convention. Hence the inconsistency. I guess we should perhaps rename the project/repos? (modulo the outcome of the next question below...) > Is this package also supposed to be used as a library? If so please > provide a library package as well. Yes it is. I've just tried re-running dh-make-golang with the types "both" and "combined" to see what it spits out: * "both" (or lib+prog): repo is called 'golang-github-go-l2tp', the -dev package is listed first in debian/control * "combined" (or prog+lib): repo is called 'go-l2tp', the program package is listed first in debian/control I'm not really sure of the semantics of both v.s. combined. My assumption is that the primary usecase of the package should probably dictate what comes first in the control file. Naively, "both" would mean we don't need to rename the repo :-) and fits more coherently with the upstream's intentions. go-l2tp is really supposed to be a library for L2TP applications, and kl2tpd et al are demo apps as much as anything else, albeit useful ones. However, from a pragmatic perspective while I know go-l2tp does have users building apps around it, as of now the goal of packaging go-l2tp for Debian is to make nm-l2tp's life easier, as nm-l2tp uses kl2tpd as its default L2TP daemon. So from that perspective "combined" seems a more natural fit. I'm not sure what to do for the best here. > Since ql2tpd, kl2tpd require root permissions, isn't /usr/sbin a better > location for them? Yes you're right, I'll look into fixing that up. > Please also cleanup: > W: go-l2tp: groff-message troff::112: warning: cannot select > font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:2] > W: go-l2tp: groff-message troff::136: warning: cannot select > font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:2] > W: go-l2tp: groff-message troff::36: warning: cannot select > font 'C' [usr/share/man/man1/kpppoed.1.gz:1] > W: go-l2tp: groff-message troff::48: warning: cannot select > font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:1] > W: go-l2tp: groff-message troff::54: warning: cannot select > font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:1] Ack, will do. Thanks again! Tom [1]. https://people.debian.org/~stapelberg/2015/07/27/dh-make-golang.html signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Dear Tom, > I just wanted to ping back on this in case there is anything more > needed on my side. > > I'm hoping review comments to date are all addressed: is there > anything further I need to do to get the package submitted? > > Apologies if I'm being impatient: I don't mean to be, I'm just worried > as someone new to Debian packaging that I've missed something I need > to do! Unfortunately I can't help further at the moment, because I'm going to be away travelling for quite a while - but if you would like to have a Jitsi/Zoom chat sometime in November I would be more than happy to help with any questions you might still have about Debian packaging :) Best wishes, Sebastian
Re: Access to Debian Go's Salsa group page
What is the reason for naming the repository as "golang-github-katalix-go-l2tp" when the package's name is just "go-l2tp"? Is this package also supposed to be used as a library? If so please provide a library package as well. Since ql2tpd, kl2tpd require root permissions, isn't /usr/sbin a better location for them? Please also cleanup: W: go-l2tp: groff-message troff::112: warning: cannot select font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:2] W: go-l2tp: groff-message troff::136: warning: cannot select font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:2] W: go-l2tp: groff-message troff::36: warning: cannot select font 'C' [usr/share/man/man1/kpppoed.1.gz:1] W: go-l2tp: groff-message troff::48: warning: cannot select font 'C' [usr/share/man/man5/kl2tpd.toml.5.gz:1] W: go-l2tp: groff-message troff::54: warning: cannot select font 'C' [usr/share/man/man5/ql2tpd.toml.5.gz:1] signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Sebastian and list, I just wanted to ping back on this in case there is anything more needed on my side. I'm hoping review comments to date are all addressed: is there anything further I need to do to get the package submitted? Apologies if I'm being impatient: I don't mean to be, I'm just worried as someone new to Debian packaging that I've missed something I need to do! Best regards, Tom On Thu, Sep 21, 2023 at 15:58:08 +0100, Tom Parkin wrote: > Hi again Sebastian, > > Just to follow up on my earlier email: > > > 1. I have pushed my packaging tree to Salsa[1], including both the > 'upstream' and 'debian/sid' branches. > > > 2. I've reworked the package description so it's more in line with > the ITP bug wording. I think this is more specific to what is > actually packaged. > > I've also removed go-l2tp.lintian-overrides file since the override > is no longer required. > > > 3. I confirm that 'override_dh_auto_install' was autogenerated by the > dh-make-golang tool (per Cyril's earlier remarks). > > FWIW, dh-make-golang's behaviour here seems to date back to 2018 > or so in the dh-make-golang git repo -- there's an issue there > which describes the rationale[2]. > > I had a quick look at some other "program" type packages (e.g. > cgo, elvish) which have the same override, but it doesn't seem to > be universally applied so far as I can make out, so I'm not sure > what the best thing to do here is. > > Should I keep the override do you think? > > > Finally, I notice that lintian reports a couple of issues related to > binary hardening: > > * W: go-l2tp: hardening-no-pie [usr/bin/kl2tpd] > * I: go-l2tp: hardening-no-bindnow [usr/bin/kl2tpd] > > I'm not sure how to fix these in the context of the go toolchain. > Should I add lintian overrides for these, or somehow address them in > the build process? > > Thanks again and best regards, > Tom > > [1]. https://salsa.debian.org/go-team/packages/golang-github-katalix-go-l2tp > [2]. https://github.com/Debian/dh-make-golang/issues/57 > > On Thu, Sep 21, 2023 at 12:20:50 +0100, Sebastian Crane wrote: > > Dear Tom, > > > > Welcome to the Debian Go Packaging Team! I've reviewed your packaging > > on your GitHub repository and have some suggestions and comments. > > > > - You'll need to push an 'upstream' branch as well as the 'debian/sid' > > branch to Salsa when you get access. > > > > - The description shouldn't be the whole README; you can just have 'Go > > library for building L2TP applications on Linux systems' on the first > > line and the list of features as the extended description. If you > > think it's important that users have access to the documentation, you > > can put something in /usr/share/doc (it looks like you've already got > > manpages there already). It is generally unusual to have extra > > documentation for Go libraries in Debian, since they aren't really > > intended for use outside of making other Debian software work. > > > > - If you abridge the description, you can also delete > > go-l2tp.lintian-overrides. > > > > - Why do you have an 'override_dh_auto_install' rule in the Makefile? I > > don't know if something has changed recently in dh-make-golang, but it > > wasn't there last time I used it. > > > > All in all, I think it looks pretty close to upload :) > > > > Best wishes, > > > > Sebastian > > > > > > On Thu, Sep 21, 2023 at 11:58:12AM +0100, Tom Parkin wrote: > > > Hi all, > > > > > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > > > project[1]. > > > > > > I have followed the dh-make-golang tutorial and produced working > > > packaging which builds using gbp buildpackage[2]. > > > > > > I have a Salsa account, and have created the > > > golang-github-katalix-go-l2tp project -- however I don't have > > > permissions to push code to the project yet. Hopefully this won't > > > cause a problem! > > > > > > I'd like to request a review of my packaging and request sponsorship > > > for upload. > > > > > > Many thanks, > > > Tom > > > > > > [1]. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051983 > > > [2]. https://github.com/katalix/go-l2tp-debian signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Afeedh, Afeedh Shaji (2023-09-23): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > Hi all, > > I am Afeedh Shaji, and I'm working on a Debian package for the go-color > project[1]. > Please find my ITP here[2]. > > I have a Salsa account (`https://salsa.debian.org/afeedh`), and have created > the repo: > `https://salsa.debian.org/go-team/packages/golang-github-gookit-color`. > However I don't > have permissions to push code to the project yet. Requesting the team to > grant me access > to do so. Please let me know if any additional details are needed from my > side. If you look at a team's page (e.g. https://salsa.debian.org/go-team) you should see a button to request access, but asking on this ML is fine too: I've just invited you into the team, with the usual Developer role. Welcome! Cheers, -- Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/ signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
On Thu, Sep 21, 2023 at 10:58 PM Tom Parkin wrote: [...] > Finally, I notice that lintian reports a couple of issues related to > binary hardening: > > * W: go-l2tp: hardening-no-pie [usr/bin/kl2tpd] > * I: go-l2tp: hardening-no-bindnow [usr/bin/kl2tpd] No, you don't need to. Once https://salsa.debian.org/lintian/lintian/-/merge_requests/456 is merged, lintian will be silent for that. -- Shengjing Zhu
Re: Access to Debian Go's Salsa group page
Hi again Sebastian, Just to follow up on my earlier email: 1. I have pushed my packaging tree to Salsa[1], including both the 'upstream' and 'debian/sid' branches. 2. I've reworked the package description so it's more in line with the ITP bug wording. I think this is more specific to what is actually packaged. I've also removed go-l2tp.lintian-overrides file since the override is no longer required. 3. I confirm that 'override_dh_auto_install' was autogenerated by the dh-make-golang tool (per Cyril's earlier remarks). FWIW, dh-make-golang's behaviour here seems to date back to 2018 or so in the dh-make-golang git repo -- there's an issue there which describes the rationale[2]. I had a quick look at some other "program" type packages (e.g. cgo, elvish) which have the same override, but it doesn't seem to be universally applied so far as I can make out, so I'm not sure what the best thing to do here is. Should I keep the override do you think? Finally, I notice that lintian reports a couple of issues related to binary hardening: * W: go-l2tp: hardening-no-pie [usr/bin/kl2tpd] * I: go-l2tp: hardening-no-bindnow [usr/bin/kl2tpd] I'm not sure how to fix these in the context of the go toolchain. Should I add lintian overrides for these, or somehow address them in the build process? Thanks again and best regards, Tom [1]. https://salsa.debian.org/go-team/packages/golang-github-katalix-go-l2tp [2]. https://github.com/Debian/dh-make-golang/issues/57 On Thu, Sep 21, 2023 at 12:20:50 +0100, Sebastian Crane wrote: > Dear Tom, > > Welcome to the Debian Go Packaging Team! I've reviewed your packaging > on your GitHub repository and have some suggestions and comments. > > - You'll need to push an 'upstream' branch as well as the 'debian/sid' > branch to Salsa when you get access. > > - The description shouldn't be the whole README; you can just have 'Go > library for building L2TP applications on Linux systems' on the first > line and the list of features as the extended description. If you > think it's important that users have access to the documentation, you > can put something in /usr/share/doc (it looks like you've already got > manpages there already). It is generally unusual to have extra > documentation for Go libraries in Debian, since they aren't really > intended for use outside of making other Debian software work. > > - If you abridge the description, you can also delete > go-l2tp.lintian-overrides. > > - Why do you have an 'override_dh_auto_install' rule in the Makefile? I > don't know if something has changed recently in dh-make-golang, but it > wasn't there last time I used it. > > All in all, I think it looks pretty close to upload :) > > Best wishes, > > Sebastian > > > On Thu, Sep 21, 2023 at 11:58:12AM +0100, Tom Parkin wrote: > > Hi all, > > > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > > project[1]. > > > > I have followed the dh-make-golang tutorial and produced working > > packaging which builds using gbp buildpackage[2]. > > > > I have a Salsa account, and have created the > > golang-github-katalix-go-l2tp project -- however I don't have > > permissions to push code to the project yet. Hopefully this won't > > cause a problem! > > > > I'd like to request a review of my packaging and request sponsorship > > for upload. > > > > Many thanks, > > Tom > > > > [1]. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051983 > > [2]. https://github.com/katalix/go-l2tp-debian signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Sebastian Crane (2023-09-21):
> - Why do you have an 'override_dh_auto_install' rule in the Makefile?
> I don't know if something has changed recently in dh-make-golang,
> but it wasn't there last time I used it.
Skipping the source is standard for program (as opposed to library)
packages?
Confirmed in the source code (template.go, writeDebianRules):
if pkgType == typeProgram {
fmt.Fprintf(f, "\n")
fmt.Fprintf(f, "override_dh_auto_install:\n")
fmt.Fprintf(f, "\tdh_auto_install -- --no-source\n")
}
(Also used by dh-make-golang's own debian/rules.)
Cheers,
--
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
signature.asc
Description: PGP signature
Re: Access to Debian Go's Salsa group page
Hi Sebastian, On Thu, Sep 21, 2023 at 12:20:50 +0100, Sebastian Crane wrote: > - You'll need to push an 'upstream' branch as well as the 'debian/sid' > branch to Salsa when you get access. No problem -- I wasn't quite sure of the order in which to generate ITP and upload to Salsa, etc, so ended up putting my work on GitHub for the time being. I'll ensure the upstream branch is also pushed to Salsa. > - The description shouldn't be the whole README; you can just have 'Go > library for building L2TP applications on Linux systems' on the first > line and the list of features as the extended description. If you > think it's important that users have access to the documentation, you > can put something in /usr/share/doc (it looks like you've already got > manpages there already). It is generally unusual to have extra > documentation for Go libraries in Debian, since they aren't really > intended for use outside of making other Debian software work. I understand. I'll trim the description down. > - If you abridge the description, you can also delete > go-l2tp.lintian-overrides. Ack, will do. > - Why do you have an 'override_dh_auto_install' rule in the Makefile? I > don't know if something has changed recently in dh-make-golang, but it > wasn't there last time I used it. Hmm. I'll double check that. I don't *think* I did anything extra here, so I suspect that dh-make-golang produced this output but I will investigate further. > All in all, I think it looks pretty close to upload :) Ace -- many thanks for the review :-) Tom signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
On Thu, Sep 21, 2023 at 13:12:55 +0200, Cyril Brulebois wrote: > Hi Tom, > > Tom Parkin (2023-09-21): > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > > project[1]. > > > > I have followed the dh-make-golang tutorial and produced working > > packaging which builds using gbp buildpackage[2]. > > > > I have a Salsa account, and have created the > > golang-github-katalix-go-l2tp project -- however I don't have > > permissions to push code to the project yet. Hopefully this won't > > cause a problem! > > > > I'd like to request a review of my packaging and request sponsorship > > for upload. > > I've accepted the access request for @tomparkin, welcome! I'll let > someone else review/upload though. Thank you Cyril :-) signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
Dear Tom, Welcome to the Debian Go Packaging Team! I've reviewed your packaging on your GitHub repository and have some suggestions and comments. - You'll need to push an 'upstream' branch as well as the 'debian/sid' branch to Salsa when you get access. - The description shouldn't be the whole README; you can just have 'Go library for building L2TP applications on Linux systems' on the first line and the list of features as the extended description. If you think it's important that users have access to the documentation, you can put something in /usr/share/doc (it looks like you've already got manpages there already). It is generally unusual to have extra documentation for Go libraries in Debian, since they aren't really intended for use outside of making other Debian software work. - If you abridge the description, you can also delete go-l2tp.lintian-overrides. - Why do you have an 'override_dh_auto_install' rule in the Makefile? I don't know if something has changed recently in dh-make-golang, but it wasn't there last time I used it. All in all, I think it looks pretty close to upload :) Best wishes, Sebastian On Thu, Sep 21, 2023 at 11:58:12AM +0100, Tom Parkin wrote: > Hi all, > > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > project[1]. > > I have followed the dh-make-golang tutorial and produced working > packaging which builds using gbp buildpackage[2]. > > I have a Salsa account, and have created the > golang-github-katalix-go-l2tp project -- however I don't have > permissions to push code to the project yet. Hopefully this won't > cause a problem! > > I'd like to request a review of my packaging and request sponsorship > for upload. > > Many thanks, > Tom > > [1]. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051983 > [2]. https://github.com/katalix/go-l2tp-debian > -- > Tom Parkin > Katalix Systems Ltd > https://katalix.com > Catalysts for your Embedded Linux software development
Re: Access to Debian Go's Salsa group page
Hi Tom, Tom Parkin (2023-09-21): > I am Tom Parkin, and I'm working on a Debian package for the go-l2tp > project[1]. > > I have followed the dh-make-golang tutorial and produced working > packaging which builds using gbp buildpackage[2]. > > I have a Salsa account, and have created the > golang-github-katalix-go-l2tp project -- however I don't have > permissions to push code to the project yet. Hopefully this won't > cause a problem! > > I'd like to request a review of my packaging and request sponsorship > for upload. I've accepted the access request for @tomparkin, welcome! I'll let someone else review/upload though. Cheers, -- Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/ signature.asc Description: PGP signature
Re: Access to Debian Go's Salsa group page
On Tue, Aug 8, 2023 at 3:47 PM Nilesh Patra wrote: > Added, welcome! Thank you Nilesh! And thank you Sebastian for providing feedback! Best regards, Raul.
Re: Access to Debian Go's Salsa group page
On 08/07/2023 9:20 PM IST rcheleguini wrote: > My name is Raul, and I am working to have a Go dependency packaged for > Debian [1]. I have just requested access to Debian Go's Salsa group page > (username: rcheleguini), and I kindly ask to be reviewed and approved. Added, welcome! Best, Nilesh
Re: Access to Debian Go's Salsa group page
Dear Raul, > My name is Raul, and I am working to have a Go dependency packaged for > Debian [1]. I have just requested access to Debian Go's Salsa group page > (username: rcheleguini), and I kindly ask to be reviewed and approved. Welcome! While you wait for access on Salsa to be granted by a DD, I'll chip in with some feedback on the package itself. It builds perfectly on my machine with a few minor Lintian complaints. I think you can simplify the description in debian/control a bit, as it's currently copied from the upstream README - for instance, there is no need to specify a minimum version of Go since we always make sure that it will be compatible on Debian. Best wishes, Sebastian
