On Wed, 2014-10-22 at 01:21 +0200, Samuel Thibault wrote:
Svante Signell, le Tue 21 Oct 2014 12:34:22 +0200, a écrit :
static gboolean
asb_utils_is_file_in_tmpdir (const gchar *tmpdir, const gchar *filename)
{
- gchar tmp[PATH_MAX];
- g_snprintf (tmp, PATH_MAX, %s/%s, tmpdir,
Svante Signell, le Wed 22 Oct 2014 10:21:36 +0200, a écrit :
Is this better?
Yes.
But it'd be good that you manage to spot those errors yourself at some
point. You seem to keep doing them...
Samuel
--
To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org
with a subject of
On 2014-10-22 10:21, Svante Signell wrote:
On Wed, 2014-10-22 at 01:21 +0200, Samuel Thibault wrote:
Svante Signell, le Tue 21 Oct 2014 12:34:22 +0200, a écrit :
static gboolean
asb_utils_is_file_in_tmpdir (const gchar *tmpdir, const gchar
*filename)
{
- gchar tmp[PATH_MAX];
-
On Wed, 2014-10-22 at 10:29 +0200, Pino Toscano wrote:
On 2014-10-22 10:21, Svante Signell wrote:
On Wed, 2014-10-22 at 01:21 +0200, Samuel Thibault wrote:
Svante Signell, le Tue 21 Oct 2014 12:34:22 +0200, a écrit :
+ free (tmp);
+ return ret;
}
glib has
On 2014-10-22 10:59, Svante Signell wrote:
On Wed, 2014-10-22 at 10:29 +0200, Pino Toscano wrote:
On 2014-10-22 10:21, Svante Signell wrote:
On Wed, 2014-10-22 at 01:21 +0200, Samuel Thibault wrote:
Svante Signell, le Tue 21 Oct 2014 12:34:22 +0200, a écrit :
+ free (tmp);
+
On Wed, 2014-10-22 at 11:11 +0200, Pino Toscano wrote:
On 2014-10-22 10:59, Svante Signell wrote:
Updated patch attached. For the first part of the patch, I don't find
using g_strdup_printf() is an advantage over g_malloc(), since later
on
g_realloc() is needed.
The other option is
Svante Signell, le Wed 22 Oct 2014 11:33:39 +0200, a écrit :
On Wed, 2014-10-22 at 11:11 +0200, Pino Toscano wrote:
On 2014-10-22 10:59, Svante Signell wrote:
Updated patch attached. For the first part of the patch, I don't find
using g_strdup_printf() is an advantage over
Source: appstream-glib
Version: 0.3.0-1
Severity: important
Tags: patch
User: debian-hurd@lists.debian.org
Usertags: hurd
Hi,
Currently appstream-glib FTBFS on GNU/Hurd due to usage of PATH_MAX,
which is not defined. The attached patch solves this problem by
dynamically allocating strings of
Svante Signell, le Tue 21 Oct 2014 12:34:22 +0200, a écrit :
static gboolean
asb_utils_is_file_in_tmpdir (const gchar *tmpdir, const gchar *filename)
{
- gchar tmp[PATH_MAX];
- g_snprintf (tmp, PATH_MAX, %s/%s, tmpdir, filename);
+ gsize len = strlen (tmpdir) + 1 + strlen
9 matches
Mail list logo