Re: GRUB unexpected trap in Itanium

[Pedro Miguel Justo]

> On Aug 11, 2023, at 09:27, John Paul Adrian Glaubitz 
>  wrote:
> 
> Hello Pedro!
> 
> Thanks for bisecting this. Please always make sure to CC the original author 
> of
> the patch so he becomes aware of the breakage that was introduced by his 
> patch.
> 

Hi Adrian. That was my oversight. That's what comes out when trying to wrap it 
in a hurry at 2am. 

Sorry for any confusion it might have caused.

Re: GRUB unexpected trap in Itanium

[John Paul Adrian Glaubitz]

Hello Pedro!

On Fri, 2023-08-11 at 00:11 +, Pedro Miguel Justo wrote:
> It seems as a recent change has caused a regression on Itanium (ia64), 
> rendering the platform unbootable. GRUB will crash very early with:
> 
> 
> ```
> Welcome to GRUB!
> 
> 7 0 0x6B 0x001E unexpected trap
> 7 0 0x66 0x001E trap taken, number in ext PE
> 7 0 0x3C 0x5A00 trap taken, offset in ext PE
> ```
> 
> I have bisected the issue and it resulted into the following change:
> 
> ```
> 06edd40db76bb78457ac26156ed5f7b62381bbe8 is the first bad commit
> commit 06edd40db76bb78457ac26156ed5f7b62381bbe8
> Author: Oliver Steffen 
> Date:   Fri May 26 13:35:43 2023 +0200
> 
> guid: Unify GUID types
> 
> There are 3 implementations of a GUID in GRUB. Replace them with
> a common one, placed in types.h.
> 
> It uses the "packed" flavor of the GUID structs, the alignment attribute
> is dropped, since it is not required.
> 
> Signed-off-by: Oliver Steffen 
> Reviewed-by: Daniel Kiper 
> ```

Thanks for bisecting this. Please always make sure to CC the original author of
the patch so he becomes aware of the breakage that was introduced by his patch.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913