Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > - ret

Bug#804079: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-11-29 Thread Ingo Jürgensmann
Am 29.11.2016 um 10:08 schrieb Wei Liu : >> http://paste.debian.net/895464/ > Entry not found -- maybe it expired... Sorry. Here it is: Nov 14 09:19:52 31.172.31.251 [39677.027813] BUG: unable to handle kernel Nov 14 09:19:52 31.172.31.251 at 880002b4c06e Nov 14 09:19:52 31.172.31.251 [396

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Linus Torvalds
On Tue, Nov 29, 2016 at 11:57 AM, Ben Hutchings wrote: > > If the modversion is missing then the fallback should be to a full > vermagic match, i.e. including the release string. Something like > this (untested): This really seems way too complicated for this situation. And it's wrong too. The

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Ben Hutchings
On Tue, 2016-11-29 at 08:17 -0800, Linus Torvalds wrote: > > On Tue, Nov 29, 2016 at 8:03 AM, Michal Marek wrote: > > > > The original and easily observable bug is that were are not generating > > symbol checksums for the asm-exported symbols, so they default to 0. > > This can be seen e.g. in th

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Linus Torvalds
On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds wrote: > > So quite frankly, I don't want to make our kernel sources worse due to > broken shit tools getting something wrong that we shouldn't even care > about. And yes, I'm on binutils 2.26 (with no issues), so it could be that it's 2.27 that tri

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Linus Torvalds
On Tue, Nov 29, 2016 at 9:05 AM, Adam Borowski wrote: > > Thus, if it's indeed binutils, you'll see the breakage as soon as Fedora > recovers from the freeze. So quite frankly, I don't want to make our kernel sources worse due to broken shit tools getting something wrong that we shouldn't even ca

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Tue, Nov 29, 2016 at 07:27:12AM -0800, Linus Torvalds wrote: > On Nov 29, 2016 5:51 AM, "Adam Borowski" wrote: > > > > > > (a) tested > > > > By many people. > > No. > > I've tested the build *without* this, and it works fine. Michal mentioned "why", let's try "where". I have no idea what

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Linus Torvalds
On Tue, Nov 29, 2016 at 8:03 AM, Michal Marek wrote: > > The original and easily observable bug is that were are not generating > symbol checksums for the asm-exported symbols, so they default to 0. > This can be seen e.g. in the Module.symvers file. This seemed like a > minor issue, because with

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it >> >> The actual logic

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Linus Torvalds
On Nov 29, 2016 5:51 AM, "Adam Borowski" wrote: > > > > > (a) tested > > By many people. No. I've tested the build *without* this, and it works fine. > > (b) explains it > > The actual logic is in 4efca4ed0. It wants C prototypes defined in > asm/asm-prototypes.h that lists symbols defined

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Tue, Nov 29, 2016 at 02:29:54PM +0100, Ingo Molnar wrote: > * Adam Borowski wrote: > > > Here's some history: > > The day of -rc1, multiple people immediately reported the breakage; it was > > quickly found out that reverting 784d5699eddc fixes it. A "going forward" > > patch has been posted

[PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds modversion support for symbols exported from asm files. Architectures must include C-style declarations for those symbols in asm/asm-prototypes.h in order for them to be versioned. Add these declarations for x86, and an archi

Bug#843349: (no subject)

2016-11-29 Thread Alexander Kanavin
FWIW, we had the same problem here with machines using Gigabyte X99 motherboards. The problem was solved by updating the BIOS. Alex

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Ingo Molnar
* Adam Borowski wrote: > Here's some history: > The day of -rc1, multiple people immediately reported the breakage; it was > quickly found out that reverting 784d5699eddc fixes it. A "going forward" > patch has been posted but was insufficient; when the real devs went to bed > the last message

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Adam Borowski
On Mon, Nov 28, 2016 at 08:08:57PM -0800, Linus Torvalds wrote: > On Mon, Nov 28, 2016 at 5:15 PM, Ben Hutchings wrote: > >> > >> The modversions stuff may just be too painful to bother with. Very few > >> people probably use it, and the ones that do likely don't have any > >> overriding reason wh

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri, 2016-11-25 at 10:01 -0800, Linu

Bug#804079: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-11-29 Thread Wei Liu
On Mon, Nov 14, 2016 at 04:55:40PM +0100, Andreas Ziegler wrote: > Hi, > > few months later Ingo decided again to give it a try as he really > doesn't want to keep ipv6 disabled in 2016. > He tried Xen 4.8 - which didn't help, the crash reappeared. > He then managed to build Xen with debug=y and s