Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-12-12 Thread Luis R. Rodriguez
On Mon, Oct 24, 2011 at 6:12 AM, Ben Hutchings b...@decadent.org.uk wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good.  We already consider staging modules to be suspect, and this should also be true for out-of-tree modules which may receive very little

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-12-12 Thread Ben Hutchings
On Mon, Dec 12, 2011 at 01:40:44PM -0800, Luis R. Rodriguez wrote: On Mon, Oct 24, 2011 at 6:12 AM, Ben Hutchings b...@decadent.org.uk wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good.  We already consider staging modules to be suspect, and this

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-12-12 Thread Luis R. Rodriguez
On Mon, Dec 12, 2011 at 1:58 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, Dec 12, 2011 at 01:40:44PM -0800, Luis R. Rodriguez wrote: On Mon, Oct 24, 2011 at 6:12 AM, Ben Hutchings b...@decadent.org.uk wrote: Use of the GPL or a compatible licence doesn't necessarily make the code

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-12-12 Thread Luis R. Rodriguez
On Mon, Dec 12, 2011 at 2:47 PM, Luis R. Rodriguez mcg...@frijolero.org wrote: On Mon, Dec 12, 2011 at 1:58 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, Dec 12, 2011 at 01:40:44PM -0800, Luis R. Rodriguez wrote: On Mon, Oct 24, 2011 at 6:12 AM, Ben Hutchings b...@decadent.org.uk wrote:

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-12-12 Thread Ben Hutchings
On Mon, 2011-12-12 at 14:47 -0800, Luis R. Rodriguez wrote: On Mon, Dec 12, 2011 at 1:58 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, Dec 12, 2011 at 01:40:44PM -0800, Luis R. Rodriguez wrote: [...] It seems this taint flag will be used for driers backported through

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-31 Thread Rusty Russell
On Wed, 26 Oct 2011 21:55:28 -0400, Dave Jones da...@redhat.com wrote: On Thu, Oct 27, 2011 at 11:41:37AM +1030, Rusty Russell wrote: I think we need a taint_string() function, and instead of lockdep disabling itself it should note the taint string in its reports. Similarly for

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-27 Thread Greg KH
On Thu, Oct 27, 2011 at 11:41:37AM +1030, Rusty Russell wrote: On Wed, 26 Oct 2011 09:08:34 -0400, Nick Bowler nbow...@elliptictech.com wrote: On 2011-10-25 22:54 +0200, Greg KH wrote: On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: On Tue, Oct 25, 2011 at 10:04:55PM +0200,

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-26 Thread Mathieu Desnoyers
* Rusty Russell (ru...@rustcorp.com.au) wrote: On Tue, 25 Oct 2011 16:17:24 -0400, Dave Jones da...@redhat.com wrote: commit 7816c45bf13255157c00fb8aca86cb64d825e878 Author: Roland Vossen rvos...@broadcom.com Date: Thu Apr 7 11:20:58 2011 +0200 modules: Enabled dynamic debugging

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-26 Thread Nick Bowler
On 2011-10-25 22:54 +0200, Greg KH wrote: On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowler wrote: This is not the case: lockdep works fine with staging

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-26 Thread Rusty Russell
On Wed, 26 Oct 2011 09:08:34 -0400, Nick Bowler nbow...@elliptictech.com wrote: On 2011-10-25 22:54 +0200, Greg KH wrote: On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: On Tue, Oct 25, 2011 at 12:51:42PM

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-26 Thread Dave Jones
On Thu, Oct 27, 2011 at 11:41:37AM +1030, Rusty Russell wrote: I think we need a taint_string() function, and instead of lockdep disabling itself it should note the taint string in its reports. Similarly for anything else (oops already does this). you mean like print_tainted() ?

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Ben Hutchings
On Tue, 2011-10-25 at 14:26 +1030, Rusty Russell wrote: On Mon, 24 Oct 2011 07:57:03 -0700, Randy Dunlap rdun...@xenotime.net wrote: On 10/24/11 06:12, Ben Hutchings wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Ben Hutchings
On Tue, 2011-10-25 at 11:38 -0400, Nick Bowler wrote: On 2011-10-25 14:26 +1030, Rusty Russell wrote: From: Ben Hutchings b...@decadent.org.uk Subject: module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree Date: Mon, 24 Oct 2011 15:12:28 +0200 Use of the GPL or a

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Greg KH
On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowler wrote: On 2011-10-25 18:05 +0200, Ben Hutchings wrote: On Tue, 2011-10-25 at 11:38 -0400, Nick Bowler wrote: This patch prevents the use of lockdep for debugging out of tree modules, which is rather mean. It was already disabled

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Dave Jones
On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowler wrote: On 2011-10-25 18:05 +0200, Ben Hutchings wrote: On Tue, 2011-10-25 at 11:38 -0400, Nick Bowler wrote: This patch prevents the use of lockdep for debugging

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Greg KH
On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowler wrote: On 2011-10-25 18:05 +0200, Ben Hutchings wrote: On Tue, 2011-10-25 at 11:38 -0400, Nick Bowler

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Rusty Russell
On Tue, 25 Oct 2011 16:17:24 -0400, Dave Jones da...@redhat.com wrote: commit 7816c45bf13255157c00fb8aca86cb64d825e878 Author: Roland Vossen rvos...@broadcom.com Date: Thu Apr 7 11:20:58 2011 +0200 modules: Enabled dynamic debugging for staging modules ... Signed-off-by:

[PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-24 Thread Ben Hutchings
Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging modules to be suspect, and this should also be true for out-of-tree modules which may receive very little review. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- Debian has been

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-24 Thread Dave Jones
On Mon, Oct 24, 2011 at 03:12:28PM +0200, Ben Hutchings wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging modules to be suspect, and this should also be true for out-of-tree modules which may receive very little review.

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-24 Thread Randy Dunlap
On 10/24/11 06:12, Ben Hutchings wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging modules to be suspect, and this should also be true for out-of-tree modules which may receive very little review. Signed-off-by: Ben

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-24 Thread Rusty Russell
On Mon, 24 Oct 2011 07:57:03 -0700, Randy Dunlap rdun...@xenotime.net wrote: On 10/24/11 06:12, Ben Hutchings wrote: Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging modules to be suspect, and this should also be true for