Re: [PATCH] module: Enable dynamic debugging regardless of taint
* Rusty Russell (ru...@rustcorp.com.au) wrote: On Tue, 01 Nov 2011 03:59:33 +, Ben Hutchings b...@decadent.org.uk wrote: Dynamic debugging is currently disabled for tainted modules, except for TAINT_CRAP. This prevents use of dynamic debugging for out-of-tree modules now that they are also tainted. This condition was apparently intended to avoid a crash if a force- loaded module has an incompatible definition of dynamic debug structures. However, a administrator that forces us to load a module is claiming that it *is* compatible even though it fails our version checks. If they are mistaken, there are any number of ways the module could crash the system. Signed-off-by: Ben Hutchings b...@decadent.org.uk Thanks, applied, unless Mathieu objects... I'm OK with that. We should probably note in the changelog the side-effect of now supporting dynamic debugging of proprietary drivers. If we start doing this for dynamic debugging, I'd be tempted to do it for tracepoints and static jump labels too, since at least tracepoints would not be the only offender (from an end-user point of view) causing crashes on incompatible module load. Thanks! Acked-by: Mathieu Desnoyers mathieu.desnoy...@efficios.com Cheers, Rusty. -- Mathieu Desnoyers Operating System Efficiency RD Consultant EfficiOS Inc. http://www.efficios.com -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2001124859.GA1698@Krystal
[PATCH] module: Enable dynamic debugging regardless of taint
Dynamic debugging is currently disabled for tainted modules, except for TAINT_CRAP. This prevents use of dynamic debugging for out-of-tree modules now that they are also tainted. This condition was apparently intended to avoid a crash if a force- loaded module has an incompatible definition of dynamic debug structures. However, a administrator that forces us to load a module is claiming that it *is* compatible even though it fails our version checks. If they are mistaken, there are any number of ways the module could crash the system. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- kernel/module.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index dab585e..ef8cb70 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2881,8 +2881,7 @@ static struct module *load_module(void __user *umod, } /* This has to be done once we're sure module name is unique. */ - if (!mod-taints || mod-taints == (1UTAINT_CRAP)) - dynamic_debug_setup(info.debug, info.num_debug); + dynamic_debug_setup(info.debug, info.num_debug); /* Find duplicate symbols */ err = verify_export_symbols(mod); @@ -2918,8 +2917,7 @@ static struct module *load_module(void __user *umod, module_bug_cleanup(mod); ddebug: - if (!mod-taints || mod-taints == (1UTAINT_CRAP)) - dynamic_debug_remove(info.debug); + dynamic_debug_remove(info.debug); unlock: mutex_unlock(module_mutex); synchronize_sched(); -- 1.7.7 -- Ben Hutchings Computers are not intelligent. They only think they are. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1320119973.30281.7.camel@deadeye
Re: [PATCH] module: Enable dynamic debugging regardless of taint
On Tue, 01 Nov 2011 03:59:33 +, Ben Hutchings b...@decadent.org.uk wrote: Dynamic debugging is currently disabled for tainted modules, except for TAINT_CRAP. This prevents use of dynamic debugging for out-of-tree modules now that they are also tainted. This condition was apparently intended to avoid a crash if a force- loaded module has an incompatible definition of dynamic debug structures. However, a administrator that forces us to load a module is claiming that it *is* compatible even though it fails our version checks. If they are mistaken, there are any number of ways the module could crash the system. Signed-off-by: Ben Hutchings b...@decadent.org.uk Thanks, applied, unless Mathieu objects... Cheers, Rusty. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87lis0v4ih@rustcorp.com.au
